On 2018-09-26 09:04:14 +0900, Michael Paquier wrote: > Hi Andres, > > On Tue, Sep 25, 2018 at 11:39:05PM +0000, Andres Freund wrote: > > Remove absolete function TupleDescGetSlot(). > > > > TupleDescGetSlot() was kept around for backward compatibility for > > user-written SRFs. With the TupleTableSlot abstraction work, that code > > will need to be version specific anyway, so there's no point in > > keeping the function around any longer. > > There are still references in the code to this function, and a > declaration of it:
Hrmpf :/. Thanks for catching. > src/include/funcapi.h: * TupleTableSlot *TupleDescGetSlot(TupleDesc tupdesc) > - Builds a > src/include/funcapi.h:extern TupleTableSlot *TupleDescGetSlot(TupleDesc > tupdesc); These two clearly need to go. > git grep TupleDescGetSlot > doc/src/sgml/xfunc.sgml: * user-defined SRFs that use the deprecated > TupleDescGetSlot(). > src/include/funcapi.h: * user-defined SRFs that use the deprecated > TupleDescGetSlot(). But here I'm less convinced. It's not entirely clear to me that the only real reason for this to exists actually was TupleDescGetSlot(). OTOH, I can't really see any proper reason to have it either. Greetings, Andres Freund
