> Hi,
>
> I found that a argument "filename" is not used in execute_sql_string()
> although the comment says "filename is used only to report errors.",
> so I think we can remove this argument as done in the patch I attached.
It seems the "filename" argument has been there since the first
versio
Hello.
At Fri, 07 Sep 2018 16:12:29 -0400, Tom Lane wrote in
<19695.1536351...@sss.pgh.pa.us>
> Bruce Momjian writes:
> > So, are we going to output a notice if a non-100% fill factor is
> > specified?
>
> I would not think that's helpful.
I agree. My understanding is that:
It has'nt been wo
On 12/09/2018 15:18, Arthur Zakirov wrote:
> On Mon, Aug 27, 2018 at 04:25:28PM +0200, Peter Eisentraut wrote:
>> Whenever some pg_attribute field is added or changed, a lot of
>> repetitive changes all over the code are necessary. Here is a small
>> change to remove one such place.
>
> It looks
On 2018/09/13 12:37, Michael Paquier wrote:
> On Wed, Sep 12, 2018 at 12:14:00PM -0400, Tom Lane wrote:
>> I thought we had a macro or utility function somewhere that knew which
>> relkinds have storage, though I can't find it right now. I'd be
>> inclined to instantiate that if it doesn't exist,
On 2018/09/13 1:14, Tom Lane wrote:
> Amit Langote writes:
>> The infamous missing-relkind-check in heap_truncate() seems to be behind
>> this. Perhaps, a patch like the attached will do?
>
> That seems excessively restrictive. Anything that has storage (e.g.
> matviews) ought to be truncatable
On Wed, Sep 12, 2018 at 08:17:05PM -0400, Tom Lane wrote:
> Yeah, I was afraid of that. We could invent a typedef "pg_struct_stat"
> that maps to the right thing, but using that everywhere would be a mighty
> invasive change :-(.
There are 130 places where "struct stat " is used, so I'd rather av
On Wed, Sep 12, 2018 at 08:04:53PM -0300, Alvaro Herrera wrote:
> Well, mine is there, and it's correct:
>
> Li America/Santiago Chile/Continental
> Li Pacific/Easter Chile/EasterIsland
>
> Laugh all you want about Chile of all countries having multiple
> timezones ...
Impressed is a better word
On Wed, Sep 12, 2018 at 05:36:31PM +0900, Masahiko Sawada wrote:
> It would be useful if we have a number of the options autovacuum
> workers could use but since there are only 2 I'm not sure we need the
> list-style.
Looking at what Sergei has proposed upthread again, using a
comma-separated list
On Wed, Sep 12, 2018 at 02:41:11PM +0200, Peter Eisentraut wrote:
> On 12/09/2018 10:32, Ioseph Kim wrote:
>> ok, in case pg_config, ignore this, but It should be review in case ecpg.
>
> fixed
Thanks Peter for jumping in the ship. What you did looks correct to
me.
--
Michael
signature.asc
Des
On Wed, Sep 12, 2018 at 12:14:00PM -0400, Tom Lane wrote:
> I thought we had a macro or utility function somewhere that knew which
> relkinds have storage, though I can't find it right now. I'd be
> inclined to instantiate that if it doesn't exist, and then the code
> here ought to read something
On Thu, Sep 13, 2018 at 01:14:12AM +, Tsunakawa, Takayuki wrote:
> Some customer wants to change the setting per standby, i.e., a shorter
> timeout for a standby in the same region to enable faster detection
> failure and failover, and a longer timeout for a standby in the remote
> region (for
On Thu, Sep 13, 2018 at 11:20 AM Tom Lane wrote:
> Michael Paquier writes:
> > On Wed, Sep 12, 2018 at 10:00:21AM -0400, Tom Lane wrote:
> >> I believe that this patch will never make for any functional change,
> >> it will only give you some other alias for the zone it would have
> >> selected a
Hello,
What do you think about changing wal_sender_timeout from PGC_HUP to PGC_BACKEND
or PGC_USERSET?
Some customer wants to change the setting per standby, i.e., a shorter timeout
for a standby in the same region to enable faster detection failure and
failover, and a longer timeout for a sta
Andrew Gierth writes:
> "Tom" == Tom Lane writes:
> Tom> * I'm almost thinking that changing to list_union is a bad idea,
> A fair point. Though it looks like list_union is used in only about 3
> distinct places, and two of those are list_union(NIL, blah) to simply
> remove dups from a single l
> "Tom" == Tom Lane writes:
Tom> * I'm almost thinking that changing to list_union is a bad idea,
A fair point. Though it looks like list_union is used in only about 3
distinct places, and two of those are list_union(NIL, blah) to simply
remove dups from a single list. The third place is th
On Wed, Sep 12, 2018 at 03:55:00PM -0400, Tom Lane wrote:
> Although pg_ctl could sneak it in between forking and execing, it seems
> like it'd be cleaner to have the postmaster proper do it in response to
> a switch that pg_ctl passes it. That avoids depending on the fork/exec
> separation, and m
Michael Paquier writes:
> On Wed, Sep 12, 2018 at 12:47:31PM +0900, Michael Paquier wrote:
>> That's exactly what I would like to do and what I meant two paragraphs
>> above as that's the only solution I think would be clean, and this would
>> take care of st_size nicely. I have not tested (yet),
On Wed, Sep 12, 2018 at 12:47:31PM +0900, Michael Paquier wrote:
> That's exactly what I would like to do and what I meant two paragraphs
> above as that's the only solution I think would be clean, and this would
> take care of st_size nicely. I have not tested (yet), but some tweaks
> in win32_po
Michael Paquier writes:
> On Wed, Sep 12, 2018 at 10:00:21AM -0400, Tom Lane wrote:
>> I believe that this patch will never make for any functional change,
>> it will only give you some other alias for the zone it would have
>> selected anyway.
> Looking at the list of aliases, I am not seeing li
On 2018-Sep-13, Michael Paquier wrote:
> Looking at the list of aliases, I am not seeing listed countries running
> across multiple timezones, so that may be fine..
Well, mine is there, and it's correct:
Li America/Santiago Chile/Continental
Li Pacific/Easter Chile/EasterIsland
Laugh all you wa
On Wed, Sep 12, 2018 at 10:00:21AM -0400, Tom Lane wrote:
> Michael Paquier writes:
>> One thing that I can see changing with this patch is how timezone is set
>> in postgresql.conf. For example, on HEAD I get 'Japan' while this patch
>> gives back 'Asia/Tokyo'. Could it be an issue for countrie
"Bradley DeJong" writes:
> Is the reviewer supposed to move this to "ready for committer" or is the
> author supposed to do that?
The reviewer does that, indicating signoff.
regards, tom lane
Arthur Zakirov writes:
> On Wed, Sep 12, 2018 at 04:03:57PM -0400, Tom Lane wrote:
>> Did you miss including Makefile changes in the submitted patch?
> I've noticed the error some time ago. And I tried to understand why
> cfbot can't build it. Somehow cfbot didn't rename
> stem_ISO_8859_1_hungari
on 2018-08-30, Fabien Coelho wrote ...
> ... Find v3 attached. ...
Hi Fabien,
As we're coming up on the end of this commitfest ...
Is the reviewer supposed to move this to "ready for committer" or is the
author supposed to do that?
Is the reviewer supposed to explicitly state "I've looked at
On Wed, Sep 12, 2018 at 04:03:57PM -0400, Tom Lane wrote:
> I see that the cfbot is having difficulty building this:
>
> make[2]: *** No rule to make target `stem_ISO_8859_2_hungarian.o', needed by
> `dict_snowball.so'. Stop.
>
> Did you miss including Makefile changes in the submitted patch?
Andrew Gierth writes:
> So I'm looking to commit this, and here's my comments so far:
I took a quick look over this. I agree with your nitpicks, and have
a couple more:
* Please run it through pgindent. That will, at a minimum, remove some
gratuitous whitespace changes in this patch. I think
Re: Andres Freund 2018-09-12 <20180912210338.h3vsss5lkuu26...@alap3.anarazel.de>
> Hi,
>
> On 2018-09-12 14:45:17 +0200, Christoph Berg wrote:
> > LLVM 7 landed in Debian unstable, this patch teaches ./configure to use
> > it. (General patch, not specific to Debian.)
>
> Thanks. Yes, I think we
Hi,
On 2018-09-12 14:45:17 +0200, Christoph Berg wrote:
> LLVM 7 landed in Debian unstable, this patch teaches ./configure to use
> it. (General patch, not specific to Debian.)
Thanks. Yes, I think we should do that, especially because my patches
to add proper debugging and profiling support onl
I wrote:
> Stephen Frost writes:
>> We seem to be a bit past that timeline... Do we have any update on when
>> this will be moving forward?
>> Or did I miss something?
> Nope, you didn't. Folks have been on holiday which made it hard to keep
> forward progress going, particularly with respect t
> On 12 Sep 2018, at 22:15, Andrew Gierth wrote:
> WindowClauseSortNode - I don't like this name, because it's not actually
> a Node of any kind. How about WindowSortData?
That’s a good point. I probably would’ve named it WindowClauseSortData since
it acts on WindowClauses, but that might just
So I'm looking to commit this, and here's my comments so far:
WindowClauseSortNode - I don't like this name, because it's not actually
a Node of any kind. How about WindowSortData?
list_concat_unique(list_copy(x),y) is exactly list_union(x,y), which
looks a bit nicer to me.
re. this:
for (;
I see that the cfbot is having difficulty building this:
make[2]: *** No rule to make target `stem_ISO_8859_2_hungarian.o', needed by
`dict_snowball.so'. Stop.
Did you miss including Makefile changes in the submitted patch?
regards, tom lane
Andrew Gierth writes:
> "Tom" == Tom Lane writes:
> Tom> Hmph. Can't we just ignore that error?
> If you ignore the error from setsid(), then you're still a process group
> leader (as you would be after running setsid()), but you're still
> attached to whatever controlling terminal (if any) yo
> "Tom" == Tom Lane writes:
>> The tricky part about doing setsid() is this: you're not allowed to
>> do it if you're already a process group leader. silent_mode worked
>> by having postmaster do another fork, exit in the parent, and do
>> setsid() in the child.
Tom> Hmph. Can't we jus
Andrew Gierth writes:
> "Tom" == Tom Lane writes:
> Tom> We'd likely need a switch to control that. If memory serves, there
> Tom> used to be such a switch, but we got rid of the postmaster's
> Tom> setsid call and the switch too. We probably should dig in the
> Tom> archives and review the r
Arthur Zakirov writes:
> On Sun, Jul 29, 2018 at 07:42:43PM -0500, Justin Pryzby wrote:
>>> Actually..another thought: since toast tables may be VACUUM-ed, should I
>>> introduce Query_for_list_of_tpmt ?
>> I didn't include this one yet though.
> I think it could be done by a separate patch.
I
> "Tom" == Tom Lane writes:
Tom> BTW, just thinking outside the box a bit --- perhaps the ideal
Tom> behavior to address Michael's use-case would be to have the
Tom> postmaster itself do setsid(), but not until it reaches the state
Tom> of being ready to accept client connections.
Tom>
В письме от 10 сентября 2018 18:02:10 пользователь Aleksandr Parfenov написал:
> I did a quick look at yout patch and have some questions/points to
> discuss. I like the idea of the patch and think that enum reloptions
> can be useful. Especially for some frequently checked values, as it was
> men
I wrote:
> Michael Paquier writes:
>> Hmm. This patch breaks a feature of pg_ctl that I am really fond of for
>> development. When starting a node which enters in recovery, I sometimes
>> use Ctrl-C to stop pg_ctl, which automatically makes the started
>> Postgres instance to stop, and this save
Alexander Kuzmenkov writes:
> I benchmarked this, using your testbed and comparing to libc sprintf
> (Ubuntu GLIBC 2.27-0ubuntu3) and another implementation I know [1], all
> compiled with gcc 5.
Thanks for reviewing!
The cfbot noticed that the recent dlopen patch conflicted with this in
confi
Michael Paquier writes:
> I would have liked to look at this patch in details, but it failed to
> apply. Could you rebase?
Ah, yeah, the dlopen patch touched a couple of the same places.
Rebase attached --- no substantive changes.
regards, tom lane
diff --git a/configur
Hi,
On Fri, May 11, 2018 at 11:08:52AM -0400, Bruce Momjian wrote:
> I have committed the first draft of the Postgres 11 release notes. I
> will add more markup soon. You can view the most current version here:
>
> http://momjian.us/pgsql_docs/release-11.html
The first item of section '
> "Andrew" == Andrew Gierth writes:
Andrew> Simpler testcase, removing the CTE, so this is clearly just
Andrew> about InitPlan:
So I can see exactly where the problem is, but I'm not sure what the
solution should be.
EvalPlanQualStart copies the param_exec value list explicitly _not_
incl
Hi,
Am Dienstag, den 20.09.2016, 20:59 -0400 schrieb Peter Eisentraut:
> On 9/19/16 3:23 PM, Michael Banck wrote:
> > Version 2 attached.
>
> Committed, thanks.
>
> I added the new option to the help output in pg_restore.
I noticed this part of the help text does not mention `-N' when I think
i
> "Andrew" == Andrew Gierth writes:
Andrew> Going to see if this can be narrowed down further.
Simpler testcase, removing the CTE, so this is clearly just about
InitPlan:
create table mytable (flag boolean default false, foo integer);
insert into mytable default values;
session B:
begin
> "Andrew" == Andrew Gierth writes:
Andrew> Bingo - I have a test case, which I'll post in a sec after
Andrew> testing it on other versions.
OK, not only does it break in latest 9.3 stable, it also breaks in
current master.
This is the testcase:
create table mytable (id integer, foo text
> "Andrew" == Andrew Gierth writes:
> "Kyle" == Kyle Samson writes:
Kyle> This is on a 9.3.19 server and we saw no
Kyle> mention of a fix in the release notes since this version and we
Kyle> do not know if it affects later major releases as well.
Andrew> There's a relevant commit fr
Amit Langote writes:
> The infamous missing-relkind-check in heap_truncate() seems to be behind
> this. Perhaps, a patch like the attached will do?
That seems excessively restrictive. Anything that has storage (e.g.
matviews) ought to be truncatable, no?
I thought we had a macro or utility fun
> "Andrew" == Andrew Gierth writes:
Tom> The reason this seems possibly different is that we're apparently
Tom> returning wrong data out of the sub-select (a zero Datum value,
Tom> but not marked isnull --- if it were, arraycontains wouldn't be
Tom> reached). The previously fixed bug woul
> "Tom" == Tom Lane writes:
>> There's a relevant commit from Feb this year (ea6d67cf8)
>> specifically referring to the case of CTEs inside subplans inside
>> EvalPlanQual, which is exactly the scenario you have in your query.
>> So you need to try this in 9.3.22 or later (ideally 9.3.24
Peter Eisentraut writes:
> Some small comments on the code:
> Maybe add a ready_list_free() to go with ready_list_init(), instead of
> calling pg_free(ready_list.tes) directly.
> get_next_work_item() has been changed to remove the work item from the
> ready_list. Maybe rename to something like p
Andrew Gierth writes:
> "Kyle" == Kyle Samson writes:
> Kyle> We encountered a query that has been able to frequently segfault
> Kyle> one of our postgres instances under certain conditions which we
> Kyle> have not fully been able to isolate for reproduction. We were
> Kyle> able to get a co
On Wed, Sep 12, 2018 at 9:23 PM, Jesper Pedersen
wrote:
> Hi Amit,
>
> On 9/12/18 1:23 AM, Amit Langote wrote:
>>
>> Please find attached revised patches.
>>
>
> After applying 0004 I'm getting a crash in 'eval-plan-qual' during
> check-world using
>
> export CFLAGS="-DCOPY_PARSE_PLAN_TREES -O0 -f
On 12-09-2018 17:04, Fabien COELHO wrote:
Hello Marina,
You can get other errors that cannot happen for only one client if you
use shell commands in meta commands:
Or if you use untrusted procedural languages in SQL expressions (see
the used file in the attachments):
Or if you try to creat
> "Kyle" == Kyle Samson writes:
Kyle> Hello,
Kyle> We encountered a query that has been able to frequently segfault
Kyle> one of our postgres instances under certain conditions which we
Kyle> have not fully been able to isolate for reproduction. We were
Kyle> able to get a core dump out
Michael Paquier writes:
> On Mon, Aug 06, 2018 at 12:11:26PM +0800, Paul Guo wrote:
>> Yes, if considering the case of starting postmaster manually, we can not
>> create
>> a new session in postmaster, so pg_ctl seems to be a good place for setsid()
>> call. Attached a newer patch. Thanks.
> Hmm.
Hello,
We encountered a query that has been able to frequently segfault one of our
postgres instances under certain conditions which we have not fully been able
to isolate for reproduction. We were able to get a core dump out of one of the
crashes and have poked at it, but we believe the answer
Hello Marina,
You can get other errors that cannot happen for only one client if you use
shell commands in meta commands:
Or if you use untrusted procedural languages in SQL expressions (see the used
file in the attachments):
Or if you try to create a function and perhaps replace an exis
Michael Paquier writes:
> One thing that I can see changing with this patch is how timezone is set
> in postgresql.conf. For example, on HEAD I get 'Japan' while this patch
> gives back 'Asia/Tokyo'. Could it be an issue for countries with
> multiple timezones? I am not sure how Russian systems
On Mon, Aug 27, 2018 at 04:25:28PM +0200, Peter Eisentraut wrote:
> Whenever some pg_attribute field is added or changed, a lot of
> repetitive changes all over the code are necessary. Here is a small
> change to remove one such place.
It looks like a reasonable change to me.
The code is good an
On 11-09-2018 18:29, Fabien COELHO wrote:
Hello Marina,
Hmm, but we can say the same for serialization or deadlock errors that
were not retried (the client test code itself could not run correctly
or the SQL sent was somehow wrong, which is also the client's fault),
can't we?
I think not.
LLVM 7 landed in Debian unstable, this patch teaches ./configure to use
it. (General patch, not specific to Debian.)
Christoph
>From 19afeadb2491b09e6856ef8010fecbe688cb6042 Mon Sep 17 00:00:00 2001
From: Christoph Berg
Date: Wed, 12 Sep 2018 14:41:39 +0200
Subject: [PATCH] Support LLVM 7
Upstre
On 12/09/2018 10:32, Ioseph Kim wrote:
> ok, in case pg_config, ignore this, but It should be review in case ecpg.
fixed
> 2018년 09월 12일 16:03에 Michael Paquier 이(가) 쓴 글:
>> On Wed, Sep 12, 2018 at 03:55:56PM +0900, Ioseph Kim wrote:
>>> check please pg_config --version too.
>> Well, one problem w
Hi Amit,
On 9/12/18 1:23 AM, Amit Langote wrote:
Please find attached revised patches.
After applying 0004 I'm getting a crash in 'eval-plan-qual' during
check-world using
export CFLAGS="-DCOPY_PARSE_PLAN_TREES -O0 -fno-omit-frame-pointer" &&
./configure --enable-dtrace --with-openssl --w
On Wed, 2018-09-12 at 14:43 +0900, Michael Paquier wrote:
> On Mon, Sep 10, 2018 at 04:46:40PM +0200, Laurenz Albe wrote:
> > I didn't get pg_upgrade to work without the log file hacks; I suspect
> > that there is more than just log file locking going on, but my Windows
> > skills are limited.
> >
Re: Peter Eisentraut 2018-09-12
<0447ec7b-cdb6-7252-7943-88a4664e7...@2ndquadrant.com>
> > Naive idea: make that catalog shared? Collations are system-wide after
> > all.
>
> By the same argument, extensions should be shared, but they are not.
But extensions put a lot of visible stuff into a dat
On 12/09/2018 10:15, Christoph Berg wrote:
> Re: Thomas Munro 2018-09-07
>
>> 2. We could remove datcollate and datctype and instead store a
>> collation OID. I'm not sure what problems would come up, but for
>> starters it seems a bit weird to have a shared catalog pointing to
>> rows in a non
On 2018/09/12 19:29, Rajkumar Raghuwanshi wrote:
> Hi,
>
> I am getting below error while creating temp root partition table with on
> commit. getting same error from v10 onwards.
>
> [edb@localhost bin]$ ./psql postgres
> psql (10.5)
> Type "help" for help.
>
> postgres=# CREATE TEMP TABLE test
Hi,
I am getting below error while creating temp root partition table with on
commit. getting same error from v10 onwards.
[edb@localhost bin]$ ./psql postgres
psql (10.5)
Type "help" for help.
postgres=# CREATE TEMP TABLE test ( c1 varchar, c2 int) PARTITION BY RANGE
(c1) ON COMMIT DELETE ROWS;
On 28/08/2018 20:47, Tom Lane wrote:
> Here's a proposed patch for this. It removes the hacking of the TOC list
> order, solving Peter's original problem, and instead sorts-by-size
> in the actual parallel dump or restore control code.
I have reviewed this patch. I haven't done any major perform
Hello Hironobu-san,
However, the implementation of the scatter operation in this patch overflows
in many cases if the variable:size is 38 bit integer or greater. Because the
variable:size and the item of the array:primes[] which stores 27-29 bit
integers are multiplicated. If overflow occurs,
On 12.09.2018 08:14, David Rowley wrote:
On 12 September 2018 at 08:32, Konstantin Knizhnik
wrote:
Also the patch proposed by you is much simple and does mostly the same. Yes,
it is not covering CHECK constraints,
but as far as partitioning becomes now standard in Postgres, I do not think
th
On Tue, Jul 24, 2018 at 8:25 PM, Michael Paquier wrote:
> On Tue, Jul 24, 2018 at 06:02:00PM +0900, Masahiko Sawada wrote:
>> Yeah, for translation I think it's better to make full lines. When we
>> added "aggressive" to autovacuum logs (commit b55509) we've done the
>> same thing.
>
> I am wonde
ok, in case pg_config, ignore this, but It should be review in case ecpg.
2018년 09월 12일 16:03에 Michael Paquier 이(가) 쓴 글:
On Wed, Sep 12, 2018 at 03:55:56PM +0900, Ioseph Kim wrote:
check please pg_config --version too.
Well, one problem with that is that you would break a ton of stuff which
p
Hello Michael,
12.09.2018 10:20, Michael Paquier wrote:
> On Mon, May 07, 2018 at 01:07:15PM -0400, Tom Lane wrote:
>> Robert Haas writes:
>>> After thinking about this some more, I think the question here is
>>> definitional. A first attempt at defining 'make installcheck' is to
>>> say that it
Re: Thomas Munro 2018-09-07
> 2. We could remove datcollate and datctype and instead store a
> collation OID. I'm not sure what problems would come up, but for
> starters it seems a bit weird to have a shared catalog pointing to
> rows in a non-shared catalog.
Naive idea: make that catalog sha
On Fri, Aug 10, 2018 at 02:31:25PM -0400, Tom Lane wrote:
> The cfbot points out that this has suffered bit-rot, so here's a rebased
> version --- no substantive changes.
+ /*
+* Try to read the symlink. If not there, not a symlink, etc etc, just
+* quietly fail; the precise reason need
On Mon, May 07, 2018 at 01:07:15PM -0400, Tom Lane wrote:
> Robert Haas writes:
>> After thinking about this some more, I think the question here is
>> definitional. A first attempt at defining 'make installcheck' is to
>> say that it runs the tests from the build tree against the running
>> serv
On Sun, Aug 19, 2018 at 03:12:00PM -0400, Tom Lane wrote:
> * The Windows aspects of this are untested. It seems like importing
> pgwin32_socket_strerror's behavior into the frontend ought to be a
> bug fix, though: win32_port.h redefines socket error symbols whether
> FRONTEND is set or not, so a
On Wed, Sep 12, 2018 at 03:55:56PM +0900, Ioseph Kim wrote:
> check please pg_config --version too.
Well, one problem with that is that you would break a ton of stuff which
parse this version string automatically. pg_config --version is used by
many extensions to guess which version of Postgres i
80 matches
Mail list logo
