On Tue, Dec 03, 2024 at 04:58:04PM +1100, Peter Smith wrote:
> Patch v6-0001 LGTM.
Right, it's true that this is a bit confusing when worded with terms
that are not in the description of the command.
The docs tend to prefer "the --foo option" when
referring to a specific switch in the notes secti
Patch v6-0001 LGTM.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
On Tue, Dec 3, 2024 at 10:25 AM Peter Smith wrote:
>
> Hi Shubham,
>
> The patch v5-0001 looks mostly OK to me (visual inspection only).
>
> But, I did notice one other improvement you could make in passing.
>
> 1.
> - TABLES. If publication-name option
> is
> - not specified, it has t
Hi Shubham,
The patch v5-0001 looks mostly OK to me (visual inspection only).
But, I did notice one other improvement you could make in passing.
1.
- TABLES. If publication-name option is
- not specified, it has the following name pattern:
+ TABLES. If --publication is not
+
On Tue, Dec 3, 2024 at 9:21 AM Peter Smith wrote:
>
> Hi Shubham,
>
> Here are my comments for v4-0001.
>
> 1.
> - If replication-slot-name is not specified, the
> + If the --replication-slot-name is not specified, the
>
> No. I already said before ([1] #2) that there is no such thing ca
Hi Shubham,
Here are my comments for v4-0001.
1.
- If replication-slot-name is not specified, the
+ If the --replication-slot-name is not specified, the
No. I already said before ([1] #2) that there is no such thing called
"--replication-slot-name". It should be called "--replication-
On Tue, Dec 3, 2024 at 8:39 AM Shubham Khanna
wrote:
>
> On Tue, Dec 3, 2024 at 7:16 AM Peter Smith wrote:
> >
> > Hi Shubham,
> >
> > I took a look at the patch v2-0001. Here are some review comments.
> >
> > 1.
> > Previously when this DOCS page was referring to the --publication and
> > --subs
On Tue, Dec 3, 2024 at 7:16 AM Peter Smith wrote:
>
> Hi Shubham,
>
> I took a look at the patch v2-0001. Here are some review comments.
>
> 1.
> Previously when this DOCS page was referring to the --publication and
> --subscription it was calling those "switches". I don't know why, but
> it does.
Hi Shubham,
I took a look at the patch v2-0001. Here are some review comments.
1.
Previously when this DOCS page was referring to the --publication and
--subscription it was calling those "switches". I don't know why, but
it does.
Maybe calling them "options" is ok too, but personally (for
consi
On Mon, Dec 2, 2024 at 4:57 PM vignesh C wrote:
>
> On Mon, 2 Dec 2024 at 15:00, Shubham Khanna
> wrote:
> >
> > On Mon, Dec 2, 2024 at 2:57 PM PG Doc comments form
> > wrote:
> > >
> > > The following documentation comment has been logged on the website:
> > >
> > > Page: https://www.postgresq
> On 27 Sep 2023, at 15:18, Peter Eisentraut wrote:
> A slightly fancier variant that avoids having to hardcode the git web URL
> pattern in a bunch of places:
>
> You mark it up like
>
>
>
> and then write a bit of XSL to process that into whatever form you want.
Álvaro reminded me abou
On Mon, 2 Dec 2024 at 15:00, Shubham Khanna wrote:
>
> On Mon, Dec 2, 2024 at 2:57 PM PG Doc comments form
> wrote:
> >
> > The following documentation comment has been logged on the website:
> >
> > Page: https://www.postgresql.org/docs/17/app-pgcreatesubscriber.html
> > Description:
> >
> > The
On Mon, Dec 2, 2024 at 2:57 PM PG Doc comments form
wrote:
>
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/17/app-pgcreatesubscriber.html
> Description:
>
> The page https://www.postgresql.org/docs/17/app-pgcreatesubscriber.html
> m
13 matches
Mail list logo
