On Tue, Dec 3, 2024 at 7:16 AM Peter Smith <smithpb2...@gmail.com> wrote: > > Hi Shubham, > > I took a look at the patch v2-0001. Here are some review comments. > > 1. > Previously when this DOCS page was referring to the --publication and > --subscription it was calling those "switches". I don't know why, but > it does. > > Maybe calling them "options" is ok too, but personally (for > consistency with the above) I would've stuck with the same "switches" > terminology. > > 1a. > /If --publication option is not specified.../If the --publication > switch is not specified.../ > > or maybe just omit the term entirely > /If --publication option is not specified.../If --publication is not > specified.../ > > ~ > > 1b. > /If --subscription option is not specified.../If the --subscription > switch is not specified.../ > > or maybe just omit the term entirely > /If --subscription option is not specified.../If --subscription is not > specified.../ > > ~~~ > > 2. > Although the patch addresses the reported problems, I think the same > problem exists for "replication-slot-name". e.g. the DOCS are saying > "If replication-slot-name is not specified..." although there is no > such thing -- it is called "--replication-slot" > > So, the patch should also be fixing that one using the same consistent > wording. > > e.g. > /If replication-slot-name is not specified.../If the > --replication-slot switch is not specified.../ > or > /If replication-slot-name is not specified.../If --replication-slot is > not specified.../ >
I have fixed the suggested changes. The attached Patch contains the required changes. Thanks and regards, Shubham Khanna.
v3-0001-DOCS-Fix.patch
Description: Binary data
