Re: Build failed in Jenkins: pgadmin4-master-python34 #440

Yes, I will look. Thanks, Surinder On Mon, Jan 22, 2018 at 4:25 PM, Dave Page wrote: > Hi Surinder, > > It seems that updating ESLint exposed various issues. Can you take a > look ASAP please? > > Thanks. > > > -- Forwarded message -- > From: pgAdmin 4 Jenkins > Date: Mon, Jan

[pgAdmin4][Patch]: Update ESLint to latest version

Hi In the current version of ESLint the option "--fix-dry-run" not working. So, updating to the latest one resolve this. Please find an attached patch. Thanks, Surinder update_eslint_to_latest.patch Description: Binary data

Re: Next release

b/python2.7/site-packages/alembic/script/base.py", >>> line 334, in _upgrade_revs >>> revs = list(revs) >>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>> ges/alembic/script/revision.py", line 645, in _iterate_revisions >>> re

Fwd: pgAdmin4 never loading

ame steps will fix the issue for Desktop version as well.​ > > > 2017-10-10 8:12 GMT+03:00 Surinder Kumar > : > >> Hi >> >> 1) Please update the nodeJS to the latest version. v4.2.6 is an older >> version. >> >> 2) Run following commands from '/pg

Re: pgAdmin4 never loading

R:nss_util.cc(808)] After loading > Root Certs, loaded==false: NSS error code: -8018" > Documented steps not help in my desktop case. > > On my servers old node > #node -v > v0.10.29 > on debian and > node -v > v4.2.6 > on ubuntu. This is a reason of problem? > &

Re: pgAdmin4 never loading

Hi Pavel, If you are building pgAdmin4 from the source, then you don't need to install pgAdmin4 from the wheel. After taking the pgAdmin4 source from git HEAD, you need to install nodeJS, Yarn to build JS/CSS modules. the error you are getting is possibly due to this. For more help, you can follo

[pgAdmin4][Patch]: Fix the path to font-mfizz library in style.css

Hi *Issue:* Webpacking the code fails due to the wrong path of "font-mfizz" library. [Reported by: Neel Patel] Please find an attached patch. Thanks, Surinder fix_font_mfizz_library_path.patch Description: Binary data

Re: v2.0-rc1 not starting, runtime not building

l5-dev:amd64 ? If so then it is installed. It would be great if we can get the runtime working. please see the attached log. cheers, Willy-Bas On Fri, Sep 15, 2017 at 6:11 PM, Willy-Bas Loos wrote: > > > On Fri, Sep 15, 2017 at 4:19 PM, Surinder Kumar < > surinder.ku...@enterprised

Re: v2.0 RC2 test builds

​Hi​ On Tue, Sep 19, 2017 at 4:29 PM, Dave Page wrote: > Is this accurate? > > https://www.pgadmin.org/faq/#9 > ​Yes​ > > > On Tue, Sep 19, 2017 at 10:58 AM, Dave Page wrote: > >> >> >> On Tue, Sep 19, 2017 at 10:21 AM, Surinder Kumar < >>

Re: v2.0 RC2 test builds

e "pgAdmin4 is damaged and can't be opened. You should eject the disk image" doesn't gives the clue to user to tick the settings "Allow apps downloaded from: anywhere". Can this message be changed or it is system defined? > In later releases of macOS? > >

Re: v2.0 RC2 test builds

p on MAC > 10.10 fresh VM. > > Note: pgAdmin4 will not work on MAC 10.9 and we have already dropped this > support. > > Can you please share the exact steps so it could reproduce on my fresh VM? > > Kind Regards, > > > On Tue, Sep 19, 2017 at 10:45 AM, Surinder Kumar &l

Re: v2.0 RC2 test builds

Hi Today I downloaded the pgAdmin4 build(pgadmin4-2.0-rc2.dmg ) for Mac but it is failed to open. When I double click on pgAdmin4 icon to open pgAdmin4, I got an error, please refer the screenshot attached. *OS details:* Mac OS X

Re: [pgAdmin4][Patch]: Properly handle builtins.SERVER_MODE variable when SERVER_MODE is not set

ks.​ > > On Mon, Sep 18, 2017 at 6:46 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi >> >> While configuring pgAdmin4 with Apache mod_wsgi, it fails to run apache >> server due to python error. >> >> [mod_wsgi (pid=12

[pgAdmin4][Patch]: Properly handle builtins.SERVER_MODE variable when SERVER_MODE is not set

Hi While configuring pgAdmin4 with Apache mod_wsgi, it fails to run apache server due to python error. [mod_wsgi (pid=12596): Target WSGI script '/opt/pgadmin4_2/virtualenv/lib/python2.7/site-packages/pgadmin4/pgAdmin4.wsgi' cannot be loaded as Python module. mod_wsgi (pid=12596): Exception occur

[pgAdmin4][Patch]: Use standalone modules prop-types as React.PropTypes has moved into a different package since React v15.5

Hi While looking into a React bug, I tried running pgAdmin4 code with Reactv15.5 or with Reactv16-RC-3, the code fails to run. Because React's PropTypes is no more part of React Module. Reference link . Pl

Re: v2.0-rc1 not starting, runtime not building

Hi Willy, >From the logs you sent, It seems there is some issue in Qt setup. Here is the step by step instructions I had documented to setup pgAdmin4 in desktop mode on Ubuntu. You also need to setup virtual environment as well

Re: [pgAdmin4][Patch]: Run MakeFile to generate builds in production mode

Hi Dave, If we set 'NODE_ENV' to 'production' variable in definePlugin, the React will always build in production mode. Please find an attached patch. Thanks, Surinder On Wed, Sep 13, 2017 at 4:36 PM, Dave Page wrote: > > > On Wed, Sep 13, 2017 at 10:34 AM, S

Re: [pgAdmin4][Patch]: Run MakeFile to generate builds in production mode

On Wed, Sep 13, 2017 at 2:52 PM, Dave Page wrote: > > > On Wed, Sep 13, 2017 at 10:06 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> >> ​ >> On Wed, Sep 13, 2017 at 2:18 PM, Dave Page wrote: >> >>> Thanks, committed

Re: [pgAdmin4][Patch]: Run MakeFile to generate builds in production mode

V': JSON.stringify(envType), ​ // In dev mode envType is `development`​ ​ ​ }, }); ​ > On Tue, Sep 12, 2017 at 11:57 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi Dave, >> >> I had discussed this with Ashesh and according to him, r

Re: Fonts for pgAdmin

Sure. I will send a patch. On Tue, Sep 12, 2017 at 8:21 PM, Dave Page wrote: > Thanks. Whoever picks up this task will need to include that info in the > libraries.txt file so we know exactly what 3rd party stuff is in the tree. > > > On Tue, Sep 12, 2017 at 10:50 AM, Shirley Wang wrote: > >> T

Re: [pgAdmin4][Patch]: Run MakeFile to generate builds in production mode

required? > > On Tue, Sep 12, 2017 at 6:28 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi >> >> As per the review comment given by Ashesh: >> >> 1) The test cases with target `check:` must run in `prod` mode by default. >

Re: [pgAdmin4][Patch]: Run MakeFile to generate builds in production mode

, Surinder On Tue, Sep 12, 2017 at 10:28 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Dave, > > I have added a new target to run build in 'dev' mode. By default, it will > run in production mode. > > By dev mode it means, run `yarn run bundle:

Re: [pgAdmin4][Patch]: Run MakeFile to generate builds in production mode

UK:http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On 8 Sep 2017, at 05:34, Surinder Kumar > wrote: > > Hi > > On Thu, Sep 7, 2017 at 8:48 PM, Dave Page wrote: > >> Hi >> >> On Thu, Sep 7, 2017 at 7:28 AM, Surinder Kumar < >>

Re: pgAdmin 4 v2.0-rc1 builds

On Mon, Sep 11, 2017 at 6:45 PM, Dave Page wrote: > > > On Mon, Sep 11, 2017 at 2:12 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi >> >> On Mon, Sep 11, 2017 at 6:07 PM, Dave Page wrote: >> >>> >>> >&g

Re: pgAdmin 4 v2.0-rc1 builds

Hi On Mon, Sep 11, 2017 at 6:07 PM, Dave Page wrote: > > > On Mon, Sep 11, 2017 at 1:18 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi, >> >> On Mon, Sep 11, 2017 at 5:40 PM, Anthony DeBarros >> wrote: >> >>>

Re: pgAdmin 4 v2.0-rc1 builds

Hi, On Mon, Sep 11, 2017 at 5:40 PM, Anthony DeBarros wrote: > Howdy, > > Nice work! Don’t see any show-stoppers, but I’ll throw three comments at > you all. > > 1. New tree icons look great. > 2. A few weeks back, there was a test release with a new font for the > query tool. Got used to it and

Re: [pgAdmin4][Patch]: Run MakeFile to generate builds in production mode

Hi On Thu, Sep 7, 2017 at 8:48 PM, Dave Page wrote: > Hi > > On Thu, Sep 7, 2017 at 7:28 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi, >> >> When we run Webpack in production mode, it performs optimization on code >> while

[pgAdmin4][Patch]: Run MakeFile to generate builds in production mode

Hi, When we run Webpack in production mode, it performs optimization on code while in development we don't optimize generated JS and CSS bundles as dev mode is for developer use. So we should run Webpack bundle in production mode when we are generating bundles for release mode. *In the second pa

Re: Error with webpack

; ​It seems you didn't run `$ yarn install​` > Commit: > commit c4393a7795eef18b311724f45b6c9c0dae01926d (HEAD -> master, > origin/master, origin/HEAD) > Author: Surinder Kumar > Date: Thu Aug 31 14:50:22 2017 +0100 >

Re: [pgAdmin4][Patch]: RM_2596 - Query tool not working in Desktop Runtime on Mac OS X

e in React <https://github.com/facebook/react/issues/10582> Thoughts? Thanks, Surinder On Thu, Aug 31, 2017 at 2:29 PM, Ashesh Vashi wrote: > On Tue, Aug 29, 2017 at 5:55 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi Ashesh, >> >>

[pgAdmin4][Patch]: RM_2637 - Copy functionality in Query Tool doesn't work after copying from Data Output

Hi While working on webpacking pgAdmin4, I had removed `document.removeEventListener(...)` temporarily as it was not working in `strict` mode, giving type error and I forgot to include its fix, because of this copy/paste functionality didn't work properly which is now taken care in this patch. P

Re: [pgAdmin4][Patch]: RM_2596 - Query tool not working in Desktop Runtime on Mac OS X

Hi Ashesh, Can you please review this patch please? Thanks, Surinder On Wed, Aug 16, 2017 at 3:43 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > Updated patch contains changes: > >- Enable definePlugin for development environment

Re: [pgAdmin4][Patch]: Ensure any changes to the config database are backward compatible

Created an RM <https://redmine.postgresql.org/issues/2664> to track this issue. On Fri, Aug 25, 2017 at 7:19 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > ​Hi,​ > > We will use config variable `SCHEMA_VERSION` to keep track of SQLite > database change

[pgAdmin4][Patch]: Ensure any changes to the config database are backward compatible

​Hi,​ We will use config variable `SCHEMA_VERSION` to keep track of SQLite database changes. Whenever there is any change is performed in the database, the count of schema version will be incremented by 1 and the same will be updated in SQLite table `version`. So, these changes make sure the data

Re: Next release

t; >> >> -- >> *Harshal Dhumal* >> *Sr. Software Engineer* >> >> EnterpriseDB India: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Fri, Aug 25, 2017 at 1:48 PM, Dave Page wrote: >> >>> >>> >>

Re: Next release

​Hi​ On Fri, Aug 25, 2017 at 12:21 PM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > On Fri, Aug 25, 2017 at 12:16 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi >> On Fri, Aug 25, 2017 at 1:03 AM, Dave Page wrote: >> >

Re: Next release

India: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Thu, Aug 24, 2017 at 9:44 PM, Dave Page wrote: >> >>> >>> >>> On Thu, Aug 24, 2017 at 10:36 AM, Surinder Kumar < >>> surinder.ku...@enterprisedb.com> wro

Re: Next release

Hi Dave, On Thu, Aug 24, 2017 at 2:28 PM, Dave Page wrote: > Anyone object to doing a release on 14th September, wrapping the code on > Monday 11th? This seems like the best option for our QA folks who will be > off for EID somewhen in the two weeks before. > > Assuming not, should this be 1.7 o

Re: [pgAdmin4][Patch]: RM_ 2658 - Improve help message for "binary paths" entered in Preferences

Hi Dave, On Tue, Aug 22, 2017 at 7:22 PM, Murtuza Zabuawala wrote: > ​​ > https://redmine.postgresql.org/issues/2008 > ​ > > On Tue, Aug 22, 2017 at 7:14 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> On Tue, Aug 22, 2017 at 6:07 PM, Dave P

Re: [Patch][pgAdmin4][pgAgent]: RM_2656 - Unable to select start and end time for scheduler from calendar

easily select the date time and other options as well. Thanks, Surinder On Wed, Aug 23, 2017 at 10:08 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > *Issue:* > > When a user tries to select start and end time using the calendar, the > calendar gets

[Patch][pgAdmin4][pgAgent]: RM_2656 - Unable to select start and end time for scheduler from calendar

Hi *Issue:* When a user tries to select start and end time using the calendar, the calendar gets hidden and inaccessible to the user. *Solution:* ​ Set `Backform.DatetimepickerControl` option `widget positioning > vertical` to `bottom` which ensures Datepicker widget expands to bottom whenever i

Re: [pgAdmin4][Patch]: RM_ 2658 - Improve help message for "binary paths" entered in Preferences

On Tue, Aug 22, 2017 at 6:07 PM, Dave Page wrote: > > > On Tue, Aug 22, 2017 at 1:30 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi >> >> *Issue:* >> >> The user seems to enter sometimes paths with quotes and some

[pgAdmin4][Patch]: RM_ 2658 - Improve help message for "binary paths" entered in Preferences

Hi *Issue:* The user seems to enter sometimes paths with quotes and sometimes add spaces which lead to failure of Backup, Restore or Maintenance utility. *Changes:* - Added a note in help string `Note: Don't add quote(s) or space(s) before or after the path.` - Remove whitespace before/after

[pgAdmin4] [pgAgent] [Patch]: RM_ 2657 - Syntax error while saving changes when start/end time is changed from scheduler

Hi *Issues fixed:* - Syntax error while saving changes when start/end time is updating in Edit mode. - The data type of `jscstart` should be `timestamptz` not `text`. Please find attached patch and review. Thanks, Surinder RM_2657.patch Description: Binary data

Re: pgAdmin4 - Tree view icons for final reveiw

Hi Chethana, The icons dimensions seem to vary in attached SVG. I have attached screenshot. Ideally, the icon(s) must fit(take full width/height) in the dimensions either it is 16x16 or 14x14. because we will not adjust the pixels for each icon. Can you please tell what are the dimensions for an

[pgAdmin4][Patch]: RM_ 2654 - Unable to set start and end time while creating pgAgent Job

Hi, The bootstrap-datetimepicker library being used was an older version which had this issue. So updated the bootstrap-datetimepicker library to the latest one and this issue is fixed in n

[pgAdmin4][Patch]: RM_ 2582 - Backup : Fix compression value

Hi *Issue:* In Backup, compression field can only accept values between 0 to 9. But if the field is clicked, an empty value is set into the model, So, added a check to remove the model attribute if the field is an empty string before data is sent to the server. Please find attached patch. Thanks

Re: [pgAdmin4][Patch]: RM_2596 - Query tool not working in Desktop Runtime on Mac OS X

!== 'production') { // Write development environment specific code } else { // Write production only code. } Please review this patch and let me know for changes. Thanks, Surinder ​ On Tue, Aug 1, 2017 at 11:32 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Ashesh

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

;> On Thu, Aug 10, 2017 at 4:03 PM, Violet Cheng wrote: >>> >>>> Hi Surinder! >>>> >>>> Are you referring to the green message popup? If so, it also appears to >>>> be happening on master. We'll log a bug in our backlog and

[pgAdmin4][Patch]: RM_2646 - Spinner icon not found error when a server node is connected

Hi Since Acitree is removed from vendor directory, but when a server is connected, the load-node.gif file is still referencing tovendor directory instead of referencing to static/js/generated/load-node.gif. Fixed the reference path, now it points to static/js/generated/laod-node.gif . Please fin

Re: [pgadmin4][patch] Fix the style of the alert when connecting/disconnecting from a server

Hi I reviewed this patch and it looks good to me. Thanks, Surinder On Fri, Aug 11, 2017 at 9:13 AM, Sarah McAlear wrote: > Hi Hackers! > > This patch applies to RM 2644 . > It fixes the styling of the checkmark area. > > Thanks! > Sarah > > >

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Hi Sarah, We noticed that due to this patch, the alert style of "Database connected" message is changed. Can you please look into this? Thanks, Surinder On Wed, Aug 9, 2017 at 4:43 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > ​Hi, > > ​The updat

[pgAdmin4][Patch]: Add command under scripts to run webpack bundle in watch mode

/watch/#components/sidebar/sidebar.jsx) Please review the patch Thanks, Surinder Kumar Add_watch_mode_in_scripts.patch Description: Binary data

Re: Unified server/desktop config

Hi This patch includes the fix where this patch breaks when feature tests are run. Set builtins.SERVER_MODE if it is present in globals()['SERVER_MODE'] else set to None. Please find updated patch. Thanks, Surinder ​ On Wed, Aug 9, 2017 at 11:57 AM, Surinder Kumar <

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

see on Master with or >> without the patch applied. I tried adjusting the preferences. I did update >> the dashboard.js to instantiate a new object, great idea! >> >> Thanks, >> Sarah >> >> >> >> On Wed, Aug 9, 2017 at 1:42 PM, Surinder Kumar &

Re: Unified server/desktop config

> > On 9 Aug 2017, at 05:53, Surinder Kumar > wrote: > > Hi, > > I noticed that test cases don’t run and I got an error: > > (pgAdmin_27)Laptop195:regression surinder$ python runtests.py --pkg > feature_tests > > Traceback (most recent call last): > File "r

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

raphs for database level will fail and there is no response returned from server. It might be not reproducible to you If you set the refresh rate to higher value (i.e. Preferences > Graphs) in preferences. Just set refresh rate to 1 for all dashboard graphs and repeat the steps. > > > T

Re: Unified server/desktop config

​ On Tue, Aug 8, 2017 at 4:03 PM, Dave Page wrote: > > > On Tue, Aug 8, 2017 at 11:27 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> On Tue, Aug 8, 2017 at 1:47 PM, Dave Page wrote: >> >> >>> >>> On Tue, Aug 8, 2017

Re: Unified server/desktop config

On Tue, Aug 8, 2017 at 1:47 PM, Dave Page wrote: > > On Tue, Aug 8, 2017 at 7:18 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi >> >> On Ubuntu-14.04, I got error Application Server couldn't be contacted: >> >> *

Re: [pgAdmin4][PATCH] To fix the add New Server through Quick links on Dashboard

Hi Murtuza, As type server-group is renamed to server_group, I can see there are other occurrences of string server-group which needs to be replaced when I perform search in pgAdmin4. Can you please take care of those occurrences? Thanks, Surinder On Tue, Aug 8, 2017 at 12:02 PM, Murtuza Zabuaw

Re: Unified server/desktop config

ee any functionality break. It works!! I liked the approach to set SEVER_MODE in runtime using built-ins. Thanks, Surinder ​ On Mon, Aug 7, 2017 at 7:01 PM, Dave Page wrote: > > > On Mon, Aug 7, 2017 at 1:43 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > &

Re: Fix key error

Hi, On Tue, Aug 8, 2017 at 12:23 AM, Dave Cramer wrote: I don't think this line in web/pgadmin/browser/server_groups/servers/types.py > does what it should. > > default_path = config.DEFAULT_BINARY_PATHS[st.stype] or "" > > will ever succeed if the key does not exist > > Attached patch should wo

Re: Unified server/desktop config

h other test cases. Thanks, Surinder ​ On Mon, Aug 7, 2017 at 4:33 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > On Mon, Aug 7, 2017 at 4:11 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Mon, Aug 7, 2017 at 3:59 PM, Dave

Re: Unified server/desktop config

On Mon, Aug 7, 2017 at 4:11 PM, Ashesh Vashi wrote: > On Mon, Aug 7, 2017 at 3:59 PM, Dave Page wrote: > >> Anyone? >> > Surinder - please give this one priority. > Sure ​.​ > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company >

[pgAdmin4][Patch]: RM_ 2620 - Getting error "Violates check constraint" while creating pgAgent job

Hi It gives error because database value is passed in query generated when jobstep > kind == 'batch'. the database value must be ‘’, if jobstep > kind == 'batch' as per check constraint: "pga_jobstep_check1" CHECK (jstdbname <> ''::name AND jstkind = 's'::bpchar OR jstdbname = ''::name AND (jstki

[Patch][pgAdmin4]: RM_2617 - pgAgent module is not loading after webpacking

Hi, Added an entry for pgAgent JS module to imports-loader to fix the issue. Please find attached patch and let me know for review comments. Thanks, Surinder RM_2617.patch Description: Binary data

Re: [pgAdmin4][Patch]: RM_2596 - Query tool not working in Desktop Runtime on Mac OS X

f needed, i will create. ​Reference to webpack definePlugin: https://webpack.js.org/guides/production/#node-environment-variable​ Please find updated patch with fixed review comments and review. Thanks, Surinder On Mon, Jul 31, 2017 at 3:31 PM, Ashesh Vashi wrote: > On Fri, Jul 28, 2017 at 12:4

[pgAdmin4][Patch]: RM_2596 - Query tool not working in Desktop Runtime on Mac OS X

Hi, I inspect the react code and in call stacks, found `process.env.NODE_ENV` is undefined due to which 'SyntheticEvent.call' is not callable. So, to fix this, i add 'definePlugin' to plugins for `dev` environment in `webpack.config.js`. Initially it was added only for `production` environment. b

Re: [pgAdmin4]: Webpacking of static JS/CSS

gt;> > Also - 'module_paths.json' is auto generated, please don't include that in > the patch. > > -- Thanks, Ashesh > >> >> >> -- >> >> Thanks & Regards, >> >> Ashesh Vashi >> EnterpriseDB INDIA: Enterprise Postgr

[pgAdmin4][Patch]: Improvise the treeview element selection

Hi All, Changes: 1. Highlight the full selected tree item instead of highlighting only label. 2. Set selected item background color to dark blue that is more visible to eyes.[same as in pgAdmin3] Please find attached patch and review. Thanks, Surinder change_acitree_style.patch Description: B

[pgAdmin4][patch][RM#2593]: Query Tool/ Debugger won't load with Qt-5.1 with webkit

Hi When an instance of query tool and debugger is opened, it fails to load and gives following error in console: `Promise is undefined.` The reason is: These instances are loaded in an iframe and their bundles don't include `babel-polyfill` library. Babel-polyfill must be loaded first. Please fi

Re: [pgAdmin4][Patch]: To fix database disconnect option

Hi As discussed the disconnect option is not working due to javascript error: "obj is undefined" and which is after web packing. so in some files global variables needs to convert into local var. We need to run eslint on each file to find out such issues and fix all at once. So i am writing a new

[pgAdmin4][Patch]: Using editorconfig to maintain consistent coding styles between different IDE's

Hi All, In pgAdmin4 codebase, the coding styles at many places is inconsistent, in some files standard coding conventions are followed and in some not. It is difficult to take care of 'tabs', 'spaces', 'trailing white-spaces', 'max_line_length' while development. So adding .editorconfig to pgAdm

Re: [pgAdmin4][Patch]: Stop Flask from initialising service twice in Debug mode

Hi In this patch, i have added reference to the implementation. Please find updated patch and review. Thanks, Surinder On Fri, Jul 21, 2017 at 12:32 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > When pgAdmin4 runs in DEBUG mode, Flask initialise service

[pgAdmin4][Patch]: Stop Flask from initialising service twice in Debug mode

Hi When pgAdmin4 runs in DEBUG mode, Flask initialise service twice, while in non-DEBUG mode, once. It is pain while development because `yarn run bundle` also runs twice. It is because the parameter `use_reloader` = True in Debug Mode. If `os.environ` variable `WERKZEUG_RUN_MAIN` is set to None

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hi Murtuza, Can the code related to Menu KeyEvents be moved out into a separate file say 'menu_actions.js' if feasible ? As the more functionality will be added to sqleditor, codemirror and its file menu in future, the codebase will eventually increase. It will ease writing jasmine test cases as

Re: [pgAdmin4]: Webpacking of static JS/CSS

Hi Dave, Can you please review this patch please? I guess it was missed as i send 2 patches back to back in same email chain. Please find inline detailed description of issue. On Thu, Jul 20, 2017 at 12:37 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > T

Re: [pgAdmin4]: Webpacking of static JS/CSS

Hi *Changes:* Add proper comments in webpack configuration files. Rename lib_css to style.css Please find attached patch and review Thanks, Surinder On Thu, Jul 20, 2017 at 12:37 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > The loading icon i

Re: [pgAdmin4]: Webpacking of static JS/CSS

Hi The loading icon image is used in FileManager and it is still referenced from vendor `aciTree`(which is removed) so it gives 404 not found when FileManager is opened from Query tool/Backup utility. Please find attached patch and review. Thanks, Surinder Kumar

Re: [pgAdmin4]: Webpacking of static JS/CSS

Hi, PFA patch for few code review comments given by Ashesh. Thanks, Surinder On Wed, Jul 19, 2017 at 4:36 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > On Wed, Jul 19, 2017 at 4:27 PM, Dave Page wrote: > >> That was a fun one to spot I'm sure! &g

Re: [pgAdmin4]: Webpacking of static JS/CSS

:) >>> >>> [image: Inline image 1] >>> >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> On Tue, Jul 18, 2017 at

Re: [pgAdmin4]: Webpacking of static JS/CSS

hanks, applied. >> >> On Tue, Jul 18, 2017 at 4:12 PM, Surinder Kumar < >> surinder.ku...@enterprisedb.com> wrote: >> >>> Hi >>> >>> 1. As Slickgrid has dependency of `jQuery-ui`, it was missed. now added. >>> 2. Column sorting for c

Re: Build failed in Jenkins: pgadmin4-master-python27-feature #8

Yes Dave. I am looking. On Wed, Jul 19, 2017 at 1:44 PM, Dave Page wrote: > Surinder; are you looking at this? > > On Tue, Jul 18, 2017 at 5:33 PM, Harshal Dhumal > wrote: > >> >> >> On Tue, Jul 18, 2017 at 9:33 PM, pgAdmin 4 Jenkins >> wrote: >> >>> See

Re: [pgAdmin4]: Webpacking of static JS/CSS

>> Surinder, great work... > > >> On Mon, Jul 17, 2017 at 5:57 PM, Surinder Kumar < >> surinder.ku...@enterprisedb.com> wrote: >> >>> Hi >>> >>> Now all test cases are executing. >>> Please find updated patch. >>> &g

Re: [pgAdmin4]: Webpacking of static JS/CSS

f 216 (skipped 212) SUCCESS > (0.085 secs / 0.046 secs) > > Thanks! > > On Mon, Jul 17, 2017 at 12:07 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> ​Hi Dave, >> >> I didn't removed the vendor modules when i ran regression test c

Re: [pgAdmin4]: Webpacking of static JS/CSS

Hi I'm currently working on first TODO: "Automatically handle static and template JS files" As discussed with Ashesh, currently the paths to module id are written manually in webpack.config.js, instead the path defined in moudle's `def get_own_javascript()` should be used. So, we will be genera

Re: [pgAdmin4]: Webpacking of static JS/CSS

On Mon, Jul 17, 2017 at 2:15 PM, Dave Page wrote: > Hi > > On Wed, Jul 12, 2017 at 4:04 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi >> >> While this patch is in review, i have not attached patch for "unvendored >> l

Re: [pgAdmin4]: Webpacking of static JS/CSS

Surinder, > > Sorry I'm missing the email can you tell me the name please. > > -- Rob > > On Tue, Jul 11, 2017 at 12:51 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> On Tue, Jul 11, 2017 at 10:18 PM, Robert Eckhardt >> wrote: >> >

Re: [pgAdmin4]: Webpacking of static JS/CSS

es fix related to IE.​ > > -- Rob > > > On Jul 11, 2017 11:37 AM, "Dave Page" wrote: > >> Pivotal team; you guys are far more familiar with webpack etc. than we >> are; could you review please? >> >> Thanks! >> >> On Tue, Jul 11, 2017

Re: [pgAdmin4]: Webpacking of static JS/CSS

Hi I found this patch won't work on IE, so i have fixed it and will send updated patch. On Tue, Jul 11, 2017 at 1:25 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > > On Tue, Jul 11, 2017 at 1:22 PM, Dave Page wrote: > >> When you say "un-vendoris

Re: [pgAdmin4]: Webpacking of static JS/CSS

On Tue, Jul 11, 2017 at 1:22 PM, Dave Page wrote: > When you say "un-vendorising", do you mean removing them from the vendor > directory and adding them to packages.json so they're pulled in via > npm/yarn? (if so, good :-) ) > ​Yes.​ > > On Tue, Jul 11

Object > delete/drop and properties menu icons misaligned

Hi Object > delete/drop & properties icons are now misaligned. This is regression of commit d56f1d847c946f43bebbfbdefb929870f0050694 I found the lack of information why these changes were n

Re: [pgAdmin4]: Webpacking of static JS/CSS

PM, Dave Page wrote: > Awesome work. Do you have an ETA for a feature complete test patch? > > On Fri, Jun 30, 2017 at 11:41 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi >> >> So far, I have been able to generate bundled >

Re: [pgAdmin4]: Webpacking of static JS/CSS

4. supported_servers.js 5. current_user.js 6. gettext.js 7. translations.js All other JS files will go into bundled JS. Currently replacing '{{ url_for }}' in dashboard JS with client side 'url_for' and load with bundled JS. Thanks, Surinder On Fri, Jun 30, 2017 at 3:34 PM, Surinder K

Re: [pgAdmin4]: Webpacking of static JS/CSS

Hi On Fri, Jun 30, 2017 at 2:29 AM, George Gelashvili wrote: > Hey Surinder, > > > ​1. ​ >> Tools >> ​(tools.js)​ - It will contain all JS modules under tools directory >> >> >> ​2. ​ >> Browser >> ​(browser.js)​ - It will contain all JS modules under browser directory >> > > By under, do you m

[pgAdmin4]: Webpacking of static JS/CSS

Hi All, I and Ashesh come up with following approach; *Divide the JS modules in following components:* ​1. ​ Tools ​(tools.js)​ - It will contain all JS modules under tools directory ​2. ​ Browser ​(browser.js)​ - It will contain all JS modules under browser directory ​3. ​ grid.js - It will

Re: [pgAdmin4][Patch]: Using client-side 'url_for' implementation in the datagrid module

ks, > > > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Mon, Jun 26, 2017 at 5:13 PM, Dave Page wrote: > >> Thanks, patch applied. >> >> On Mon, Jun 26,

Re: [pgadmin-hackers][patch] History Detail Pane

Hi On Fri, Jun 23, 2017 at 11:39 PM, George Gelashvili wrote: > On Fri, Jun 23, 2017 at 11:24 AM, Surinder Kumar sedb.com> wrote: > >> Hi >> >> Review comments: >> >> ​1. ​ >> Can we set "message"(in message detail) style property scroll t

[pgAdmin4][Patch]: Using client-side 'url_for' implementation in Sqleditor module

Hi Changes: 1. Replace Jinja {{ url_for }} with js 'url_for' 2. While minifying JS using webpack, I got couple of errors(variables undefined) in browser for generated sqleditor.js, so declared those variables before using them. Please find attached patch. Thanks, Suri

[pgAdmin4][Patch]: Using client-side 'url_for' implementation in the datagrid module

Hi Changes: 1. Replace Jinja {{ url_for }} with js 'url_for' 2. While minifying JS using webpack, the code to open QueryToolPanel and DatagridPanel wasn't working. This is fixed. Please find attached patch. Thanks, Surinder Kumar url_for_datagrid.patch Description: Binary data

  1   2   >