RT #41858, reasonable set of rules for splint (was: Re: Parrot Bug Summary)

2007-04-16 Thread Mark Glines
On 16 Apr 2007 13:00:27 - Parrot Bug Summary <[EMAIL PROTECTED]> wrote: > 41858 [CAGE] Make a reasonable set of rules for splint Hi, Random cage cleaner here. At Andy Lester's suggestion, I've begun working on this splint stuff. So everything below is all his fault. :) I found that "make s

lint/splint Makefile stuff

2007-04-16 Thread Mark Glines
Hi, [08:07] <@particle> hrmm i think i have splint on my laptop [08:08] <@particle> so i can probably test it on win32/msvc [09:10] <@particle> the splint target uses sed? oh, we've got some work do do [09:14] < Infinoid> I've been using a little perlscript to remove source filenames from the list

Re: [perl #42597] [CAGE] Add Tests for C++ and C Style

2007-04-17 Thread Mark Glines
On Tue, 17 Apr 2007 18:53:32 -0700 chromatic (via RT) <[EMAIL PROTECTED]> wrote: > In particular, we need to detect: > > - variable declarations with name 'class' > - variable declarations with the name 'namespace' Hi, After r18274 was checked in, splint's warning count for this dro

Re: [perl #42602] [PATCH] Cleanup of additional C++ keywords

2007-04-18 Thread Mark Glines
et/Display.html?id=42602 > > > > Thanks to Mark Glines email, the following appears to be the > remaining C++ keywords hanging about. Nice :) Your patch reduces the warning count further, from 35 to 9. Here's what I am getting currently: lib/Parrot/Pmc2c/PCCMETHOD.pm:402:10: Na

Re: I Don't Understand The Context Allocation/Destruction Code

2007-04-22 Thread Mark Glines
On Sat, 21 Apr 2007 18:24:18 -0700 chromatic <[EMAIL PROTECTED]> wrote: > Then it calculates a slot value: > > const int slot = (reg_alloc + 7) >> 3; > reg_alloc = slot << 3; > > This is where I start not to understand. Why reg_alloc + 7? Why > shift left and right by 3? To me it looks

Re: I Don't Understand The Context Allocation/Destruction Code

2007-04-22 Thread Mark Glines
On Sun, 22 Apr 2007 02:31:26 -0700 Mark Glines <[EMAIL PROTECTED]> wrote: > On Sat, 21 Apr 2007 18:24:18 -0700 > chromatic <[EMAIL PROTECTED]> wrote: > > Then it calculates a slot value: > > > > const int slot = (reg_alloc + 7) >> 3; > >

Re: [perl #41168] graceful "no compiler" error message?

2007-04-27 Thread Mark Glines
On Fri, 27 Apr 2007 19:57:47 -0700 "James Keenan via RT" <[EMAIL PROTECTED]> wrote: > And (I should have asked this earlier) in what sense was the compiler > not yet installed correctly? Was it, e.g., a standard Win32 box with > no compiler at all? In my case, the compiler had not yet been added

Re: [perl #42533] [TODO] do not check PIR coda for languages/dotnet/src/builtins.pir

2007-04-28 Thread Mark Glines
On Sun, 15 Apr 2007 05:49:06 -0700 Bernhard Schmalhofer (via RT) <[EMAIL PROTECTED]> wrote: > languages/dotnet/src/builtins.pir is a generated file, so > editor hints are not very useful there. > > So t/codingstd/pir_code_coda.t should not check builtins.pir. Here's a patch with 2 parts: 1. Ma

Re: [perl #42774] [PATCH] Configure.pl --gc=libc doesn't compile

2007-05-01 Thread Mark Glines
On Fri, 27 Apr 2007 11:19:59 -0700 Andy Dougherty (via RT) <[EMAIL PROTECTED]> wrote: > "src/gc/dod.c", line 462: undefined symbol: > PObj_bufstart_external_FLAG I hunted for this a bit lastnight, so I'm posting my progress. The source lines in question are: 461 /* the real external flag

Re: [perl #42883] [PATCH] Fix up headerfile guards

2007-05-06 Thread Mark Glines
On Sat, 05 May 2007 07:58:45 -0700 "Bernhard Schmalhofer via RT" <[EMAIL PROTECTED]> wrote: > > * Fix up the indentation problems caused by the above bullet point. > > (TODO: why does t/codingstd/c_indent.t require indentation for #if > > and #ifdef, but not for #ifndef?) > As far as I understand c

svn r18461 indentation problem?

2007-05-08 Thread Mark Glines
Hi Paul! I noticed you reindented the example when checking in the PDD07 change. Sorry to disagree with you, but this seems wrong to me. Elsewhere in PDD07, it says: "neither PARROT_IN_CORE nor the outermost _GUARD #ifdefs cause the level of indenting to increase." So I think the indentation was

Re: [perl #42908] AutoReply: [PATCH] add guard macro to autogenerated file include/parrot/has_header.h

2007-05-08 Thread Mark Glines
Hmm. It seems there's more than one header being missed by t/codingstd/c_header_guards.t. I'm going to try to supplement the $DIST->c_header_files() list with items culled from $DIST->generated_files(), or something, if noone can come up with a better idea. In the meantime, here's an additional

Re: [perl #42903] [PATCH] Add guards to the rest of the headerfiles

2007-05-08 Thread Mark Glines
On Tue, 08 May 2007 10:10:06 -0700 "Paul Cochrane via RT" <[EMAIL PROTECTED]> wrote: > A comment: this patch was in essence three patches (the pod, a test > and a patch of the headers), next time could you separate them into > three patches? The test was itself actually a new file, so it could > h

Re: r18572 - trunk/compilers/imcc

2007-05-17 Thread Mark Glines
On Thu, 17 May 2007 11:13:45 -0700 "jerry gay" <[EMAIL PROTECTED]> wrote: > char *s = s_key; > *s = 0; > however... why is 's' nulled out, directly after it's initialized to > 's_key'? that looks funny. The first line declares a pointer, pointing to s_key. The second lin

Re: Parrot Project Management...

2007-05-21 Thread Mark Glines
On Mon, 21 May 2007 18:51:48 -0400 Will Coleda <[EMAIL PROTECTED]> wrote: > If you notice any missing documentation, please open an RT ticket > with [DOCS] in the subject. ((It won't be processed specially by RT, > but will help me search.)) Ask on the list. Send patches, either to > the parr

Re: POD Coverage (was: Parrot Project Management...)

2007-05-21 Thread Mark Glines
On Mon, 21 May 2007 19:27:26 -0400 James E Keenan <[EMAIL PROTECTED]> wrote: > Mark Glines wrote: > > > > Think its worth adding a > > codingstd test for POD coverage? > > > > > > No. > > Or perhaps: No, not unless you want to start a

Re: [perl #42355] [PATCH] [TODO] use ARG_MAX in pic_callr__() op

2007-05-28 Thread Mark Glines
On Sun, 08 Apr 2007 12:04:37 -0700 [EMAIL PROTECTED] (Paul Cochrane) wrote: > # New Ticket Created by Paul Cochrane > # Please include the string: [perl #42355] > # in the subject line of all future correspondence about this issue. > # http://rt.perl.org/rt3/Ticket/Display.html?id=42355 > > >

Re: [perl #42938] [BUG] allocation failures in res_lea.c

2007-05-31 Thread Mark Glines
On Sat, 12 May 2007 12:05:26 -0700 Allison Randal (via RT) <[EMAIL PROTECTED]> wrote: > On x86 Linux (Ubuntu), this configuration fails 2 tests: > > t/library/string_utils.t0 134294 13.79% 28-29 > t/op/stringu.t 2 512252 8.00% 1 19 > > Both tests are fail

Re: [perl #42938] [BUG] allocation failures in res_lea.c

2007-06-01 Thread Mark Glines
On Thu, 31 May 2007 23:09:54 -0700 Mark Glines <[EMAIL PROTECTED]> wrote: > Might be worth it to prereserve 8 bytes or so, to avoid having to > realloc as often, if this will be called a lot. Currently it just > reallocs the minimum necessary to fit the existing string, the new &g

GC bug on freebsd/x86, triggered by a perl6 test

2007-06-04 Thread Mark Glines
I tried the perl6 testsuite on freebsd at Coke's request, and discovered a test that fails on freebsd but succeeds on linux. The test seems to be a GC-related assertion failure; parrot -G does not crash, parrot without -G does crash. I am running on freebsd 6.2, in a checkout of svn r18803. I di

Re: GC bug on freebsd/x86, triggered by a perl6 test

2007-06-04 Thread Mark Glines
On Mon, 4 Jun 2007 13:07:18 -0700 chromatic <[EMAIL PROTECTED]> wrote: > On Monday 04 June 2007 12:49:45 Mark Glines wrote: > > > (the LD_LIBRARY_PATH bit is required on freebsd so parrot can find > > libparrot.so.) > > The GNU linker supports a flag to mark a relo

Re: [perl #43130] AutoReply: Re: GC bug on freebsd/x86, triggered by a perl6 test

2007-06-04 Thread Mark Glines
On Mon, 04 Jun 2007 13:39:44 -0700 "Parrot via RT" <[EMAIL PROTECTED]> wrote: > Greetings, > > This message has been automatically generated in response to the > creation of a parrotbug regarding: > "Re: GC bug on freebsd/x86, triggered by a perl6 test" This ticket is a duplicate of RT #43

Re: GC bug on freebsd/x86, triggered by a perl6 test

2007-06-04 Thread Mark Glines
On Mon, 04 Jun 2007 21:39:08 +0100 Jonathan Worthington <[EMAIL PROTECTED]> wrote: > > Assertion failed: (s->encoding && s->charset > > && !PObj_on_free_list_TEST(s)), function string_hash, file > > src/string.c, line 2024. Abort trap (core dumped) > > > I'm betting that it's the !PObj_on_free_l

LD_LIBRARY_PATH required on FreeBSD (was: Re: GC bug on freebsd/x86, triggered by a perl6 test)

2007-06-05 Thread Mark Glines
On Tue, 5 Jun 2007 01:13:36 -0500 Joshua Isom <[EMAIL PROTECTED]> wrote: > After a little prodding around, I think the problem is that the > dynops aren't build with the rpath. I don't know how "proper" the > following patch is(i.e. linux doesn't seem to have a problem so > either this is right o

Re: Removing #pragma

2007-06-12 Thread Mark Glines
On Tue, 12 Jun 2007 11:39:35 -0700 Allison Randal <[EMAIL PROTECTED]> wrote: > jerry gay wrote: > > On 6/12/07, Andy Lester <[EMAIL PROTECTED]> wrote: > >> > >> I'm very uncomfortable with removing #pragma once from our header > >> files. It is perfectly valid C89 code, and I think bowing to a >

Re: [perl #43219] segfault in tcl

2007-06-14 Thread Mark Glines
On Thu, 14 Jun 2007 19:10:02 -0700 Will Coleda (via RT) <[EMAIL PROTECTED]> wrote: > # New Ticket Created by Will Coleda > # Please include the string: [perl #43219] > # in the subject line of all future correspondence about this issue. > # http://rt.perl.org/rt3/Ticket/Display.html?id=43219 >

Re: [perl #43241] [PATCH] [CAGE] include/parrot/string.h typedefs STRING and String are redundant

2007-06-19 Thread Mark Glines
On Tue, 19 Jun 2007 00:33:23 -0700 "Paul Cochrane via RT" <[EMAIL PROTECTED]> wrote: > On Mon Jun 18 15:03:31 2007, petdance wrote: > > > > On Jun 18, 2007, at 11:28 AM, Mark Glines (via RT) wrote: > > > > > Here's a patch to consolidate that,

Re: [svn:parrot] r19231 - trunk/languages/perl6/src/pmc

2007-06-21 Thread Mark Glines
On Thu, 21 Jun 2007 17:38:15 -0700 chromatic <[EMAIL PROTECTED]> wrote: > > -return string_from_cstring(INTERP, "Str", 3); > > +return string_from_cstring(INTERP, "Bool", 3); > > return SUPER(); > > } > > That 3 looks like it should be 4. Yep, fixed in r19238

Re: [svn:parrot] r19231 - trunk/languages/perl6/src/pmc

2007-06-22 Thread Mark Glines
On Fri, 22 Jun 2007 10:07:32 +0100 Nicholas Clark <[EMAIL PROTECTED]> wrote: > > We have a lot of string_from_cstring() calls with constant second > > parameters and third parameters of 0 that could use updating. > > There's no sense in calling strlen() all the time. > > I think that you need some

Re: [svn:parrot] r19231 - trunk/languages/perl6/src/pmc

2007-06-22 Thread Mark Glines
On Fri, 22 Jun 2007 11:36:28 -0500 "Patrick R. Michaud" <[EMAIL PROTECTED]> wrote: > > Also, using sizeof() will fix some cases that strlen() doesn't > > handle correctly, specifically, strings containing explicit null > > characters. src/objects.c has a few examples of that. > > string_to_cstring(

Re: [svn:parrot] r19231 - trunk/languages/perl6/src/pmc

2007-06-22 Thread Mark Glines
On Fri, 7 Nov 2008 15:28:40 -0700 chromatic <[EMAIL PROTECTED]> wrote: > On Friday 22 June 2007 02:07:32 Nicholas Clark wrote: > > I think that you need something like this > > > > /* concatenating with "" ensures that only literal strings are > > accepted as argument */ #define STR_WITH_LEN(s) (s

Re: [svn:parrot] r19231 - trunk/languages/perl6/src/pmc

2007-06-22 Thread Mark Glines
On Fri, 22 Jun 2007 10:35:00 -0700 chromatic <[EMAIL PROTECTED]> wrote: > > > If we're passing in a string literal, it seems silly to pass in a > > > length of 0, as we're recalculating a constant on every call. I > > > don't see that this macro fixes that. > > > It uses sizeof, not strlen. So,

Re: [perl #41497] [TODO] config - profiling options are specific to gcc in config/init/defaults.pm

2007-06-24 Thread Mark Glines
On Sun, 24 Jun 2007 21:13:14 -0700 "James Keenan via RT" <[EMAIL PROTECTED]> wrote: > The profiling options code in config/init/defaults.pm reads: > > if ( $conf->options->get('profile') ) { > $conf->data->set( > cc_debug => " -pg ", > ld_debug => " -pg ", >

Re: [perl #43481] t/examples/shootout.t (shootout_16.pir) fails on gentoo/x86

2007-07-02 Thread Mark Glines
On Mon, 02 Jul 2007 16:46:54 -0700 Mark Glines (via RT) <[EMAIL PROTECTED]> wrote: > [EMAIL PROTECTED] ~/parrot $ ./parrot > "/home/paranoid/parrot/t/examples/shootout_16.pir" > [cgt]gggtaaa|tttaccc[acg] 3 a[act]ggtaaa|tttacc[agt]t 9 > ag[act]gtaaa|tttac[agt]ct 8 &g

Re: [perl #43481] t/examples/shootout.t (shootout_16.pir) fails on gentoo/x86

2007-07-03 Thread Mark Glines
On Tue, 3 Jul 2007 12:10:37 -0500 Andy Lester <[EMAIL PROTECTED]> wrote: > > Problem 2, why is this test case passing a NULL pointer all of a > > sudden, exposing Problem #1? Presumably, this used to work. > > That I can't tell. All I'm looking at is the underlying C code, > where it seems to

Re: [perl #43481] t/examples/shootout.t (shootout_16.pir) fails on gentoo/x86

2007-07-03 Thread Mark Glines
On Tue, 03 Jul 2007 09:34:29 -0700 "Andy Lester via RT" <[EMAIL PROTECTED]> wrote: > > Sooo... I'm not sure if the "rep" argument is NULL for the same > > *reason* as the above script (a comment from Coke has made me > > paranoid that a DOD run may be to blame), but should this emit an > > error m

Re: [perl #43481] t/examples/shootout.t (shootout_16.pir) fails on gentoo/x86

2007-07-03 Thread Mark Glines
On Tue, 3 Jul 2007 10:18:59 -0700 Mark Glines <[EMAIL PROTECTED]> wrote: > So, while I agree that the "crashing on NULL rep" bug needs to be > fixed, I've been mostly focusing on staring at regexdna.pir, hoping > to find a fix for the "passing a NULL rep in the

Re: [perl #43481] t/examples/shootout.t (shootout_16.pir) fails on gentoo/x86

2007-07-04 Thread Mark Glines
On Wed, 4 Jul 2007 22:56:48 + [EMAIL PROTECTED] wrote: > > This is on gentoo linux x86. I ran Configure.pl with no arguments. > > Apparently this test passes on chromatic's linux box, and on > > particle's win32 box, but fails on my gentoo box and particle's > > ubuntu box. So its a bit spora

Splint runs!

2007-07-09 Thread Mark Glines
Thanks to Paul Cochrane, I am now able to run splint on the parrot sources. I'm using git-svn to sync his "splint" branch up with the latest changes from trunk, so this is current as of svn r19710. Summary: Error TypeReported Suppressed === ==

Re: Splint runs!

2007-07-09 Thread Mark Glines
On Mon, 09 Jul 2007 20:17:03 -0400 James E Keenan <[EMAIL PROTECTED]> wrote: > Can you give us splint noobs a rundown on how to interpret this data? > Thanks. Click the link ( http://squawk.glines.org/splint2-try3.log ), look for warnings that look interesting, and fix them. :) Mark

Re: [perl #43815] pmc2c generates wrong #line numbers for languages/perl6/src/pmc/perl6str.pmc

2007-07-12 Thread Mark Glines
On Wed, 11 Jul 2007 23:49:34 -0700 Mark Glines (via RT) <[EMAIL PROTECTED]> wrote: > The pmclass statement looks like: > > pmclass Perl6Str > extends String > does string > dynpmc > group perl6_group > hll Perl6 > maps String { > > I

[PATCH] [CLEANUP] Re: [perl #43815] pmc2c generates wrong #line numbers for languages/perl6/src/pmc/perl6str.pmc

2007-07-12 Thread Mark Glines
On Thu, 12 Jul 2007 18:31:43 -0700 Mark Glines <[EMAIL PROTECTED]> wrote: > So here's a patch. It's a bit quick & dirty, but it'll work. A > cleaner solution would probably involve adding a fourth returned > parameter from parse_flags: a line-count. Ends

[PATCH] Re: [perl #43815] pmc2c generates wrong #line numbers for languages/perl6/src/pmc/perl6str.pmc

2007-07-12 Thread Mark Glines
On Thu, 12 Jul 2007 09:26:25 -0700 Mark Glines <[EMAIL PROTECTED]> wrote: > > Interestingly, if I take all of the crud in this pmclass statement > > and stick them all on one line, like this: > > > > pmclass Perl6Str extends String does string dynpmc group perl6_g

Re: Splint upgrade released

2007-07-13 Thread Mark Glines
On Fri, 13 Jul 2007 23:39:06 -0500 Andy Lester <[EMAIL PROTECTED]> wrote: > All you splint users, go get the new download. > > http://splint.org/download.html > > Rock on, splinters! Thanks, Andy! I'm already bugging the Gentoo folks to version-bump their package. There's an ebuild attached to

Re: [perl #43815] pmc2c generates wrong #line numbers for languages/perl6/src/pmc/perl6str.pmc

2007-07-14 Thread Mark Glines
On Thu, 12 Jul 2007 09:26:25 -0700 Mark Glines <[EMAIL PROTECTED]> wrote: > I don't have a fix (yet), but here's a patch to add a couple of tests > for it. One test makes sure it emits the right #line when a complex > pmclass statement is all on one line, and the sec

Re: [perl #43899] [BUG] 'make' broken on Darwin

2007-07-14 Thread Mark Glines
On Sat, 14 Jul 2007 11:54:26 -0700 James Keenan (via RT) <[EMAIL PROTECTED]> wrote: > # New Ticket Created by James Keenan > # Please include the string: [perl #43899] > # in the subject line of all future correspondence about this issue. > # http://rt.perl.org/rt3/Ticket/Display.html?id=43899

Re: Documenting the PARROT_XXX macros

2007-07-15 Thread Mark Glines
On Sun, 15 Jul 2007 23:48:54 -0500 Andy Lester <[EMAIL PROTECTED]> wrote: > I want to document all the PARROT_XXX macros that I've been creating > and applying, but I'm not sure where they'd be best. I don't think > pdd07_codingstd.pod is right, because it's not coding standards > exactly.

Re: [perl #44009] src/dynext.c casting warnings

2007-07-17 Thread Mark Glines
On Tue, 17 Jul 2007 16:32:09 -0700 "jerry gay" <[EMAIL PROTECTED]> wrote: > that's a big, ugly mess of macros. your solution is concise, but void > pointers are dangerous and should be avoided wherever possible. it's > not a coding standard yet, but it will be *soon*. perhaps there's a > solution t

Re: [perl #44041] [CAGE] Verify all functions are used

2007-07-18 Thread Mark Glines
On Wed, 18 Jul 2007 09:58:12 -0700 Andy Lester (via RT) <[EMAIL PROTECTED]> wrote: > Verify that all functions actually get used. We could do this by > either: > > * Creating a tool that verifies that each function is used at least > once > > * Run splint with whatever flags necessary to do gl

[PATCH] [PDD] PDD07: header guard example should use #ifndef

2007-07-30 Thread Mark Glines
Hi, A while back, I submitted some patches to fix up header guards, make their syntax consistent and such. These were applied in r18461, r18464, and others. PDD07 contains an example which is no longer consistent with the current headers. I'm submitting this patch for review. It changes

Re: [perl #43815] pmc2c generates wrong #line numbers for languages/perl6/src/pmc/perl6str.pmc

2007-07-30 Thread Mark Glines
On Wed, 11 Jul 2007 23:49:34 -0700 Mark Glines (via RT) <[EMAIL PROTECTED]> wrote: > perl6str.pmc has an extra-long "pmclass" statement, which > breaks the #line numbering when pmc2c generates the .c file. > > The line numbers are wrong in the generated perl6str.c fi

Re: [perl #42938] [BUG] allocation failures in res_lea.c

2007-07-31 Thread Mark Glines
On Thu, 31 May 2007 23:09:54 -0700 Mark Glines <[EMAIL PROTECTED]> wrote: > The code in utf8_encode_and_advance is beautiful. It basically says, > add a utf8 character to the buffer. Ok, now did we overrun the > buffer? CRASH! So if I add a call to Parrot_reallocate_string if t

Re: [perl #37287] [TODO] pdb - don't die on exceptions

2007-08-03 Thread Mark Glines
> This patch makes parrot stop execution of the vm when running as a > debugger. > > This makes the pdb stop executing and shows the exception message > instead of silently exiting. Hi, pancake! I have tried to update your patch to svn r20469, see attached patch. Unfortunately, it doesn't work a

Re: More on the HLL/Tcl Fix

2007-08-06 Thread Mark Glines
On Sun, 5 Aug 2007 23:44:16 -0700 chromatic <[EMAIL PROTECTED]> wrote: > +enum { > +e_HLL_name, > +e_HLL_lib, > +e_HLL_typemap, > +e_HLL_MAX > +} HLL_enum_t; > + Shouldn't that be a typedef? In other words: typedef enum {...} HLL_enum_t; I think that'll fix Coke's build failur

Re: [perl #44379] config/auto/attributes.pm ought to use its own test_c.in

2007-08-06 Thread Mark Glines
On Mon, 6 Aug 2007 15:20:39 -0700 chromatic <[EMAIL PROTECTED]> wrote: > On Monday 06 August 2007 15:10:30 Andy Lester wrote: > > > On Mon, Aug 06, 2007 at 02:40:06PM -0700, chromatic > > ([EMAIL PROTECTED]) > wrote: > > > > I find these two lines confusing: > > > > > > my %eval = eval cc_r

Re: [perl #44379] config/auto/attributes.pm ought to use its own test_c.in

2007-08-06 Thread Mark Glines
On Mon, 6 Aug 2007 15:20:39 -0700 chromatic <[EMAIL PROTECTED]> wrote: > That's not exactly the same as a stringified hash. I think we can > just remove the cc_run() bits and be fine (at least, it worked for > me). Indeed, with the attached patch I have working attributes again. Mark Index: conf

Re: [perl #43481] t/examples/shootout.t (shootout_16.pir) fails on gentoo/x86

2007-08-09 Thread Mark Glines
On Thu, 9 Aug 2007 22:19:29 -0500 "Patrick R. Michaud" <[EMAIL PROTECTED]> wrote: > On Thu, Aug 09, 2007 at 04:37:30PM -0600, Lloyd Miller wrote: > > >(Like you, I'm also running kubuntu feisty on an x86_64 system, > > >gcc 4.1.2.) > > > > OK, I tried svn r20585 and this fail is gone from make t

Re: [perl #38982] [CAGE] refactor long test files

2007-08-19 Thread Mark Glines
On Sun, 19 Aug 2007 19:19:22 -0500 Andy Lester <[EMAIL PROTECTED]> wrote: > > On Aug 19, 2007, at 7:15 PM, David Romano wrote: > > > The patch splits string.t (originally almost 3000 lines) into > > different > > files, as well as moves some of the tests for sprintf into > > t/op/sprintf_tests

Re: [perl #44769] [BUG] Parrot failing to 'make' on Darwin

2007-08-20 Thread Mark Glines
On Mon, 20 Aug 2007 16:00:28 -0700 chromatic <[EMAIL PROTECTED]> wrote: > On Monday 20 August 2007 05:13:07 James E Keenan wrote: > > > t/src/compiler# > > '/usr/bin/g++-3.3 -L/usr/local/lib  t/src/compiler_2.o > > src/parrot_config.o -o t/src/compiler_2 blib/l

Re: [perl #44783] [PATCH] t/distro/file_metadata.t and git

2007-08-20 Thread Mark Glines
On Sun, 19 Aug 2007 22:22:06 -0700 David Romano (via RT) <[EMAIL PROTECTED]> wrote: > # New Ticket Created by David Romano > # Please include the string: [perl #44783] > # in the subject line of all future correspondence about this issue. > # http://rt.perl.org/rt3/Ticket/Display.html?id=44783

Current win32 linking issues: Summary

2007-08-20 Thread Mark Glines
The parrot needs help, hopefully before tomorrow's release. There are two issues with linking against libparrot.dll on win32: 1. It refuses to export the "_PMCNULL" symbol (the PMCNULL global variable defined at the top of src/pmc.c), and thus, embedders cannot use the PMC_IS_NULL macro. This c

Re: Current win32 linking issues: Summary

2007-08-20 Thread Mark Glines
On Mon, 20 Aug 2007 18:37:05 -0700 Mark Glines <[EMAIL PROTECTED]> wrote: > Jerry added a workaround in r20641, declaring a local variable > PMCNULL within the test code, to get it to pass. Unfortunately, this > workaround causes Darwin to fail with the message "ld: multi

Re: [perl #44809] [PATCH] use Storable instead of Data::Dumper for PMC .dump files

2007-08-21 Thread Mark Glines
On Tue, 21 Aug 2007 09:52:01 -0700 chromatic <[EMAIL PROTECTED]> wrote: > return unless -f $filename; > return retrieve($filename); > > My preference is the latter, for clarity and context reasons. Thanks, you're absolutely right. Here's an updated patch. Mark Index: lib/Parrot/Pmc

Re: Current win32 linking issues: Summary

2007-08-21 Thread Mark Glines
On Tue, 21 Aug 2007 13:08:05 +0200 Ron Blaschke <[EMAIL PROTECTED]> wrote: > > The win32 skippage will need to be removed again, once the PMCNULL > > symbol is exported correctly from libparrot.dll. > > Not adding the skip on the other t/src tests will cause them to > fail. I think it would be b

Re: Current win32 linking issues: Summary

2007-08-22 Thread Mark Glines
On Wed, 22 Aug 2007 11:16:12 +0200 Ron Blaschke <[EMAIL PROTECTED]> wrote: > >> Don't know if its a problem if they fail. I don't have a problem > >> with failures as they tell me there's something that needs > >> attention. > > > True. Well, these issues do need attention, so maybe they *should

[perl #44855] Re: Current win32 linking issues: Summary

2007-08-22 Thread Mark Glines
On Wed, 22 Aug 2007 11:16:12 +0200 Ron Blaschke <[EMAIL PROTECTED]> wrote: > Jerry mentioned yesterday that there shouldn't be any failures for a > release, which makes sense as it would only upset users. Maybe there > should be a ticket for the failures then? I have created ticket #44855 for thi

Re: [perl #44809] [PATCH] use Storable instead of Data::Dumper for PMC .dump files

2007-08-22 Thread Mark Glines
Oops. I replied to this on the RT site, but it looks like I neglected to tell it to copy the list (or you). I'll cutpaste my response below. On Tue, 21 Aug 2007 21:02:39 -0400 James E Keenan <[EMAIL PROTECTED]> wrote: > I do have some qualms. > > (1) I know that there have been issues with inc

Re: [perl #47704] [BUG]Memory leak with STRING's

2007-11-22 Thread Mark Glines
On Thu, 22 Nov 2007 10:35:21 -0800 "Mehmet Yavuz Selim Soyturk" (via RT) <[EMAIL PROTECTED]> wrote: > # New Ticket Created by "Mehmet Yavuz Selim Soyturk" > # Please include the string: [perl #47704] > # in the subject line of all future correspondence about this issue. > # http://rt.perl.org/

Re: [svn:parrot] r29610 - in branches/pdd13pbc: src/pmc t/pmc

2008-07-19 Thread Mark Glines
On Saturday 19 July 2008 11:19:27 chromatic wrote: > Poking at strings directly seems unclean; do we need to add another > function to src/packfile.c to return a packed packfile as a C string, > and then create the string directly here in get_string()? I agree, poking around in STRING internals is

Re: [perl #57188] [PATCH] pbc_to_exe --install

2008-07-22 Thread Mark Glines
On Tuesday 22 July 2008 04:56:53 Reini Urban wrote: > Attached patch adds --install to pbc_to_exe, > adds a basic pod to pbc_to_exe, > and applies --install to perl6. > > link against install_config.o and add installable prefix. > Limitation: With --install the first arg infile must have no > direc

Re: Inter-HLL Mapping Notes

2008-07-22 Thread Mark Glines
On Tuesday 22 July 2008 15:37:33 chromatic wrote: > The wiki page at: > > http://www.perlfoundation.org/parrot/index.cgi?inter_hll_mapping_not >es > > seems to be missing the rationale for *why* it's necessary to map > types between languages? (Also see "If Perl 6 has to care about the > int

Re: [perl #57358] Enable parallel testing

2008-07-28 Thread Mark Glines
On Monday 28 July 2008 09:52:36 Moritz Lenz wrote: > >> t/steps/auto_attributes-01.t (Wstat: 65280 Tests: 9 > >> Failed: 0) Non-zero exit status: 255 > >> Parse errors: Bad plan. You planned 12 tests but ran 9. > >> t/steps/auto_headers-03.t (Wstat: 65280 Tests: 8 >

Re: [perl #57608] [PATCH] add ports/cygwin

2008-08-06 Thread Mark Glines
On Tuesday 05 August 2008 20:57:53 chromatic wrote: > On Tuesday 05 August 2008 01:35:48 Reini Urban wrote: > > Attached patch adds the directory ports/cygwin with > > the most recent cygports file, > > the most recent src patch and the sources for the CYGWIN patches. > > (the contents of parrot-0.

Re: [perl #59880] DOD crash in r31926, t/op/bitwise.t #27 on linux/x86_64

2008-10-14 Thread Mark Glines
On Tuesday 14 October 2008 07:14:51 Mark Glines wrote: > On Monday 13 October 2008 16:15:54 chromatic wrote: > > That's pretty clearly not a PMC. Can you use the breakpoint > > technique to figure out 1) What creates this CPointer PMC and > > In the following dump, the

Re: [perl #59880] DOD crash in r31926, t/op/bitwise.t #27 on linux/x86_64

2008-10-14 Thread Mark Glines
On Monday 13 October 2008 16:15:54 chromatic wrote: > That's pretty clearly not a PMC. Can you use the breakpoint > technique to figure out 1) What creates this CPointer PMC and In the following dump, the offending PMC ix 0x1731de8. The arena's base pointer varies every time, but I seem to be

Re: [perl #59880] DOD crash in r31926, t/op/bitwise.t #27 on linux/x86_64

2008-10-20 Thread Mark Glines
chromatic wrote: > 2) What's setting an invalid pointer-to-a-PMC here? This question is answered at the end of the following dump. (This is one of the things I nopasted during our IRC discussion last week, thanks for your guidance in producing it.) One interesting question: the pointer-to-a-PMC

Re: [perl #60068] [BUG] t/pmc/packfile.t: set_integer_keyed_str test failing on Darwin PPC

2008-11-15 Thread Mark Glines
[oops, forgot to copy the list.] If darwin has gdb, you can do the following to get a backtrace: $ gdb parrot gdb> run t/pmc/packfile_6.pir [segfault should occur here] gdb> bt Mark

Re: [perl #60642] [CAGE] add a codingstd test to ensure TODOed tests have an RT ticket number

2008-11-19 Thread Mark Glines
James Keenan via RT wrote: On Tue Nov 18 10:22:25 2008, [EMAIL PROTECTED] wrote: This will probably be quite challenging. Let's assume that all tests are found in files with names ending in '.t'. Those .t files can be written in any language, which probably have different ways of classifying a

Re: [perl #60642] [CAGE] add a codingstd test to ensure TODOed tests have an RT ticket number

2008-11-20 Thread Mark Glines
James Keenan via RT wrote: On Wed Nov 19 23:13:27 2008, [EMAIL PROTECTED] wrote: James Keenan via RT wrote: On Tue Nov 18 10:22:25 2008, [EMAIL PROTECTED] wrote: This will probably be quite challenging. Let's assume that all tests are found in files with names ending in '.t'. Those .t files

Re: [perl #59680] Build error: tools/build/ops2pm.pl: Could not mkdir /home/moritz/src/parrot/lib/Parrot/OpLib: File exists!

2008-11-25 Thread Mark Glines
Will Coleda wrote: On Tue, Nov 25, 2008 at 2:18 PM, Mark Glines via RT <[EMAIL PROTECTED]> wrote: On Sat Oct 18 12:13:51 2008, [EMAIL PROTECTED] wrote: There's a race condition, if that directory doesn't exist and multiple processes execute that code simultaneously. For

Re: fudging the headerizer

2008-12-27 Thread Mark Glines
Andy Lester wrote: This patch http://www.parrotvm.org/svn/parrot/revision?rev=34423 is not a long-term solution. The headerizer has to get run at will. Infinoid, can you tell me more about those ifdefs so I can make the headerizer happy? Happy to. The functions in question (is_ins_save a

Re: [perl #62010] [PATCH] fix PARROT_EXPORT visibility=default for gcc other than 4.x

2009-01-08 Thread Mark Glines
donald.hun...@gmail.com wrote: I was pretty averse to adding an additional configure step myself. The problem is that warnings.pm checks specifically for supported compiler flags and I didn't want to include other things there. The bug is that gcc.pm is hardcoded for version 4.x rather than che

Re: [perl #62202] Problem with Configure.PL under Windows

2009-01-11 Thread Mark Glines
Alan Rocker (via RT) wrote: auto::gmp - Does your platform support GMP...Can't spawn ".\test_616.exe": Bad file descriptor at lib/Parrot/Configure/Utils.pm line 86. Thanks, this is a known issue with the libgmp.dll built with strawberry perl. (It was built with SSE2 instructions tha

Re: [perl #63626] Re: bouncing parrot...@parrotcode.org

2009-03-04 Thread Mark Glines
Geoffrey Broadwell wrote: > Out of curiosity, why don't we allow emails to create tickets in Trac? There's a plugin to do this, called "email2trac". It's being set up, but doesn't work yet. See TT #49. Mark

Re: [perl #50212] Configure step fails on Windows

2008-01-24 Thread Mark Glines
Hi, Alan! What kind of CPU do you have? If you have an AMD Athlon XP (or something of similar lineage), I think I know what the problem is. On Thu, 24 Jan 2008 12:52:35 -0800 Alan Rocker (via RT) <[EMAIL PROTECTED]> wrote: > Determining if your platform supports GMP...Can't spawn ".\test.exe":

Re: minimal Parrot for small (embedded) system

2008-03-11 Thread Mark Glines
On Tue, 11 Mar 2008 20:02:25 + "Wim Vanderbauwhede" <[EMAIL PROTECTED]> wrote: > I've read "Parrot for small platforms" in pdd01_overview, it says > "For small platforms, any parser, compiler, and optimizer modules are > replaced with a small bytecode loader module which reads in Parrot > byte

Re: [perl #51718] Consolidate test infrastructure in t/codingstd and t/distro

2008-03-14 Thread Mark Glines
On Fri, 14 Mar 2008 16:19:48 -0700 "James Keenan via RT" <[EMAIL PROTECTED]> wrote: > Mark: > > This looks good to me. However, one of the tests being revised is > currently failing, probably for different reasons. See: > http://rt.perl.org/rt3/Ticket/Display.html?id=51750. Thanks for the cod

Re: [perl #51718] Consolidate test infrastructure in t/codingstd and t/distro

2008-03-18 Thread Mark Glines
On Fri, 14 Mar 2008 17:01:39 -0700 Mark Glines <[EMAIL PROTECTED]> wrote: > I'm going to hold off until after Tuesday's release, in any case, just > to make sure I don't break anything else. I committed my previous patch (after some merging) as r26480. But I think t

Re: [perl #51916] Error in tests after build

2008-03-21 Thread Mark Glines
On Fri, 21 Mar 2008 07:16:07 -0400 James E Keenan <[EMAIL PROTECTED]> wrote: > Ted Neward wrote: > > BTW, I didn't want to file a bug, but the Lua compiler in the > > latest bits uses a tool "yapp" that doesn't appear to be a part of > > the bundle--is it supposed to be? > > > > Ted Neward > > Ja

Re: [perl #51976] [PATCH] fixed uninitialized variable warning in dynext.c:Parrot_init_lib()

2008-03-21 Thread Mark Glines
On Fri, 21 Mar 2008 08:21:44 -0700 "Andrew Whitworth" (via RT) <[EMAIL PROTECTED]> wrote: > # New Ticket Created by "Andrew Whitworth" > # Please include the string: [perl #51976] > # in the subject line of all future correspondence about this issue. > # http://rt.perl.org/rt3/Ticket/Display.h

Re: [perl #51980] [PATCH] fixed multiple redefines of snprintf macro

2008-03-21 Thread Mark Glines
On Fri, 21 Mar 2008 09:03:08 -0700 "Andrew Whitworth" (via RT) <[EMAIL PROTECTED]> wrote: > # New Ticket Created by "Andrew Whitworth" > # Please include the string: [perl #51980] > # in the subject line of all future correspondence about this issue. > # http://rt.perl.org/rt3/Ticket/Display.h

Re: [perl #51982] [PATCH] fixed signed/unsigned typecast in string_primitives.c

2008-03-21 Thread Mark Glines
On Fri, 21 Mar 2008 09:06:59 -0700 "Andrew Whitworth" (via RT) <[EMAIL PROTECTED]> wrote: > # New Ticket Created by "Andrew Whitworth" > # Please include the string: [perl #51982] > # in the subject line of all future correspondence about this issue. > # http://rt.perl.org/rt3/Ticket/Display.h

Re: [perl #51984] [PATCH] fixed "const int" to "unsigned char" conversion warnings

2008-03-21 Thread Mark Glines
On Fri, 21 Mar 2008 09:26:42 -0700 "Andrew Whitworth" (via RT) <[EMAIL PROTECTED]> wrote: > # New Ticket Created by "Andrew Whitworth" > # Please include the string: [perl #51984] > # in the subject line of all future correspondence about this issue. > # http://rt.perl.org/rt3/Ticket/Display.h

Re: [perl #51982] [PATCH] fixed signed/unsigned typecast in string_primitives.c

2008-03-21 Thread Mark Glines
On Fri, 21 Mar 2008 13:19:09 -0400 "Andrew Whitworth" <[EMAIL PROTECTED]> wrote: > Okay, i changed the function declaration in src/string_primitives.c > and include/Parrot/string_primitives.h. After a search, I couldn't > find any other files where the function Parrot_char_digit_value was > used,

Re: [perl #51988] [PATCH] file descriptor duplication updates

2008-03-21 Thread Mark Glines
On Fri, 21 Mar 2008 11:15:51 -0700 "Andrew Whitworth" (via RT) <[EMAIL PROTECTED]> wrote: > # New Ticket Created by "Andrew Whitworth" > # Please include the string: [perl #51988] > # in the subject line of all future correspondence about this issue. > # http://rt.perl.org/rt3/Ticket/Display.h

Re: [perl #52224] Parrot::Test calls parrot with a bogus optimization values when run in /opt

2008-03-29 Thread Mark Glines
On Sat, 29 Mar 2008 07:03:17 -0700 "James Keenan via RT" <[EMAIL PROTECTED]> wrote: > If we simply add a forward slash after 'opt', does that solve the > problem? (see attached) Should this code really be checking the absolute pathname? We don't have any control over where a user places a parrot

Re: [perl #52224] Parrot::Test calls parrot with a bogus optimization values when run in /opt

2008-03-29 Thread Mark Glines
On Sat, 29 Mar 2008 11:59:25 -0700 Mark Glines <[EMAIL PROTECTED]> wrote: > This changes Parrot::Test's behavior: an alternate "-O" option will > only be used if the *filename* contains "optN", not if a leading > directory name contains it. I don't s

Re: [perl #51464] [TODO] [PDD] add date stamps to PDD's

2008-04-03 Thread Mark Glines
On Thu, 03 Apr 2008 12:18:47 -0700 "James Keenan via RT" <[EMAIL PROTECTED]> wrote: > Datestamps in the filename (e.g., MMDD)? Or somewhere inside the > file? > > Wouldn't the former create repository problems? Couldn't the latter be done automatically with an $Id$ tag? Mark

Re: [perl #43102] t/pmc/threads.t tests 5,7 fail with --gc=libc

2008-04-03 Thread Mark Glines
On Thu, 03 Apr 2008 13:40:20 -0700 "Bernhard Schmalhofer via RT" <[EMAIL PROTECTED]> wrote: > On Fr. 01. Jun. 2007, 08:42:43, [EMAIL PROTECTED] wrote: > > While testing/trying to fix RT #42938, I noticed an additional test > > failure in t/pmc/threads.t. Test 7 crashes with a signal 11 > > (segme

Re: [perl #52462] [PATCH] [UGLY] FixedIntegerArray->new_from_string() needs cleanup

2008-04-04 Thread Mark Glines
On Fri, 4 Apr 2008 12:50:27 -0500 "Patrick R. Michaud" <[EMAIL PROTECTED]> wrote: > On Fri, Apr 04, 2008 at 10:06:39AM -0700, chromatic wrote: > > On Thursday 03 April 2008 15:47:12 Mark Glines wrote: > > > > > When doing a test for --gc=libc, I not

  1   2   >