Hi,

A while back, I submitted some patches to fix up header guards, make
their syntax consistent and such.  These were applied in r18461,
r18464, and others.  PDD07 contains an example which is no longer
consistent with the current headers.

I'm submitting this patch for review.  It changes

        "#if !defined(PARROT_<FILENAME>_H_GUARD)"

into

        "#ifndef PARROT_<FILENAME>_H_GUARD"

in PDD07's example.

Also note that PDD07 actually has two header guard examples; grep for
PARROT_<FILENAME>_H_GUARD and grep for PARROT_FOO_H_GUARD.  I think
these should be consolidated as well, but this patch does not address
that.

Mark
Index: docs/pdds/pdd07_codingstd.pod
===================================================================
--- docs/pdds/pdd07_codingstd.pod	(revision 20368)
+++ docs/pdds/pdd07_codingstd.pod	(working copy)
@@ -631,7 +631,7 @@
 
     /* file header comments */
 
-    #if !defined(PARROT_<FILENAME>_H_GUARD)
+    #ifndef PARROT_<FILENAME>_H_GUARD
     #define PARROT_<FILENAME>_H_GUARD
 
     /* body of file */

Reply via email to