[perl #55954] [PATCH]: Add 'make smolder_test' target

2008-09-07 Thread James Keenan via RT
No one objected to resolving this ticket, so I am doing so now. New Smolder issues? Open a new RT.

[perl #55954] [PATCH]: Add 'make smolder_test' target

2008-07-31 Thread James Keenan via RT
Since thanks to Michael Peters' work on Smolder we now have a Smolder server, and since thanks in large part to Dan Magnuszewski we have lots of Smolder reports daily, I think we have achieved the major objectives of this RT. I recommend that the ticket be marked resolved and that, if new Smolder-

Re: [perl #55954] [PATCH]: Add 'make smolder_test' target

2008-07-21 Thread Tim Heckman
Using TAP::Harness::Archive 0.12, successfully ran a "make smolder_test" on windows. http://smolder.plusthree.com/app/public_projects/report_details/2381 --- tjh On Jul 19, 2008, at 8:51 AM, Michael Peters wrote: Tim Heckman wrote: One thing I've found is that I cannot install TAP::Harne

Re: [perl #55954] [PATCH]: Add 'make smolder_test' target

2008-07-19 Thread Michael Peters
Tim Heckman wrote: One thing I've found is that I cannot install TAP::Harness::Archive on windows machines because of test failures. I submitted a ticket about this to rt.cpan.org for this along with possible fixes http://rt.cpan.org/Public/Bug/Display.html?id=37795 I saw those and will try

Re: [perl #55954] [PATCH]: Add 'make smolder_test' target

2008-07-19 Thread Tim Heckman
One thing I've found is that I cannot install TAP::Harness::Archive on windows machines because of test failures. I submitted a ticket about this to rt.cpan.org for this along with possible fixes http://rt.cpan.org/Public/Bug/Display.html?id=37795 tjh On Jul 15, 2008, at 10:35 AM,

Re: [perl #55954] [PATCH]: Add 'make smolder_test' target

2008-07-19 Thread Michael Peters
James Keenan via RT wrote: Since we've applied and refined the patches that Michael Peters originally submitted, is there any particular reason to keep this RT open? Not that I can think of. Close away! -- Michael Peters Plus Three, LP

[perl #55954] [PATCH]: Add 'make smolder_test' target

2008-07-18 Thread James Keenan via RT
And I applied one little grammatical correction. Since we've applied and refined the patches that Michael Peters originally submitted, is there any particular reason to keep this RT open? kid51

Re: [perl #55954] [PATCH]: Add 'make smolder_test' target

2008-07-18 Thread Will Coleda
On Fri, Jul 18, 2008 at 10:13 AM, Michael Peters <[EMAIL PROTECTED]> wrote: > James Keenan via RT wrote: >> >> I was told on #parrot that you have to replace # TODO comments by >> creating RT tickets and referencing the RT instead of the TODO. >> >> Perhaps it would be simpler to just delete these

Re: [perl #55954] [PATCH]: Add 'make smolder_test' target

2008-07-18 Thread Michael Peters
James Keenan via RT wrote: I was told on #parrot that you have to replace # TODO comments by creating RT tickets and referencing the RT instead of the TODO. Perhaps it would be simpler to just delete these comments. Please advise. Thank you very much. The first one (line 103) refers to the

Re: [perl #55954] [PATCH]: Add 'make smolder_test' target

2008-07-18 Thread James E Keenan
On Jul 18, 2008, at 3:37 AM, Bernhard Schmalhofer via RT wrote: I was told on #parrot that you have to replace # TODO comments by creating RT tickets and referencing the RT instead of the TODO. Perhaps it would be simpler to just delete these comments. Please advise. Thank you very much.

Re: [perl #55954] [PATCH]: Add 'make smolder_test' target

2008-07-18 Thread Bernhard Schmalhofer
James Keenan via RT schrieb: Michael: I install TAP::Harness::Archive from CPAN, then applied the patches to a fresh checkout from trunk. I configured, built and ran 'make smolder_test'. The Smolder test completed and stated that it uploaded -- though I have a tough time matching my particular

[perl #55954] [PATCH]: Add 'make smolder_test' target

2008-07-17 Thread James Keenan via RT
Michael: I install TAP::Harness::Archive from CPAN, then applied the patches to a fresh checkout from trunk. I configured, built and ran 'make smolder_test'. The Smolder test completed and stated that it uploaded -- though I have a tough time matching my particular report to those at http://smol

Re: [perl #55954] [PATCH]: Add 'make smolder_test' target

2008-07-15 Thread Michael Peters
Michael Peters wrote: > Here's some more patches to improve things. It adds the following: > > + require TAP::Harness::Archive 0.10 so we can add extra_properties to our > TAP > archives. > + Collect Architecture, Compiler, DEVEL, Optimize, Perl Version, Platform, > SVN > Revision an

Re: [perl #55954] [PATCH]: Add 'make smolder_test' target

2008-07-05 Thread Michael Peters
Here's some more patches to improve things. It adds the following: + require TAP::Harness::Archive 0.10 so we can add extra_properties to our TAP archives. + Collect Architecture, Compiler, DEVEL, Optimize, Perl Version, Platform, SVN Revision and Version data into our TAP archives as

Re: [perl #55954] [PATCH]: Add 'make smolder_test' target

2008-07-01 Thread chromatic
On Tuesday 01 July 2008 16:47:23 Michael Peters wrote: > The "make smolder_test" target is supposed to create it. It's the TAP > archive. Does it exist anywhere on your system? Oh nevermind, that was my mistake. Fixed in r28927. -- c

Re: [perl #55954] [PATCH]: Add 'make smolder_test' target

2008-07-01 Thread chromatic
On Tuesday 01 July 2008 16:47:23 Michael Peters wrote: > James Keenan via RT wrote: > > What is this parrot_test_run.tar.gz? > The "make smolder_test" target is supposed to create it. It's the TAP > archive. Does it exist anywhere on your system? I'm not getting it either, for some reason. -- c

Re: [perl #55954] [PATCH]: Add 'make smolder_test' target

2008-07-01 Thread Michael Peters
James Keenan via RT wrote: > What is this parrot_test_run.tar.gz? The "make smolder_test" target is supposed to create it. It's the TAP archive. Does it exist anywhere on your system? -- Michael Peters Plus Three, LP

[perl #55954] [PATCH]: Add 'make smolder_test' target

2008-07-01 Thread James Keenan via RT
But we're not out of the woods yet! After installing all these prerequisites: Devel::Symdump Pod::Coverage Test::Pod Test::Pod::Coverage YAML::Tiny TAP::Harness::Archive ... I said 'make smolder_test' and got output that ended up here: /usr/local/bin/perl t/harness --gc-debug --running-make-tes

[perl #55954] [PATCH]: Add 'make smolder_test' target

2008-07-01 Thread James Keenan via RT
On Tue Jul 01 11:43:43 2008, [EMAIL PROTECTED] wrote: > On Tuesday 01 July 2008 04:44:55 James Keenan via RT wrote: > > > Applying this patch, my 'make test' immediately failed. > > Does this patch fix it? > > -- c > Works on the computer from which I originally reported the problem: Perl 5.1

[perl #55954] [PATCH]: Add 'make smolder_test' target

2008-07-01 Thread James Keenan via RT
On Tue Jul 01 11:43:43 2008, [EMAIL PROTECTED] wrote: > On Tuesday 01 July 2008 04:44:55 James Keenan via RT wrote: > > > Applying this patch, my 'make test' immediately failed. > > Does this patch fix it? > So far so good. On a different box from the one on which I experienced the error, I c

Re: [perl #55954] [PATCH]: Add 'make smolder_test' target

2008-07-01 Thread chromatic
On Tuesday 01 July 2008 04:44:55 James Keenan via RT wrote: > Applying this patch, my 'make test' immediately failed. Does this patch fix it? -- c === t/harness == --- t/harness (revision 28942) +++ t/harness (local) @@ -75,7 +75,7

Re: [perl #55954] [PATCH]: Add 'make smolder_test' target

2008-07-01 Thread Will Coleda
On Tue, Jul 1, 2008 at 7:49 AM, James Keenan via RT <[EMAIL PROTECTED]> wrote: > I should add that this was the result of 'svn up', not of applying a patch: > > $ svn info > Path: . > URL: https://svn.perl.org/parrot/trunk > Repository Root: https://svn.perl.org/parrot > Repository UUID: d31e2699-5

[perl #55954] [PATCH]: Add 'make smolder_test' target

2008-07-01 Thread James Keenan via RT
I should add that this was the result of 'svn up', not of applying a patch: $ svn info Path: . URL: https://svn.perl.org/parrot/trunk Repository Root: https://svn.perl.org/parrot Repository UUID: d31e2699-5ff4-0310-a27c-f18f2fbe73fe Revision: 28889 Node Kind: directory Schedule: normal Last Change

[perl #55954] [PATCH]: Add 'make smolder_test' target

2008-07-01 Thread James Keenan via RT
Applying this patch, my 'make test' immediately failed. Compiling with: xx.c /usr/bin/gcc -I./include -fno-common -no-cpp-precomp -pipe -I/opt/local/include -pipe -fno-common -Wno-long-double -DHASATTRIBUTE_CONST -DHASATTRIBUTE_DEPRECATED -DHASATTRIBUTE_MALLOC -DHASATTRIBUTE_NONNULL -DHASATTRIBUTE

Re: [perl #55954] [PATCH]: Add 'make smolder_test' target

2008-06-30 Thread chromatic
On Wednesday 18 June 2008 07:42:00 Michael Peters wrote: > It seems that archname was not defined in $PConfig, so I just used cpuarch. > I also changed $^X to be $PConfig{osname}. The fixed patch is attached. > > I also noticed that I didn't include the new Test::Harness in that patch. > So I've a

Re: [perl #55954] [PATCH]: Add 'make smolder_test' target

2008-06-19 Thread C.J. Adams-Collier
James, Did you svn add the new files first? I didn't see any new files in that diff... You can usually get a commit bit by asking on #perl6 on irc.freenode.net Cheers, C.J. On Tue, 2008-06-17 at 12:37 -0700, James Keenan wrote: > # New Ticket Created by James Keenan > # Please include the s

[perl #55954] [PATCH]: Add 'make smolder_test' target

2008-06-17 Thread James Keenan via RT
... and now, adding Jerry Gay's comment: excellent! this came together quickly and simply, by the looks of it. the patch format is fine, especially for a first patch (for more details of our precise requirements you can read docs/submissions.pod). one gotcha, you've got 'use Config;' which pulls i

[perl #55954] [PATCH]: Add 'make smolder_test' target

2008-06-17 Thread via RT
# New Ticket Created by James Keenan # Please include the string: [perl #55954] # in the subject line of all future correspondence about this issue. # http://rt.perl.org/rt3/Ticket/Display.html?id=55954 > Forwarding Michael's post so that an RT is opened. I've got this working pretty well on