Re: 20.xx: postponse LuCI HTTPS per default

ions. Very much in favour of leaving this off, self-signed isn't viable by default Sincerely, Karl Palsson OpenPGP-digital-signature.html Description: OpenPGP Digital Signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH] base-files: read all 5 bytes in get_magic_fat32() at once

extremely_ small, un measured pseudo gain. I'd kinda imagine that the underlying layer already read a bigger block anyway... Sincerely, Karl Palsson Adrian Schmutzler wrote: > While the speed improvement might be negligible, there is still > no reason to read individual bytes. &g

Re: [PATCH] state: check return value of chown

e error > messages. Imho an assertion is the right thing to do here. > Do we compile with assertions enabled? Sincerely, Karl Palsson OpenPGP-digital-signature.html Description: OpenPGP Digital Signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH] state: check return value of chown

Daniel Golle wrote: > On Mon, Jan 04, 2021 at 05:08:22PM -0000, Karl Palsson wrote: > > > > Daniel Golle wrote: > > > On Sat, Jan 02, 2021 at 10:01:36PM +0800, yehol...@outlook.com > > > wrote: > > > > > > -

RE: [PATCH] rockchip: use stable MAC-address for NanoPi R2S

ou're only operating on a 1k block read out anyway. This sort of suggestion is pointless noise that just makes things harder to read. Sincerely, Karl Palsson OpenPGP-digital-signature.html Description: OpenPGP Digital Signature ___ ope

Re: [PATCH] pcre: disable C++ bindings

ow much support _is_ given to downstream openwrt builds, it doesn't seem unreasonable that for a general package like this we should offer all of it? Sincerely, Karl Palsson OpenPGP-digital-signature.html Description: OpenPGP Digital Signature ___ op

Re: [OpenWrt-Devel] WAN dhcp client doesnt recognize unplugged cable and doesnt request new IP on replugged

Hans Dedecker wrote: > netifd enables by default force_link for interface with as proto > static; are you referring to such an interface ? > I'm not a big fan of enabling force_link by default as I already > discussed this behavior on the OpenWRT Devel mailing list > (https://lists.openwrt.org/pi

Re: [OpenWrt-Devel] WAN dhcp client doesnt recognize unplugged cable and doesnt request new IP on replugged

ed down when the link cable was unplugged. Do you use > the netifd trunk version ? no idea, what version would that be exactly? netifd packages just have a date and a git tag :) I'm going to run some more tests on this, thanks for the information and background so far. Cheers, Karl Pal

[OpenWrt-Devel] [PATCH] scripts/feeds: observe -p flag for preferential feeds

From: Karl Palsson lookup_target was trampling the $feed variable, resulting in the -p flag no longer preferentially installing from the named feed. Signed-off-by: Karl Palsson --- scripts/feeds | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/feeds b/scripts

[OpenWrt-Devel] [PATCH] scripts/feeds: print the source of packages installed

From: Karl Palsson Can be helpful in diagnosing unexpected package overlaps between feeds. Signed-off-by: Karl Palsson --- scripts/feeds | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/feeds b/scripts/feeds index a6be9cc..e060242 100755 --- a/scripts/feeds +++ b

[OpenWrt-Devel] [PATCH] scripts/feeds: fix typo in copied code

From: Karl Palsson do_install_target copied code from do_install_package, but didn't replace all text. Signed-off-by: Karl Palsson --- scripts/feeds | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/feeds b/scripts/feeds index a6be9cc..b6d2f45 100755 --- a/sc

[OpenWrt-Devel] [PATCH v2] scripts/feeds: print the source of packages installed

From: Karl Palsson Can be helpful in diagnosing unexpected package overlaps between feeds/core. Signed-off-by: Karl Palsson --- Changes since v1: Include feed source for override case as well, as suggested by Mathieu Olivari scripts/feeds | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [OpenWrt-Devel] Link detection - TP-Link Archer C7 v2

Christian Mehlis wrote: > Am 26.05.2015 um 22:48 schrieb Richard Clark: > > https://dev.openwrt.org/ticket/17674 (set to closed / duplicate) but no > > reference > > > > Any thoughts, suggestions, or can someone give me some pointers on where > > I can be digging in the openwrt kernel code for wh

[OpenWrt-Devel] [PATCHv2] scripts/feeds: observe -p flag for preferential feeds

From: Karl Palsson lookup_target was trampling the $feed variable, resulting in the -p flag no longer preferentially installing from the named feed. Make sure to use a local variable for this instead. Signed-off-by: Karl Palsson --- Changes since v1: Make sure to not just trample a global

Re: [OpenWrt-Devel] Link detection - TP-Link Archer C7 v2

quot;cable" (pcb traces) between two parts of the board inside my "dumb" box is in place. While I appreciate the design that makes this not working already, when there _is_ a fixed port, I _do_ expect this to work. Sincerely, Karl Palsson [1] I'

Re: [OpenWrt-Devel] [PATCHv2] scripts/feeds: observe -p flag for preferential feeds

John Crispin wrote: > On 27/05/2015 18:03, Karl Palsson wrote: > > + my $this_feed_target = lookup_target($feed, $name); > > + $this_feed_target and do { > > how about just calling it $target ? Because even though the method is "lookup_target" it actuall

Re: [OpenWrt-Devel] [PATCHv2] scripts/feeds: observe -p flag for preferential feeds

Karl Palsson wrote: > > John Crispin wrote: > > On 27/05/2015 18:03, Karl Palsson wrote: > > > + my $this_feed_target = lookup_target($feed, $name); > > > + $this_feed_target and do { > > > > how about just calling it $target ? > > Beca

[OpenWrt-Devel] procd "reload" vs "reload_config"

Hi, I've got a procd init script that uses "procd_set_param file /etc/config/special_config.json" Now, maybe I shouldn't have a non-uci file in this directory, but that's what I've got, from a predecessor. If I don't have the "procd_set_param file" line in the init script, then changing the

Re: [OpenWrt-Devel] [PATCH] Add Support for WeIO Board (Chaos Calmer)

Drasko DRASKOVIC wrote: > Hi Karl, > > On Mon, Jun 15, 2015 at 11:48 AM, Karl Palsson > wrote: > > > > A lot of this messes up the alphabetical ordering. > > Can you point me to exact spots? > > I tried to add WeIO support next to Carambola2, as in many c

Re: [OpenWrt-Devel] [PATCH] Add support for WeIO board. WeIO board (http://we-io.net) is based on Carambola2 module from 8Devices, and the patch adds a separate profile.

You said you're removed the commented out code? Also, somehow your description ended up in the subject... (More comments inline, but this looks like an older version of the patch) Sincerely, Karl Palsson Drasko DRASKOVIC wrote: > Signed-off-by: Drasko DRASKOVIC > --- >

Re: [OpenWrt-Devel] [PATCH] linux-3.18: prevent redefinition of struct ethhdr

Alejandro Mery wrote: > when using musl packages include netinet/ether.h break because > struct ethhdr gets redefined. > > this patch comes includes a patch originally from sabotage linux > and it has been submitted upstream https://lkml.org/lkml/2014/3/14/266 > If this gets merged, could we t

Re: [OpenWrt-Devel] [PATCHv2] scripts/feeds: observe -p flag for preferential feeds

Karl Palsson wrote: > > John Crispin wrote: > > > On 27/05/2015 18:03, Karl Palsson wrote: > > > > + my $this_feed_target = lookup_target($feed, $name); > > > > + $this_feed_target and do { > > > > > > how about just callin

Re: [OpenWrt-Devel] oldpackages for CC

Steven Barth wrote: > oldpackages are obsolete and in many instances riddled with security > issues. > They should not be used at all. Right, but that's not really relevant here. This is about packages which are up to date, have maintainers, but are not in old packages, and not in the for-15.05

[OpenWrt-Devel] please backport to 15-05: "scripts/feeds: observe -p flag for preferential feeds"

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Please backport 52c3a2972cf7cdd7184e8d60d684df459860d255 to the 15-05 branch. This is a regression from 14.07 and 12.10, but missed being merged before the branch was pulled. Sincerely, Karl Palsson -BEGIN PGP SIGNATURE- Version: GnuPG

Re: [OpenWrt-Devel] [PATCH][v2] ar71xx: add support for D-Link DIR-615 rev. Ix board

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 a couple of places look to be out of order... > On 07/07/2015 15:18, Jaehoon You wrote: > > diff --git a/target/linux/ar71xx/base-files/etc/uci-defaults/02_network > > b/target/linux/ar71xx/base-files/etc/uci-defaults/02_network > > old mode 100644

Re: [OpenWrt-Devel] [PATCH] [ar71xx] Add support for Onion Omega

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Please consider renaming your "board". If I understand your website properly, the module is the Omega, and this boardfile is for the omega _with_ one of it's "docks" This "Omega" boardfile would not be usable for someone with a different dock, with l

Re: [OpenWrt-Devel] [PATCH] [ar71xx] Add support for Onion Omega

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Boken Lin wrote: > The firmware won't be dock-specific. The same firmware will be used > regardless of which dock the Omega is plugged into. And all docks have > similar configuration, i.e. every dock has a USB port. > And when I build a board and p

Re: [OpenWrt-Devel] [PATCH] ramips: adding support for OY-0001 Wireless Router

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Isn't this normally called the "OYE-0001" ? not "OY-0001" ? The website and all literature I've seen uses the "OYE-0001" name... Regardless, in many places, you have not followed the existing alphabetical order. LiWeijian wrote: > From: Tom Deng <2

Re: [OpenWrt-Devel] [PATCH] ramips: adding support for OY-0001 Wireless Router

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 John Crispin wrote: > > > On 10/07/2015 13:27, Karl Palsson wrote: > > Isn't this normally called the "OYE-0001" ? not "OY-0001" ? The website > > and all literature I've seen uses the "OY

Re: [OpenWrt-Devel] [PATCH CC 0/5] ar71xx: backport of support for devolo dLAN devices

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 We're adding support for gpio irqs to all of ar71xx this late in the CC release?No possible side affects here? Are the gpio irqs required for these platforms? What makes these two platforms special that they can be added as new platforms this lat

Re: [OpenWrt-Devel] Chaos Calmer 15.05-rc3

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jonas Gorski wrote: > On Thu, Jul 16, 2015 at 7:08 PM, Arturo Rinaldi > wrote: > > after running the git 'reset' command : > > > > $ git reset --hard 171f0fd10830acd3259f7c229f1b65b95595f388 > > > > in the trunk directory returns me : > > > > fatal:

Re: [OpenWrt-Devel] [PATCH] bugfix: FORCE=1 doesn't work to override prereq checks

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 What prereq can be forced that makes force even a worthwhile option? If it works anyway, why not just drop the prereq check? If it still won't work, what's the point in allowing a force? Cheers, Karl P Lawrence D'Anna wrote: > If the build prereq

Re: [OpenWrt-Devel] [PATCH] Add support for WeIO board. WeIO board (http://we-io.net) is based on Carambola2 module from 8Devices, and the patch adds a separate profile.

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Let me just preface this with... I am _not_ any sort of authority on code style, or any sort of "approved" openwrt commit police. I'm just some person subscribed to the mailing list. You are _absolutely_ entitled to ignore anything I say. ... App

Re: [OpenWrt-Devel] [PATCH] Add WeIO board (http://we-io.net) profile. This patch adds support for WeIO board, which is based on Carambola2 board from 8Devices.

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Just one more, I promise :) Drasko DRASKOVIC wrote: > + > +static void __init weio_common_setup(void) > +{ > + u8 *art = (u8 *) KSEG1ADDR(0x1fff); > + > + ath79_register_m25p80(NULL); > + ath79_register_wmac(art + WEIO_CALDATA_OFFSET,

Re: [OpenWrt-Devel] [PATCH] [SIGNED-OFF] Add WeIO board (http://we-io.net) profile. This patch adds support for WeIO board, which is based on Carambola2 board from 8Devices.

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Comments inline... Drasko DRASKOVIC wrote: > Signed-off-by: Drasko DRASKOVIC > --- Might just be my mail client, but might be yours, did you change anything to send this? you seem to have lost all the commit message up into the subject? > targe

Re: [OpenWrt-Devel] [PATCH] [kernel] cp201x: Add GPIO ioctl commands (from Silicon Labs)

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 "Ted Hess" wrote: > After a bit more research - This is what I know: > > The upstream cp210x driver is not completely up-to-date with the driver > silabs maintains on > their site. In their own words: "... unfortunately GPIO is not something > that h

Re: [OpenWrt-Devel] [PATCH] Ar71xx: Add Minibox v1.0 support

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 This has many cases where you have added the board out of order. The lists are generally alphabetically sorted, and should be maintained that way, even though a few boards escaped this. More comments inline. Stijn Segers wrote: > Hello, > > The p

Re: [OpenWrt-Devel] [PATCH] Ar71xx: Add Minibox v1.0 support

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Stijn Segers wrote: > Hi Karl, > > Thanks for your time. > > I have reworked the patch and re-ordered where possible (files like > ar71xx.sh and diag.sh lack any alphabetical > order). I have removed the code that set the led to status_led_off. >

[OpenWrt-Devel] [PATCH 1/2] lua: use pkg-config built in module to search for alternatives

From: Karl Palsson Different distributions have different names for the lua 5.1 package. Use cmake's built in pkg-config support to search for the first one, rather than running it explicitly and searching for a single version. Signed-off-by: Karl Palsson --- There's a line further

Re: [OpenWrt-Devel] [PATCH v2] AR71xx: Add Minibox V1.0 support

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Personally I'd like to see Gainstrong mentioned _somewhere_ in the patch itself. > +--- a/arch/mips/ath79/machtypes.h > b/arch/mips/ath79/machtypes.h > +@@ -74,6 +74,7 @@ enum ath79_mach_type { > + ATH79_MACH_JA76PF2, /* jjPlus JA

Re: [OpenWrt-Devel] [PATCH v2] AR71xx: Add Minibox V1.0 support

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 John Crispin wrote: > > > On 17/08/2015 23:25, Karl Palsson wrote: > > Personally I'd like to see Gainstrong mentioned _somewhere_ in the patch > > itself. > > > >> +--- a/arch/mips/ath79/machtypes.

Re: [OpenWrt-Devel] [PATCH v3] Add Minibox v1.0 support

s > been confirmed working but the LED is off during normal operation (I > assume > this is the possible LED polarity issue Karl Palsson was talking about?) > > Questions: > > - Can I simply set gpio_led minibox_v1_leds_gpio to active.low = 1 or isn't > that how it w

Re: [OpenWrt-Devel] European Commission secretly passes same measure as FCC OpenWRT ban ?

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dominique Martinet wrote: > > >Caleb James DeLisle: > > >>Seems to be one German newspaper reporting that Directive 2014/53/EU > > >>places an EU ban on flashing devices. > > >> > > >>http://www.heise.de/netze/meldung/Funkregulierung-Angriff-auf-alter

Re: [OpenWrt-Devel] [PATCH v4] base-files: add /etc/profile.d support

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jo-Philipp Wich wrote: > Hi. > > > Why the -e? You only got existing files in the glob above right? > > Almost. If the directory does not exist or is empty then the glob > pattern is returned literally, e.g. "echo /tmp/*" will expand to a list > o

Re: [OpenWrt-Devel] [PATCH v4] base-files: add /etc/profile.d support

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 edgar.sol...@web.de wrote: > On 04.09.2015 11:51, karlp wrote: > > include() { > > local file > >

Re: [OpenWrt-Devel] [PATCH] openwrt/hardening: Fix CFLAGS usage for -D_FORTIFY_SOURCE

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Helmut Schaa wrote: > On Tue, Sep 8, 2015 at 9:03 AM, Stefan Peter > wrote: > > Hi > > Am 07.09.2015 um 17:32 schrieb Helmut Schaa: > >> Fix the following configure error with c-ares by using CPPFLAGS for > >> -D_FORTIFY_SOURCE. > >> Not sure if any

Re: [OpenWrt-Devel] [PATCH] ar71xx: fix ar724x clock calculation

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Weijie Gao wrote: > Signed-off-by: Weijie Gao > > According to the AR7242 datasheet section 2.8, AR724X CPUs use a 40MHz > input clock as the REF_CLK instead of 5MHz. > > The correct CPU PLL calculation procedure is as follows: > CPU_PLL = (DIV * R

Re: [OpenWrt-Devel] [PATCH] Complete the trunk rename from Chaos Calmer to Designated Driver

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hartmut Knaack wrote: > Hannu Nyman schrieb am 13.09.2015 um 19:51: > > Sorry, but what is the problem? > > Most importantly: laziness. In my case, I just keep hitting the next > email > button and have a quick look. Having to open the attachment, ch

Re: [OpenWrt-Devel] Question about custom script at init on Trunk.-

asier to hook into the existing target code, rather than trying to copy target detection and config into a package Config.in options Sincerely, Karl Palsson -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJWqJbVAAoJEBmotQ/U1cr29HwP/3I3TemR4suETncwKdssUHpt 7RP4+SPgSZPENNu

Re: [OpenWrt-Devel] Question about custom script at init on Trunk.-

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 David Lang wrote: > > > > Now, yes, I can have my 80_mystuff script go and try and create > > the package config files it might want to modify, but really, I > > want "mystuff" to run _last_ or at least, after all the packages > > have run. Is there a

Re: [OpenWrt-Devel] Question about custom script at init on Trunk.-

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 David Lang wrote: > On Wed, 27 Jan 2016, Karl Palsson wrote: > > > David Lang wrote: > >>> > >>> Now, yes, I can have my 80_mystuff script go and try and create > >>> the package config files i

[OpenWrt-Devel] detecting USB sd card removal ("block info")

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Given that OpenWrt doesn't have a daemon like udisks to mount/umount things automatically, I was trying to build it myself by something like "block info" in a crontab. "block info" correctly identifies when I insert an sd card into slot on a fixed USB

Re: [OpenWrt-Devel] detecting USB sd card removal ("block info")

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Daniel Golle wrote: > Hi Karl, > > On Thu, Jan 28, 2016 at 09:31:14AM -0000, Karl Palsson wrote: > > Given that OpenWrt doesn't have a daemon like udisks to > > mount/umount things automatically, I was trying to build it &g

Re: [OpenWrt-Devel] [PATCH] libubus.h: marking unused variables

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Isn't it more standard and cross compiler to do instead... (void)ctx; Rather than sprinkling gcc attributes around? Sincerely, Karl Palsson Emanuel Taube wrote: > > diff --git a/libubus.h b/libubus.h > index 08dac49..d419205

Re: [OpenWrt-Devel] [PATCH 3/4] uci: add support for speed_mask to switch LED init scripts

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Michal wrote: > echo $port_mask > > /sys/class/leds/${sysfs}/port_mask > + config_get speed_mask $1 speed_mask > + [ -n "$speed_mask" ] && \ > + echo $s

[OpenWrt-Devel] block info and DISK_MEDIA_CHANGE events

handling, looking _only_ for the DISK_MEDIA_CHANGE event, and handle mount/umount as appropriate? Or should something else be converting these into add/remove events? Sincerely, Karl Palsson -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJWx0pHAAoJEBmotQ/U1cr2ueoP

Re: [OpenWrt-Devel] block info and DISK_MEDIA_CHANGE events

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 John Crispin wrote: > > > On 19/02/2016 18:00, Karl Palsson wrote: > > Hi, > > > > I'm trying to get "block mount" to behave well when a microSD > > card is removed/inserted from a fixed USB c

[OpenWrt-Devel] block: DISK_MEDIA_CHANGE uevents vs add/remove events

nsible for them? Or alternatively, is userspace _meant_ to be handling this directly from the "change" events? I see that with a CD-ROM, there are no kernel add/remove events, only change events, unlike SD cards. Sincerely, Karl Palsson [1] Using the "in kernel" event polling with &q

[OpenWrt-Devel] [PATCH] leds: support oneshot as well as timer triggers

From: Karl Palsson oneshot and timer have the same configuration options, just a different trigger name. Signed-off-by: Karl Palsson --- package/base-files/files/bin/config_generate | 4 ++-- package/base-files/files/lib/functions/uci-defaults.sh | 17 + 2 files

[OpenWrt-Devel] [PATCHv2] leds: support oneshot as well as timer triggers

From: Karl Palsson oneshot and timer have the same configuration options, just a different trigger name. Signed-off-by: Karl Palsson --- package/base-files/files/bin/config_generate | 4 ++-- package/base-files/files/lib/functions/uci-defaults.sh | 17 + 2 files

Re: [OpenWrt-Devel] Setting uci defaults in trunk

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Felix Fietkau wrote: > - Interfaces using dhcp are usually considered 'wan' instead of 'lan', > LAN should have a predictable IP address. > If you believe that that any of the above changes are > necessary, please provide compelling reasons for it. Ot

[OpenWrt-Devel] [PATCH] buildroot: improve git submodule handling for packages

package does not use submodules, but its topic branch for OpenWRT does. This changes the buildroot dependency from git-1.6.2 to git 1.7.12.2, which was released September 2012. Signed-off-by: Darik Horn Signed-off-by: Karl Palsson --- include/download.mk | 5 +++-- include/prereq-build.mk

[OpenWrt-Devel] [PATCH] service: Support writing pidfiles

From: Karl Palsson Use the "pidfile" attribute of a service to decide whether to write a pidfile or not. Files are removed on stop/restart, and correctly created if the config has changed. Signed-off-by: Karl Palsson --- service/insta

[OpenWrt-Devel] [PATCHv2] procd: service: Support writing pidfiles

From: Karl Palsson Use the "pidfile" attribute of a service to decide whether to write a pidfile or not. Files are removed on stop/restart, and correctly created if the config has changed. Signed-off-by: Karl Palsson --- Changes since v1: Proper check of fopen return value - than

[OpenWrt-Devel] [PATCH] procd: support pidfile writing.

From: Karl Palsson procd from revision b12bb150ed38a4409bef5127c77b060ee616b860 supports writing a pidfile. This adds support for setting that parameter with standard init script hooks: procd_set_param pidfile /var/run/someprocess.pid Signed-off-by: Karl Palsson --- package/system/procd

Re: [OpenWrt-Devel] [PATCH] ar71xx: Add support for the OMYlink OMY-X1

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 "L. D. Pinney" wrote: > https://wiki.openwrt.org/toh/omylink/omy-x1 ... > diff --git > a/target/linux/ar71xx/files/arch/mips/ath79/mach-omy-x1.c > b/target/linux/ar71xx/files/arch/mips/ath79/mach-omy-x1.c new > file mode 100644 index 000..2299a24

Re: [OpenWrt-Devel] [PATCH] ramips: Add support for Xiaomi MiWiFi Nano

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Minor comments... Noble Pepper wrote: > Xiaomi MiWiFi Nano is based on Mediatek MT7628 with 64MB ram 16 > MB flash > > Signed-off-by: Noble Pepper > --- > package/boot/uboot-envtools/files/ramips | 3 +- > .../linux/ramips/base-files/et

Re: [OpenWrt-Devel] Question regarding call python script

Bastian Bittorf wrote: > * Paul Fertser [11.03.2016 11:15]: > > As a sidenote, POSIX shell doesn't support associative arrays (which > > were mentioned in this thread), so it's probably worth clarifying > > whether it's ok to require bash >= 4 for OpenWrt build scripts or not. > > yes, POSIX is

Re: [OpenWrt-Devel] [PATCH] toolchain/uClibc: enable UCLIBC_HAS_OBSOLETE_BSD_SIGNAL

Alexey Brodkin wrote: > This is required to build net-snmp. What version of net-snmp are you using? Is this because ARC is still on uclibc instead of musl like everyone else? net-snmp (5.4.4) built fine (and still builds fine) on uclibc in the 15.05 branch. When are you planning on moving off uc

[OpenWrt-Devel] [PATCH] projects/uci: lua: use built in pkg-config support for alternatives

From: Karl Palsson Different distributions have different names for the lua 5.1 package. Use cmake's built in pkg-config support to search for the first one, rather than running it explicitly and searching for a single version. Signed-off-by: Karl Palsson --- This is the same as

Re: [OpenWrt-Devel] [PATCH v2] dnsmasq: run as dedicated UID/GID

Would it be worthwhile keeping these userids in a wiki registry page maybe? This is a current extract from the packages feed and the base packages. 22:sshd 22:sshd 51:pulse 52:tor 53:zabbix 54:prosody 56:dmapd 57:bind 59:dovecot 72:ocserv 87:icecast 88:pianod 89:upmpdcli 99:_fdm 105:avahi 121:lld

[OpenWrt-Devel] [PATCH 2/2] ubus: lua: use built in pkg-config support for alternatives

From: Karl Palsson Different distributions have different names for the lua 5.1 package. Use cmake's built in pkg-config support to search for the first one, rather than running it explicitly and searching for a single version. Signed-off-by: Karl Palsson --- Same patch as in libubox

[OpenWrt-Devel] [PATCH 1/2] ubus: lua: return string errors, not just codes

From: Karl Palsson Return an extra string to lua clients, not just the code. Signed-off-by: Karl Palsson --- Makes it much more pleasant when working with ubus via lua, rather than simply getting the integer return code. example code also updated to demonstrate access to the code and message

Re: [OpenWrt-Devel] Introducing the LEDE project

Jo-Philipp Wich wrote: > Hi, > > we'd like to introduce LEDE, a reboot of the OpenWrt community On a purely logistical note, is there any purpose in sending patches/pulls/bugs to _openwrt-devel_ any more? It sounds like there's effectively no-one left to read them. What about procd, fstools, l

Re: [OpenWrt-Devel] Introducing the LEDE project

Daniel Dickinson wrote: > > Silly question, but can you outline some specific examples of > contributions that an outsider like me has somehow missed as > being as concrete examples of companies contributing back to > openwrt, rather than just benefiting from it? Every commit from me. We're a t

Re: [OpenWrt-Devel] [LEDE-DEV] TR-069 for OpenWrt

David Lang wrote: > On Thu, 26 May 2016, Delbar Jos wrote: > > > We are conscious of the fact that together with the proposals made by > > Felix, > > Luka and Wojtek we are now looking at many "competing" proposals. As a next > > step, we recommend to organize a workshop, at a practical locat

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH] _GNU_SOURCE should be defined for building vs uClibc

John Crispin wrote: > > > On 23/05/2016 20:12, Waldemar Brodkorb wrote: > > Hi John, > > John Crispin wrote, > > > >> Hi, > >> is it really a gnu extension or is uclibc b0rked for these symbols ? > > > > I think it isn't b0rked. > > It was added for ARM GNU libc here under #ifdef __USE_GNU: >

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH] _GNU_SOURCE should be defined for building vs uClibc

Waldemar Brodkorb wrote: > > > > This still doesn't work on the uclibc in openwrt-CC branch. The > > O_PATH definitions are in asm-generic/fcntl.h, which can be > > included via linux/fcntl.h, _GNU_SOURCE doesn't get this pulled > > in though. > > > > I attempted to add includes for linux/fcntl

Re: [OpenWrt-Devel] [PATCH 2/6] openssl: add option to disable compression support

You've changed the default for compression in this patch, was that intentional? Dirk Feytons wrote: > Signed-off-by: Dirk Feytons > --- > package/libs/openssl/Config.in |5 + > package/libs/openssl/Makefile | 13 ++--- > 2 files changed, 15 insertions(+), 3 deletions(-) > >

Re: [OpenWrt-Devel] [PATCH 4/6] openssl: add option to disable PSK support

This is turning off PSK by default right? I actually use that option, and it's a relatively common use with mosquitto, which supports PSK for client auth. Could you leave it on by default please? PSK, and SRP are badly treated by people who wants certs everywhere, but they're perfectly reasonable,

Re: [OpenWrt-Devel] [PATCH 4/6] openssl: add option to disable PSK support

Dirk Feytons wrote: > On 9 June 2016 at 13:55, Karl Palsson > wrote: > > > > This is turning off PSK by default right? I actually use that > > option, and it's a relatively common use with mosquitto, which > > supports PSK for client auth. Could you leave it

Re: [OpenWrt-Devel] [PATCH v2 5/6] openssl: remove some unneeded functionality and algorithms

On this one, does SRP have to be included? I'm not using it, and i know it's super uncommon, but it's like PSK, only easier to use, and disabling it in even more places is just guaranteeing that it's never going to be used. Totally understand tossing all the others though. Cheers, Karl P Dirk Fe

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH] procd: uClibc O_PATH backwards compatibility fixes

Does this actually preserve what O_PATH implies or does it just make it compile properly when people use the O_PATH attribute? Cheers, Karl P Hans Dedecker wrote: > Signed-off-by: Hans Dedecker > --- > inittab.c | 4 > utils/utils.c | 4 > 2 files changed, 8 insertions(+) > >

Re: [OpenWrt-Devel] [PATCH v4 5/5] ar71xx: add support for Cisco's MR18

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Chris R Blake wrote: > From: Chris R Blake > > This patch adds support for Cisco's MR18. > Detailed instructions for the flashing the device can > be found in the OpenWrt forum thread: > > > Signed

[OpenWrt-Devel] [PATCH] package: iperf3: Update URL

From: Karl Palsson Update iperf3 to point to the correct project website. Prior URL was the old iperf2 website. Signed-off-by: Karl Palsson --- package/network/utils/iperf3/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/network/utils/iperf3/Makefile b

[OpenWrt-Devel] [PATCH] libubox: lua: use pkg-config built in module to search for alternatives

From: Karl Palsson Different distributions have different names for the lua 5.1 package. Use cmake's built in pkg-config support to search for the first one, rather than running it explicitly and searching for a single version. Signed-off-by: Karl Palsson --- Resending after running into

[OpenWrt-Devel] periodic task checking for usb flash media?

ackage or config? I'm not asking about automounting, there's plenty of wiki help and options for that, but how do I get the card to be detected at all? Sincerely, Karl Palsson -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJWCnR6AAoJEBmot

Re: [OpenWrt-Devel] periodic task checking for usb flash media?

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Karl Palsson wrote: > Hi, > > I've got a custom board with an onboard USB flash media > interface. It works well, I can mount and access micro SD cards > nicely, and all that basic stuff. > > However, card detection d

Re: [OpenWrt-Devel] [PATCH] libpcap: USB support by default if usbmon is enabled

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Sounds good to me, I missed this the first time I was building with usbmon :) Bjørn Mork wrote: > If building usbmon support then you'll likely want to have USB > support in libpcap as well. > > Signed-off-by: Bjørn Mork > --- > package/libs/libpc

Re: [OpenWrt-Devel] [PATCH] mac80211: restricted automatic channel selection

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Helmut Schaa wrote: > Add a new config option "channels" for mac80211 wifi devices. > It's only valid if automatic channel selection is used and > restricts the channel selection to one of the given channels. Why is auto required explicitly? Isn't th

Re: [OpenWrt-Devel] [PATCH] Wallys DR-344 support

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Shouldn't the atheros phy additions be in their own patch? It seems out of scope to just have it buried inside a "support " with no further details in your commit comment. More comments inline... Sincerely, Karl Palsson Philippe

Re: [OpenWrt-Devel] [PATCH] ar71xx: Add support for ZyXEL NBG6616.

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I might personally think it's a tedious and often confusing policy, but the current kernel policy is that the led names have the board name, like "nbg6616:green:power" rather than "zyxel:green:power" You can see this done for a lot of the other targets

[OpenWrt-Devel] uci delete doesn't match documentation

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I'm trying to work out _a_ way of ensuring that a UCI config file has a given section type with a given name. While trying to test out the various methods, I've been deleting files from /etc/config, but I was just trying "uci delete config" which is d

Re: [OpenWrt-Devel] [PATCH] lua: lnum: fix strtoul based number parsing

Petr Štetiar wrote: > From: Liangbin Lian > > Lua's LNUM patch currently doesn't parse properly certain > numbers as it's visible from the following simple tests. > Tested-by: Karl Palsson This makes some busted unit tests of ours pass for the first tim

Re: [OpenWrt-Devel] [PATCH V3 2/2] script/feeds: add a new command that allows generating a new feeds.conf

e a lot of perl for a narrow usecase. Sincerely, Karl Palsson > > Signed-off-by: John Crispin > --- > scripts/feeds | 42 ++ > 1 file changed, 42 insertions(+) > > diff --git a/scripts/feeds b/scripts/feeds > index 304ef6cb

Re: [OpenWrt-Devel] [PATCH V2 1/2] image: make the folder that gets included intot he RootFS configurable

John Crispin wrote: > This allows managing several different folder for varying env > profiles. This is neat, very cool! Thanks for this, I hadn't even thought it could be done so simply. Cheers, Karl Palsson OpenPGP-digital-signature.html Description: OpenPGP Digita

Re: [OpenWrt-Devel] [PATCH V3 2/2] script/feeds: add a new command that allows generating a new feeds.conf

John Crispin wrote: > > On 05/06/2019 12:17, Karl Palsson wrote: > > John Crispin wrote: > >> This can be used inside build setups for easy feeds.conf > >> generation. > > > > Could you give us an example of how this is actually easy, or > > wha

Re: [OpenWrt-Devel] [PATCH 1/2] toolchain: add support for custom toolchains

irectories searched for libraries > (override LDFLAGS). > Use ./DIR for directories relative to the root above. > > +config CUSTOM_TOOLCHAIN > + depends on DEVEL > + > +source "toolchain_custom/*.in" Could we add help text here, based on the comm

Re: [OpenWrt-Devel] [PATCH v2] ath79: convert devices to interrupt-driven gpio-keys

compatible = "gpio-keys-polled"; > - poll-interval = <50>; > + compatible = "gpio-keys"; > > restore { > linux,code = ; Tested-by: Karl Palsson (Only this ha

Re: [OpenWrt-Devel] [PATCH] lua: create lua symlink for host installation

How is this meant to work when you have both? David Bauer wrote: > Since the binaries for both lua as well as lua5.3 contain the > version number, invocations of the "lua" binary are failing, as > it's not created anymore for the host package. > > Fixes: fe59b46 ("lua: include version number in

  1   2   3   >