Re: [PATCH] build: Extract trusted-firmware-a.mk

2020-11-12 Thread Andre Heider
On 29/10/2020 08:53, Andre Heider wrote: Hauke, On 11/10/2020 20:41, Hauke Mehrtens wrote: From: Andre Heider The include/trusted-firmware-a.mk file is based on the include/u-boot.mk file and should be used to build a Trusted Firmware-A (TFA) which was previously named Arm trusted firmware

[PATCH] ltq-dsl-base: only lock the dsl pipe once for all stats

2020-12-03 Thread Andre Heider
Instead of locking/unlocking it for every command. Reduces the runtime for the dslstat/lucistat commands to ~66%. Before: real0m 2.66s user0m 0.90s sys 0m 1.76s After: real0m 1.76s user0m 0.63s sys 0m 1.13s Signed-off-by: Andre Heider --- .../files/lib/functions

[PATCH v2] ltq-dsl-base: only lock the dsl pipe once for all stats

2020-12-04 Thread Andre Heider
Instead of locking/unlocking it for every command. Reduces the runtime for the dslstat/lucistat commands to ~66%. Before: real0m 2.66s user0m 0.90s sys 0m 1.76s After: real0m 1.76s user0m 0.63s sys 0m 1.13s Signed-off-by: Andre Heider --- v2: bump PKG_RELEASE package

Re: [PATCH] ltq-dsl-base: only lock the dsl pipe once for all stats

2020-12-04 Thread Andre Heider
Hi, On 04/12/2020 13:03, Jo-Philipp Wich wrote: Hi, is there any reason not to use the flock style below? It should be more reliable wrt. unlocking if the script is prematurely terminated. I guess because it gets more difficult to fish out the answer for each command then (I didn't check if

Re: [PATCH] ltq-dsl-base: only lock the dsl pipe once for all stats

2020-12-04 Thread Andre Heider
On 04/12/2020 13:25, Andre Heider wrote: Hi, On 04/12/2020 13:03, Jo-Philipp Wich wrote: Hi, is there any reason not to use the flock style below? It should be more reliable wrt. unlocking if the script is prematurely terminated. I guess because it gets more difficult to fish out the answer

[PATCH v3 3/3] ltq-dsl-base: bump PKG_RELEASE

2020-12-04 Thread Andre Heider
Signed-off-by: Andre Heider --- package/network/utils/ltq-dsl-base/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/network/utils/ltq-dsl-base/Makefile b/package/network/utils/ltq-dsl-base/Makefile index e2cfc4004c..aae07bc299 100644 --- a/package/network

[PATCH v3 2/3] ltq-dsl-base: remove preformatted integer values from lucistat

2020-12-04 Thread Andre Heider
luci has been converted to use the raw values, see [0]. Remove the now unused values. [0] https://github.com/openwrt/luci/pull/4635 Signed-off-by: Andre Heider --- .../files/lib/functions/lantiq_dsl.sh | 54 --- 1 file changed, 22 insertions(+), 32 deletions(-) diff

[PATCH v3 1/3] ltq-dsl-base: only lock the dsl pipe once for all stats

2020-12-04 Thread Andre Heider
Instead of locking/unlocking it for every command. Reduces the runtime for the dslstat/lucistat commands to ~66%. Before: real0m 2.66s user0m 0.90s sys 0m 1.76s After: real0m 1.76s user0m 0.63s sys 0m 1.13s Signed-off-by: Andre Heider --- v2: bump PKG_RELEASE v3: use

[PATCH 09/13] ltq-adsl-app: use ubus to provide metrics

2020-12-11 Thread Andre Heider
luci now uses ubus directly, so remove 'lucistat'. For manual usage just print the ubus output, use luci for a pretty version. Signed-off-by: Andre Heider --- package/network/config/ltq-adsl-app/files/dsl_control | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[luci PATCH 06/13] rpcd-mod-luci: get rid of now unused getDSLStatus ubus rpc

2020-12-11 Thread Andre Heider
Good riddance. Signed-off-by: Andre Heider --- libs/rpcd-mod-luci/src/luci.c | 55 --- 1 file changed, 55 deletions(-) diff --git a/libs/rpcd-mod-luci/src/luci.c b/libs/rpcd-mod-luci/src/luci.c index 94ccdf271..abf4b9ba5 100644 --- a/libs/rpcd-mod-luci/src

[PATCH 11/13] ltq-dsl-base: bump PKG_RELEASE

2020-12-11 Thread Andre Heider
Signed-off-by: Andre Heider --- package/network/utils/ltq-dsl-base/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/network/utils/ltq-dsl-base/Makefile b/package/network/utils/ltq-dsl-base/Makefile index e2cfc4004c..aae07bc299 100644 --- a/package/network

[PATCH 0/13] add ubus support to ltq-[v|a]dsl-app

2020-12-11 Thread Andre Heider
This is to significantly speed up the generation of the metrics. The motivation comes from the fact that ~2.6s is just way too ineffcient for interval based metric collectors like prometheus or collectd. The luci status page also loads/refreshes alot faster. $ time /etc/init.d/dsl_control dslsta

[PATCH 02/13] ltq-vdsl-app: fix -Wundef warnings

2020-12-11 Thread Andre Heider
6: warning: "MEI_SUPPORT_OPTIMIZED_FW_DL" is not defined, evaluates to 0 [-Wundef] #if (MEI_SUPPORT_OPTIMIZED_FW_DL == 1) ^~~~~~~ Signed-off-by: Andre Heider --- package/network/config/ltq-vdsl-app/Makefile | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --g

[PATCH 01/13] ltq-vdsl-app: shutdown upon sigterm

2020-12-11 Thread Andre Heider
procd sends sigterm to stop daemons, hook it up. This speeds up the shutdown sequence and gets rid of the following message: daemon.info procd: Instance dsl_control::instance1 pid 15408 not stopped on SIGTERM, sending SIGKILL instead Signed-off-by: Andre Heider --- .../config/ltq-vdsl-app

[PATCH 08/13] ltq-vdsl-app: use ubus to provide metrics

2020-12-11 Thread Andre Heider
luci now uses ubus directly, so remove 'lucistat'. For manual usage just print the ubus output, use luci for a pretty version. Signed-off-by: Andre Heider --- package/network/config/ltq-vdsl-app/files/dsl_control | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH 12/13] ltq-vdsl-app: bump PKG_RELEASE

2020-12-11 Thread Andre Heider
Signed-off-by: Andre Heider --- package/network/config/ltq-vdsl-app/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/network/config/ltq-vdsl-app/Makefile b/package/network/config/ltq-vdsl-app/Makefile index 5a84ea8e7e..48aa6b70c8 100644 --- a/package/network

[PATCH 13/13] ltq-adsl-app: bump PKG_RELEASE

2020-12-11 Thread Andre Heider
Signed-off-by: Andre Heider --- package/network/config/ltq-adsl-app/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/network/config/ltq-adsl-app/Makefile b/package/network/config/ltq-adsl-app/Makefile index e03c0911a5..317f8a908a 100644 --- a/package/network

[packages PATCH 07/13] prometheus-node-exporter-lua: use the new ubus dsl metrics

2020-12-11 Thread Andre Heider
This is significantly faster. Signed-off-by: Andre Heider --- .../lib/lua/prometheus-collectors/ltq-dsl.lua | 108 -- 1 file changed, 47 insertions(+), 61 deletions(-) diff --git a/utils/prometheus-node-exporter-lua/files/usr/lib/lua/prometheus-collectors/ltq-dsl.lua b/utils

[PATCH 03/13] ltq-vdsl-app: add ubus support to get metrics

2020-12-11 Thread Andre Heider
"rx_corrupted": 27740, "rx_uncorrected_protected": 27010, "rx_retransmitted": 0, "rx_corrected": 730, "tx_retransmitted": 16222 },

[PATCH 04/13] ltq-adsl-app: add ubus support to get metrics

2020-12-11 Thread Andre Heider
As with ltq-vdsl-app, see previous commit. Signed-off-by: Andre Heider --- package/network/config/ltq-adsl-app/Makefile | 2 +- .../ltq-adsl-app/patches/300-ubus.patch | 50 +++ package/network/config/ltq-adsl-app/src | 1 + 3 files changed, 52 insertions(+), 1

[luci PATCH 05/13] luci-mod-status: use the new ubus dsl metrics

2020-12-11 Thread Andre Heider
This is significantly faster. Signed-off-by: Andre Heider --- .../resources/view/status/include/50_dsl.js | 55 +-- .../usr/share/rpcd/acl.d/luci-mod-status.json | 2 +- 2 files changed, 28 insertions(+), 29 deletions(-) diff --git a/modules/luci-mod-status/htdocs/luci

[PATCH 10/13] ltq-dsl-base: remove usused lantiq_dsl.sh

2020-12-11 Thread Andre Heider
All users have been converted to ubus. Signed-off-by: Andre Heider --- .../files/lib/functions/lantiq_dsl.sh | 749 -- 1 file changed, 749 deletions(-) delete mode 100755 package/network/utils/ltq-dsl-base/files/lib/functions/lantiq_dsl.sh diff --git a/package

Re: [PATCH] ltq-dsl-base: only lock the dsl pipe once for all stats

2020-12-11 Thread Andre Heider
On 04/12/2020 13:25, Andre Heider wrote: Hi, On 04/12/2020 13:03, Jo-Philipp Wich wrote: Hi, is there any reason not to use the flock style below? It should be more reliable wrt. unlocking if the script is prematurely terminated. I guess because it gets more difficult to fish out the answer

Re: [luci PATCH 05/13] luci-mod-status: use the new ubus dsl metrics

2020-12-11 Thread Andre Heider
On 11/12/2020 13:11, Jo-Philipp Wich wrote: Hi, This is significantly faster. great work! I like it :) Minor nitpick below. [...] -var callLuciDSLStatus = rpc.declare({ - object: 'luci-rpc', - method: 'getDSLStatus', +var call_dsl_metrics = rpc.declare({ + object: 'dsl'

Re: [PATCH 0/13] add ubus support to ltq-[v|a]dsl-app

2020-12-11 Thread Andre Heider
On 11/12/2020 13:05, Andre Heider wrote: The ltq-vdsl-app changes are only compile time tested. erm, *ltq-adsl-app* is only compile time tested. ltq-vdsl-app is what I'm using, and it works pretty well for me ;) ___ openwrt-devel mailing

Re: [PATCH 02/13] ltq-vdsl-app: fix -Wundef warnings

2020-12-11 Thread Andre Heider
On 11/12/2020 18:59, Mathias Kresin wrote: 12/11/20 1:05 PM, Andre Heider: Shut up these warnings: /usr/include/vdsl/cmv_message_format.h:33:6: warning: "MEI_SUPPORT_DEBUG_STREAMS" is not defined, evaluates to 0 [-Wundef]   #if (MEI_SUPPORT_DEBUG_ST

Re: [PATCH 02/13] ltq-vdsl-app: fix -Wundef warnings

2020-12-11 Thread Andre Heider
On 11/12/2020 19:44, Andre Heider wrote: On 11/12/2020 18:59, Mathias Kresin wrote: 12/11/20 1:05 PM, Andre Heider: Shut up these warnings: /usr/include/vdsl/cmv_message_format.h:33:6: warning: "MEI_SUPPORT_DEBUG_STREAMS" is not defined, evaluates to 0 [-Wund

[luci PATCH 05/12] rpcd-mod-luci: get rid of now unused getDSLStatus ubus rpc

2020-12-15 Thread Andre Heider
Good riddance. Signed-off-by: Andre Heider Tested-by: Martin Schiller --- libs/rpcd-mod-luci/src/luci.c | 55 --- 1 file changed, 55 deletions(-) diff --git a/libs/rpcd-mod-luci/src/luci.c b/libs/rpcd-mod-luci/src/luci.c index 94ccdf271..abf4b9ba5 100644 --- a

[PATCH v2 0/12] add ubus support to ltq-[v|a]dsl-app

2020-12-15 Thread Andre Heider
v2: - drop 0002-ltq-vdsl-app-fix-Wundef-warnings.patch - use "/dev/dsl_cpe_api" without the "0" suffix for the adsl daemon: package/kernel/lantiq/ltq-adsl/patches/100-dsl_compat.patch:+ device_create(dsl_class, NULL, MKDEV(DRV_DSL_CPE_API_DEV_MAJOR, 0), NULL, "dsl_cpe_api"); package/kernel/

[PATCH 07/12] ltq-vdsl-app: use ubus to provide metrics

2020-12-15 Thread Andre Heider
luci now uses ubus directly, so remove 'lucistat'. For manual usage just print the ubus output, use luci for a pretty version. Signed-off-by: Andre Heider Tested-by: Martin Schiller --- package/network/config/ltq-vdsl-app/files/dsl_control | 7 --- 1 file changed, 4 insert

[PATCH 08/12] ltq-adsl-app: use ubus to provide metrics

2020-12-15 Thread Andre Heider
luci now uses ubus directly, so remove 'lucistat'. For manual usage just print the ubus output, use luci for a pretty version. Signed-off-by: Andre Heider --- package/network/config/ltq-adsl-app/files/dsl_control | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH 10/12] ltq-dsl-base: bump PKG_RELEASE

2020-12-15 Thread Andre Heider
Signed-off-by: Andre Heider Tested-by: Martin Schiller --- package/network/utils/ltq-dsl-base/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/network/utils/ltq-dsl-base/Makefile b/package/network/utils/ltq-dsl-base/Makefile index e2cfc4004c..aae07bc299

[PATCH 11/12] ltq-vdsl-app: bump PKG_RELEASE

2020-12-15 Thread Andre Heider
Signed-off-by: Andre Heider --- package/network/config/ltq-vdsl-app/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/network/config/ltq-vdsl-app/Makefile b/package/network/config/ltq-vdsl-app/Makefile index 33b6ca093b..bf9287bc79 100644 --- a/package/network

[luci PATCH 04/12] luci-mod-status: use the new ubus dsl metrics

2020-12-15 Thread Andre Heider
This is significantly faster. Signed-off-by: Andre Heider Tested-by: Martin Schiller --- .../resources/view/status/include/50_dsl.js | 55 +-- .../usr/share/rpcd/acl.d/luci-mod-status.json | 2 +- 2 files changed, 28 insertions(+), 29 deletions(-) diff --git a/modules/luci

[PATCH 12/12] ltq-adsl-app: bump PKG_RELEASE

2020-12-15 Thread Andre Heider
Signed-off-by: Andre Heider --- package/network/config/ltq-adsl-app/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/network/config/ltq-adsl-app/Makefile b/package/network/config/ltq-adsl-app/Makefile index e03c0911a5..317f8a908a 100644 --- a/package/network

[packages PATCH 06/12] prometheus-node-exporter-lua: use the new ubus dsl metrics

2020-12-15 Thread Andre Heider
This is significantly faster. Signed-off-by: Andre Heider --- .../lib/lua/prometheus-collectors/ltq-dsl.lua | 108 -- 1 file changed, 47 insertions(+), 61 deletions(-) diff --git a/utils/prometheus-node-exporter-lua/files/usr/lib/lua/prometheus-collectors/ltq-dsl.lua b/utils

[PATCH 03/12] ltq-adsl-app: add ubus support to get metrics

2020-12-15 Thread Andre Heider
As with ltq-vdsl-app, see previous commit. Signed-off-by: Andre Heider --- package/network/config/ltq-adsl-app/Makefile | 2 +- .../ltq-adsl-app/patches/300-ubus.patch | 50 +++ package/network/config/ltq-adsl-app/src | 1 + 3 files changed, 52 insertions(+), 1

[PATCH 02/12] ltq-vdsl-app: add ubus support to get metrics

2020-12-15 Thread Andre Heider
"rx_corrupted": 27740, "rx_uncorrected_protected": 27010, "rx_retransmitted": 0, "rx_corrected": 730, "tx_retransmitted": 16222 }, &q

[PATCH 09/12] ltq-dsl-base: remove usused lantiq_dsl.sh

2020-12-15 Thread Andre Heider
All users have been converted to ubus. Signed-off-by: Andre Heider Tested-by: Martin Schiller --- .../files/lib/functions/lantiq_dsl.sh | 749 -- 1 file changed, 749 deletions(-) delete mode 100755 package/network/utils/ltq-dsl-base/files/lib/functions/lantiq_dsl.sh

[PATCH 01/12] ltq-vdsl-app: shutdown upon sigterm

2020-12-15 Thread Andre Heider
procd sends sigterm to stop daemons, hook it up. This speeds up the shutdown sequence and gets rid of the following message: daemon.info procd: Instance dsl_control::instance1 pid 15408 not stopped on SIGTERM, sending SIGKILL instead Signed-off-by: Andre Heider Tested-by: Martin Schiller

Re: [PATCH v2 0/12] add ubus support to ltq-[v|a]dsl-app

2021-01-09 Thread Andre Heider
Hi, (cc'ed some recent commiters for lantiq) On 15/12/2020 10:35, Andre Heider wrote: v2: - drop 0002-ltq-vdsl-app-fix-Wundef-warnings.patch - use "/dev/dsl_cpe_api" without the "0" suffix for the adsl daemon: package/kernel/lantiq/ltq-adsl/patches/100-dsl_compat

Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-10 Thread Andre Heider
On 10/01/2021 02:37, Alberto Bursi wrote: On 09/01/21 12:28, Stijn Segers wrote: Hi, Op zondag 3 januari 2021 om 23u14 schreef Sven Roederer : When saving the list of installed pkgs, also store the status of the system services. The list is created in the etc/backup folder also and formated

Re: [PATCH v2 0/12] add ubus support to ltq-[v|a]dsl-app

2021-01-14 Thread Andre Heider
Hi, On 14/01/2021 13:34, Martin Schiller wrote: On 2021-01-14 12:55, Mathias Kresin wrote: 1/13/21 3:00 PM, Martin Schiller: On 2021-01-09 09:40, Andre Heider wrote: Hi, (cc'ed some recent commiters for lantiq) On 15/12/2020 10:35, Andre Heider wrote: v2: - drop 0002-ltq-vdsl-ap

Re: [PATCH 10/12] ltq-dsl-base: bump PKG_RELEASE

2021-01-25 Thread Andre Heider
On 25/01/2021 21:22, Hauke Mehrtens wrote: On 12/15/20 10:35 AM, Andre Heider wrote: Signed-off-by: Andre Heider Tested-by: Martin Schiller ---   package/network/utils/ltq-dsl-base/Makefile | 2 +-   1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/network/utils/ltq-dsl-base

Re: [PATCH v2 0/12] add ubus support to ltq-[v|a]dsl-app

2021-01-25 Thread Andre Heider
On 25/01/2021 21:22, Hauke Mehrtens wrote: On 12/15/20 10:35 AM, Andre Heider wrote: v2: - drop 0002-ltq-vdsl-app-fix-Wundef-warnings.patch - use "/dev/dsl_cpe_api" without the "0" suffix for the adsl daemon:    package/kernel/lantiq/ltq-adsl/patches/100-dsl_compat.patc

Re: [PATCH 03/12] ltq-adsl-app: add ubus support to get metrics

2021-01-25 Thread Andre Heider
On 25/01/2021 21:13, Hauke Mehrtens wrote: On 12/15/20 10:35 AM, Andre Heider wrote: As with ltq-vdsl-app, see previous commit. Signed-off-by: Andre Heider ---   package/network/config/ltq-adsl-app/Makefile  |  2 +-   .../ltq-adsl-app/patches/300-ubus.patch   | 50

[PATCH v3 4/6] ltq-vdsl-app: use ubus to provide metrics

2021-01-26 Thread Andre Heider
luci now uses ubus directly, so remove 'lucistat'. For manual usage just print the ubus output, use luci for a pretty version. Signed-off-by: Andre Heider Tested-by: Martin Schiller --- package/network/config/ltq-vdsl-app/Makefile | 2 +- package/network/config/ltq-vdsl

[PATCH v3 5/6] ltq-adsl-app: use ubus to provide metrics

2021-01-26 Thread Andre Heider
luci now uses ubus directly, so remove 'lucistat'. For manual usage just print the ubus output, use luci for a pretty version. Signed-off-by: Andre Heider --- package/network/config/ltq-adsl-app/Makefile | 2 +- package/network/config/ltq-adsl-app/files/dsl_control | 7 --

[PATCH v3 3/6] ltq-adsl-app: add ubus support to get metrics

2021-01-26 Thread Andre Heider
As with ltq-vdsl-app, see previous commit. Signed-off-by: Andre Heider --- package/network/config/ltq-adsl-app/Makefile | 7 ++- .../ltq-adsl-app/patches/300-ubus.patch | 50 +++ 2 files changed, 56 insertions(+), 1 deletion(-) create mode 100644 package/network/config

[PATCH v3 1/6] ltq-vdsl-app: shutdown upon sigterm

2021-01-26 Thread Andre Heider
procd sends sigterm to stop daemons, hook it up. This speeds up the shutdown sequence and gets rid of the following message: daemon.info procd: Instance dsl_control::instance1 pid 15408 not stopped on SIGTERM, sending SIGKILL instead Signed-off-by: Andre Heider Tested-by: Martin Schiller

[PATCH v3 0/6] add ubus support to ltq-[v|a]dsl-app

2021-01-26 Thread Andre Heider
app changes are only compile time tested. Andre Heider (6): ltq-vdsl-app: shutdown upon sigterm ltq-vdsl-app: add ubus support to get metrics ltq-adsl-app: add ubus support to get metrics ltq-vdsl-app: use ubus to provide metrics ltq-adsl-app: use ubus to provide metrics ltq-dsl-bas

[PATCH v3 6/6] ltq-dsl-base: remove usused lantiq_dsl.sh

2021-01-26 Thread Andre Heider
All users have been converted to ubus. Signed-off-by: Andre Heider Tested-by: Martin Schiller --- package/network/utils/ltq-dsl-base/Makefile | 2 +- .../files/lib/functions/lantiq_dsl.sh | 749 -- 2 files changed, 1 insertion(+), 750 deletions(-) delete mode

[PATCH v3 2/6] ltq-vdsl-app: add ubus support to get metrics

2021-01-26 Thread Andre Heider
"rx_corrupted": 27740, "rx_uncorrected_protected": 27010, "rx_retransmitted": 0, "rx_corrected": 730, "tx_retransmitted": 16222 }, &q

Re: [PATCH v3 0/6] add ubus support to ltq-[v|a]dsl-app

2021-01-26 Thread Andre Heider
On 26/01/2021 23:02, Hauke Mehrtens wrote: On 1/26/21 9:00 AM, Andre Heider wrote: v3: - copy dsl_cpe_ubus.c from ltq-adsl-app to ltq-vdsl-app instead of using    a symlink - squash PKG_RELEASE patches - move feed patches to PRs:    https://github.com/openwrt/packages/pull/14572    https

Re: [PATCH v3 0/6] add ubus support to ltq-[v|a]dsl-app

2021-02-05 Thread Andre Heider
On 26/01/2021 23:02, Hauke Mehrtens wrote: On 1/26/21 9:00 AM, Andre Heider wrote: v3: - copy dsl_cpe_ubus.c from ltq-adsl-app to ltq-vdsl-app instead of using    a symlink - squash PKG_RELEASE patches - move feed patches to PRs:    https://github.com/openwrt/packages/pull/14572    https

[PATCH] build: prereq: drop support for Python 3.5

2021-02-15 Thread Andre Heider
Signed-off-by: Andre Heider --- include/prereq-build.mk | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/include/prereq-build.mk b/include/prereq-build.mk index f88e853b52..88064abf98 100644 --- a/include/prereq-build.mk +++ b/include/prereq-build.mk @@ -141,21

Re: [PATCH] build: prereq: drop support for Python 3.5

2021-02-16 Thread Andre Heider
Hi, On 16/02/2021 17:17, Petr Štetiar wrote: Andre Heider [2021-02-16 08:21:08]: Hi, The meson build system bumped their python requirement to 3.6 for the 0.57.0 release. This patch ensures that OpenWrt can update meson while still relying on the host python. Current buildbot images are

Re: [PATCH v2 1/1] ltq-vdsl-app: add line_state number and power_state number

2021-03-09 Thread Andre Heider
Hi Florian, On 09/03/2021 13:05, Florian Eckert wrote: With the old ubus dsl API, the numbers for the individual line_states and power_states were also returned. These were not ported to the new DSL C-API. This commit changes the following JSON output. * current JSON output for state: "state":

Re: Buildbot infrastructure upgrade

2021-03-12 Thread Andre Heider
On 13/03/2021 07:03, Petr Štetiar wrote: Petr Štetiar [2021-03-12 16:38:46]: Hi, I would like to let you know, that we've prepared upgrade of the Buildbot based infrastructure and there is a plan to make those changes alive. we've just finished the migration. Oh nice, didn't see that comi

Re: Buildbot infrastructure upgrade

2021-03-16 Thread Andre Heider
On 13/03/2021 07:16, Andre Heider wrote: On 13/03/2021 07:03, Petr Štetiar wrote: Petr Štetiar [2021-03-12 16:38:46]: Hi, I would like to let you know, that we've prepared upgrade of the Buildbot based infrastructure and there is a plan to make those changes alive. we've jus

Re: OpenWrt 21.02-rc1

2021-04-08 Thread Andre Heider
On 08/04/2021 11:14, Mauro Mozzarelli wrote: 2) dsl_control [status|lucistat] was changed with dsl reporting removed https://forum.openwrt.org/t/openwrt-21-02-dsl-control/89962/22 I understand the reason behind this change. I had to write my own command line reporting and adapt batch data colle

Re: [PATCH v3 1/1] ltq-vdsl-app: extent dsl metrics with boolean power and line states

2021-04-08 Thread Andre Heider
Hi Florian, On 06/04/2021 14:49, Florian Eckert wrote: With the old ubus dsl API, the numbers for the individual line_states and power_states were also returned. These were not ported to the new DSL C-API. This commit changes the following JSON output. Instead of outputting the "line_state" and

Re: [PATCH v5 1/1] ltq-vdsl-app: extent dsl metrics with state_num and power_state_num

2021-04-12 Thread Andre Heider
P_L3, Signed-off-by: Florian Eckert One note below, but in any case, LGTM, so: Reviewed-by: Andre Heider --- v5: After a discussion off the mailing list with Andre Heider, this is now the favored solution. All other versions have been marked in the patchwork as superseded. .../ltq-vdsl-app/sr

Re: [PATCH v5 1/1] ltq-vdsl-app: extent dsl metrics with state_num and power_state_num

2021-04-12 Thread Andre Heider
On 13/04/2021 08:28, Florian Eckert wrote:   +/* These values are exported via ubus and backwards compability + * needs to be kept! + */ +enum { +    LSTATE_MAP_UNKNOWN = 0, +    LSTATE_MAP_EXCEPTION, +    LSTATE_MAP_IDLE, +    LSTATE_MAP_SILENT, +    LSTATE_MAP_HANDSHAKE, +    LSTATE_MAP_FULL_IN

Re: [PATCH v6 1/1] ltq-vdsl-app: extent dsl metrics with state_num and power_state_num

2021-04-13 Thread Andre Heider
P_L3, Signed-off-by: Florian Eckert Reviewed-by: Andre Heider Thanks! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] lantiq DSL drivers / firmware info

2015-07-23 Thread Andre Heider
Hi Martin, On Sun, Jul 12, 2015 at 3:44 PM, Martin Blumenstingl wrote: > Since my latest patches were merged into the OpenWrt repository the > patch which updates the lantiq DSL drivers/application did not apply > anymore. > Here is the updated patch which applies against today's trunk: [0] > > R

Re: [OpenWrt-Devel] lantiq DSL drivers / firmware info

2015-07-23 Thread Andre Heider
Hi Martin, On Thu, Jul 23, 2015 at 11:51 PM, Martin Blumenstingl wrote: >> This sounds like an annex incompability? Was I wrong and there is a >> hardware difference and I cannot use the non B model with annex b? > Indeed, I have read multiple times that the DSL modem should support > all annexes

Re: [OpenWrt-Devel] lantiq DSL drivers / firmware info

2015-07-23 Thread Andre Heider
Hi Alexander, On Fri, Jul 24, 2015 at 12:03 AM, Alexander Couzens wrote: > If someone would like to search for differences on the pcb, I can make photos > of both pcbs. soldering rx, tx and gnd on a pcb for a serial connection is as far as my hardware skills go, but maybe we can figure out the

Re: [OpenWrt-Devel] [PATCH v2] lantiq: get more status information from xDSL

2015-08-03 Thread Andre Heider
Hi, On Fri, Jul 31, 2015 at 11:01 AM, feckert wrote: > + echo "dsl.latency_num_down=$sidu" > + echo "dsl.latency_num_up=$sidd" this hunk breaks the luci status/overview page, see `logread` for a syntax error message. Both values need to be "-quoted, they're whitespace

Re: [OpenWrt-Devel] lantiq DSL drivers / firmware info

2015-08-03 Thread Andre Heider
Hi all, On Fri, Jul 24, 2015 at 12:03 AM, Alexander Couzens wrote: > I've seen the same. With annex b device, same firmware, the modem syncs to > adsl, with annex a not. meanwhile, I got an annex b device, and with the same openwrt build, dsl firmware and config (sysupgrade backup) it just work

Re: [OpenWrt-Devel] [PATCH 2/8] lantiq: add dsl-vr9-firmware-xdsl

2015-11-25 Thread Andre Heider
Hi, On Tue, Nov 24, 2015 at 9:24 PM, Hauke Mehrtens wrote: > +define Package/dsl-vr9-firmware-xdsl/install > + $(INSTALL_DIR) $(1)/lib/firmware/ > + $(INSTALL_DATA) $(PKG_BUILD_DIR)/LICENSE > $(1)/lib/firmware/xcpe_574306_571801.LICENSE > + $(INSTALL_DATA) $(PKG_BUILD_DIR)/xcpe

[OpenWrt-Devel] [PATCH 1/2] lantiq: get rid of the dsl_fw mtd partition

2015-11-29 Thread Andre Heider
Now that we have redistributable vdsl/adsl firmware blobs in /lib/firmware, we can drop the dsl_fw partition and extend the firmware partition. Signed-off-by: Andre Heider --- Tested with the annex b firmware on TDW8970. target/linux/lantiq/base-files/etc/init.d/dsl_fs | 35

[OpenWrt-Devel] [PATCH 2/2] lantiq: get rid of ltq-vdsl-fw

2015-11-29 Thread Andre Heider
Because of dsl-vrx200-firmware-xdsl-* there's no need anymore to download a dsl firmware at runtime. Signed-off-by: Andre Heider --- package/kernel/lantiq/ltq-vdsl-fw/Makefile | 40 -- package/kernel/lantiq/ltq-vdsl-fw/src/LzmaDecode.c | 584 - package/kernel/l

Re: [OpenWrt-Devel] [PATCH 2/2] lantiq: get rid of ltq-vdsl-fw

2015-11-29 Thread Andre Heider
Hi, On Sun, Nov 29, 2015 at 8:14 PM, Martin Blumenstingl wrote: > I'm wondering if we should add the dsl-vrx200-firmware-xdsl-{a,b} > firmware as package to each device, depending on which firmware (Annex > A or B) the device is originally shipped with. > The question that comes up in that case i

[OpenWrt-Devel] [PATCH] lantiq: don't unnecessarily disable gcc's format-security

2015-11-30 Thread Andre Heider
ltq-adsl-mei as well as ltq-adsl build just fine with these compiler flags, there's no need to disable it. Signed-off-by: Andre Heider --- package/kernel/lantiq/ltq-adsl-mei/Makefile | 1 - package/kernel/lantiq/ltq-adsl/Makefile | 1 - 2 files changed, 2 deletions(-) diff --git a/pa

[OpenWrt-Devel] [PATCH 2/4] lantiq: base-files: drop the dsl tone settings

2015-12-02 Thread Andre Heider
Unused since r46920. Signed-off-by: Andre Heider --- target/linux/lantiq/base-files/etc/uci-defaults/02_network | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/linux/lantiq/base-files/etc/uci-defaults/02_network b/target/linux/lantiq/base-files/etc/uci-defaults

[OpenWrt-Devel] [PATCH 1/4] lantiq: debloat the ltq-vdsl-app binary

2015-12-02 Thread Andre Heider
Use the 'typical' compile configuration instead of 'full', which most notably excludes the soap support. /sbin/vdsl_cpe_control shrinks down to ~50%, from 178kb(!) to 90kb. Signed-off-by: Andre Heider --- package/network/config/ltq-vdsl-app/Makefile | 4 ++-- 1 file changed

[OpenWrt-Devel] [PATCH 3/4] lantiq: base-files: use vdsl per default

2015-12-02 Thread Andre Heider
Since r43114 adsl will be used if annex is specified, so don't. Signed-off-by: Andre Heider --- target/linux/lantiq/base-files/etc/uci-defaults/02_network | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/lantiq/base-files/etc/uci-defaults/02_network b/t

[OpenWrt-Devel] [PATCH 4/4] lantiq: fall back to a more appropriate default dsl firmware

2015-12-02 Thread Andre Heider
Signed-off-by: Andre Heider --- What I'm not sure about is annex j. Is that using the a or b firmware or will it get its own? package/network/config/ltq-vdsl-app/files/dsl_control | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) mode change 100644 => 100755 package/network/co

Re: [OpenWrt-Devel] [PATCH 2/4] lantiq: base-files: drop the dsl tone settings

2015-12-03 Thread Andre Heider
Hi, On Wed, Dec 2, 2015 at 10:07 PM, Daniel Schwierzeck wrote: > I think the removal of the tone setup in r46920 should be reverted. It > is still the only way to exactly control which pilot tones are sent by > the DSL firmware. I would not trust the default setting of the > dsl_cpe_control daemo

Re: [OpenWrt-Devel] [PATCH 4/4] lantiq: fall back to a more appropriate default dsl firmware

2015-12-03 Thread Andre Heider
Hi, On Wed, Dec 2, 2015 at 10:13 PM, Daniel Schwierzeck wrote: > Am 02.12.2015 um 21:38 schrieb Andre Heider: >> What I'm not sure about is annex j. >> Is that using the a or b firmware or will it get its own? > > Annex J is only valid with B firmware. It is only ad

Re: [OpenWrt-Devel] [PATCH 2/4] lantiq: base-files: drop the dsl tone settings

2015-12-03 Thread Andre Heider
Hi, On Thu, Dec 3, 2015 at 10:46 AM, Daniel Golle wrote: > Usually by differentiating firmware by target markets. > Ie. depending on where you buy the device, you end up with different > xDSL settings, similar to how allowed wifi channels are handled by most > vendors as well. > T-Com-land has al

Re: [OpenWrt-Devel] [PATCH] lantiq: don't unnecessarily disable gcc's format-security

2015-12-05 Thread Andre Heider
Hi, On Sat, Dec 5, 2015 at 10:38 AM, Felix Fietkau wrote: > /Users/nbd/openwrt/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xrx200/ltq-dsl-ar9/drv_dsl_cpe_api-3.24.4.4/src/common/drv_dsl_cpe_os_linux.c: > In function 'DSL_DRV_debug_printf': > /Users/nbd/openwrt/build_dir/target-mips_3

[OpenWrt-Devel] [PATCH v2] lantiq: base-files: use vdsl per default

2015-12-07 Thread Andre Heider
Since r43114 adsl will be used if annex is specified, so don't. --- v2: rebased target/linux/lantiq/base-files/etc/board.d/02_network | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/lantiq/base-files/etc/board.d/02_network b/target/linux/lantiq/base-files/etc/bo

[OpenWrt-Devel] [PATCH v2] lantiq: fall back to a more appropriate default dsl firmware

2015-12-07 Thread Andre Heider
--- v2: use annex b firmware for annex j too package/network/config/ltq-vdsl-app/files/dsl_control | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) mode change 100644 => 100755 package/network/config/ltq-vdsl-app/files/dsl_control diff --git a/package/network/config/ltq-vdsl-app/fil

Re: [OpenWrt-Devel] [PATCH v2] lantiq: fall back to a more appropriate default dsl firmware

2015-12-18 Thread Andre Heider
Hi, On Fri, Dec 11, 2015 at 10:36 AM, John Crispin wrote: >> @@ -69,11 +72,12 @@ start_service() { >> eval "xtse_adsl=\"\${xtse_adsl_$annex}\"" >> if [ "${xtse_adsl}" ]; then >> xtse=$xtse_adsl >> + [ -z "${firmware}" ] && eval >> "firmware=/lib/firmware/\${

Re: [OpenWrt-Devel] [PATCH 2/2] lantiq: get rid of ltq-vdsl-fw

2015-12-19 Thread Andre Heider
Hi again, On Fri, Dec 11, 2015 at 11:50 AM, John Crispin wrote: > had a chat with hauke. the bdiff between the A and B FW is around 64K. > the idea would be to patch dsl_control to have a mechanism similar to > the dsl_notify script. dsl_control would call the script once before fw > loading with

Re: [OpenWrt-Devel] [PATCH v2] lantiq: base-files: use vdsl per default

2015-12-21 Thread Andre Heider
Hi, sorry, missed that one since I wasn't CC'ed. On Fri, Dec 11, 2015 at 10:37 AM, John Crispin wrote: > On 07/12/2015 19:59, Andre Heider wrote: >> Since r43114 adsl will be used if annex is specified, so don't. > > if r43114 changed the default behaviour then

[OpenWrt-Devel] [PATCH] sunxi: fix build without ext4 rootfs

2018-09-24 Thread Andre Heider
The sdcard image generation uses CONFIG_TARGET_ROOTFS_PARTSIZE, which is currently bound to TARGET_ROOTFS_EXT4FS on this target. Since the rootfs is squashfs anyway, allow deselecting of the ext4fs one. Sort the target list alphabetically while here. Signed-off-by: Andre Heider --- config

Re: [OpenWrt-Devel] [PATCH] wireguard: bump to 0.0.20181006

2018-10-08 Thread Andre Heider
Hi Jason, On 06/10/2018 05:09, Jason A. Donenfeld wrote: diff --git a/package/network/services/wireguard/Makefile b/package/network/services/wireguard/Makefile index 29c7447..3544e34 100644 --- a/package/network/services/wireguard/Makefile +++ b/package/network/services/wireguard/Makefile @@ -1

[OpenWrt-Devel] [PATCH] lantiq: add integer latency stat for lantiq-dsl

2018-12-10 Thread Andre Heider
The current stats always have a 'ms' suffix, and they're used by luci. Introduce dsl.latency_[down|up] values, exported in µs without suffix. Signed-off-by: Andre Heider --- The idea is to use sane values for metrics, see https://github.com/openwrt/packages/pull/7594 .../li

Re: [OpenWrt-Devel] MIPS stack security and other problems

2018-12-18 Thread Andre Heider
On 18/12/2018 01:44, Rosen Penev wrote: On Mon, Dec 17, 2018 at 4:34 PM Rosen Penev wrote: On Mon, Dec 17, 2018 at 3:40 PM Dave Taht wrote: John Crispin writes: On 17/12/2018 23:18, Dave Taht wrote: Rosen Penev writes: On Sun, Dec 16, 2018 at 4:54 PM Dave Taht wrote: A pretty deep

[OpenWrt-Devel] [PATCH 1/2] omap: fix build without ext4 rootfs

2019-01-31 Thread Andre Heider
Same fix as 7b76219e, just for omap. Signed-off-by: Andre Heider --- config/Config-images.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/Config-images.in b/config/Config-images.in index a0c7b7a94d..bdd24ef617 100644 --- a/config/Config-images.in +++ b/config

[OpenWrt-Devel] [PATCH 2/2] uboot-omap: add 'rootwait' to the kernel cmdline

2019-01-31 Thread Andre Heider
Some SD cards take a while to get detected, fix booting of those. Signed-off-by: Andre Heider --- package/boot/uboot-omap/files/uEnv-default.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/boot/uboot-omap/files/uEnv-default.txt b/package/boot/uboot-omap/files

[OpenWrt-Devel] [PATCH 1/2] sunxi: update kernel config

2019-09-23 Thread Andre Heider
This is just a `make kernel_oldconfig` run without further changes. Signed-off-by: Andre Heider --- target/linux/sunxi/config-4.19 | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/target/linux/sunxi/config-4.19 b/target/linux/sunxi/config-4.19 index ef5e1b28d3

[OpenWrt-Devel] [PATCH 2/2] sunxi: enable audio for sun4i

2019-09-23 Thread Andre Heider
Enable SND_SUN4I_CODEC and SND_SUN4I_SPDIF. Tested on cubieboard2. Signed-off-by: Andre Heider --- target/linux/sunxi/config-4.19 | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/target/linux/sunxi/config-4.19 b/target/linux/sunxi/config-4.19 index b1a9d7342c..a95bcc9e3f

Re: [OpenWrt-Devel] [PATCH 2/2] sunxi: enable audio for sun4i

2019-09-26 Thread Andre Heider
On 26/09/2019 11:55, Yousong Zhou wrote: On Mon, 23 Sep 2019 at 22:01, Andre Heider wrote: Enable SND_SUN4I_CODEC and SND_SUN4I_SPDIF. Tested on cubieboard2. Signed-off-by: Andre Heider The module should be available as package kmod-sound-soc-sunxi. See target/linux/sunxi/modules.mk

[OpenWrt-Devel] [PATCH] build: call Host/Uninstall before wiping the host build dir

2019-09-28 Thread Andre Heider
Uninstall targets may depend on build artefacts, like `make uninstall` or `ninja uninstall`. Signed-off-by: Andre Heider --- include/host-build.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/host-build.mk b/include/host-build.mk index 827ea6bbfb..9fc14241c6

Re: [OpenWrt-Devel] [PATCH] toolchain/gcc: switch to version 8 by default

2019-10-01 Thread Andre Heider
for me, runtime tested on sunxi. Regards, Andre commit 818244878603e8cb45d06473f2a5a72c5f9254a7 Author: Andre Heider Date: Tue Oct 1 09:37:52 2019 +0200 fixup gcc8 diff --git a/config/Config-build.in b/config/Config-build.in index 9669fc86c7..872e5c12ab 100644 --- a/config/Config-build.in

Re: [OpenWrt-Devel] [PATCH] toolchain/gcc: switch to version 8 by default

2019-10-01 Thread Andre Heider
On 01/10/2019 09:45, Andre Heider wrote: Hi, On 28/09/2019 22:44, Paul Spooren wrote: Main motivation for this commit is the introduction of `-ffile-prefix-map=` which alows reproducible build path. compilation failed for me, it tried to use -iremap. Maybe you used

  1   2   3   >