Al 23/05/12 19:23, En/na Luka Perkov ha escrit:
> Other long & hard nights how John said were spent trying to make wifi
> and lan working...
At least your hard night was taken into consideration, mines were sitting in
patchwork for ~1 year, then wrongly applied and not credited.
Bye
--
Luca
__
On Wed, May 23, 2012 at 10:53:32AM +0200, John Crispin wrote:
> On 23/05/12 10:47, Conor O'Gorman wrote:
> > On Wed, 2012-05-23 at 02:34 +0200, Luka Perkov wrote:
> >> It's the most important change in this patch and reason for sending it.
> >> I dont see the need to comment every line in basic pat
On 23/05/12 10:47, Conor O'Gorman wrote:
> On Wed, 2012-05-23 at 02:34 +0200, Luka Perkov wrote:
>> It's the most important change in this patch and reason for sending it.
>> I dont see the need to comment every line in basic patch like this.
>
> Yes, you are right, it is a small change. I just th
On Wed, 2012-05-23 at 02:34 +0200, Luka Perkov wrote:
> It's the most important change in this patch and reason for sending it.
> I dont see the need to comment every line in basic patch like this.
Yes, you are right, it is a small change. I just think a title such as
"lantiq: p2601hnfx fix leds
>> I would suggest a better title and description covering all changes.
>> Only mentioning the leds in the title is insufficient.
>
> It's the most important change in this patch and reason for sending it.
> I dont see the need to comment every line in basic patch like this.
The commit message
On Wed, May 23, 2012 at 01:22:18AM +0100, Conor O'Gorman wrote:
> On Wed, 2012-05-23 at 01:10 +0200, Luka Perkov wrote:
> > Leds gpio values have changed since initial patch was contributed. I
> > have double checked and this are correct values.
> >
> > This also enables uboot_env partition.
>
>
On Wed, 2012-05-23 at 01:10 +0200, Luka Perkov wrote:
> Leds gpio values have changed since initial patch was contributed. I
> have double checked and this are correct values.
>
> This also enables uboot_env partition.
And moves the linux partition, and removes the config partition, and the
butto
Leds gpio values have changed since initial patch was contributed. I
have double checked and this are correct values.
This also enables uboot_env partition.
Signed-off-by: Luka Perkov
---
.../arch/mips/lantiq/xway/mach-p2601hnfx.c | 61 +++-
1 file changed, 35 inserti
