>> I would suggest a better title and description covering all changes. >> Only mentioning the leds in the title is insufficient. > > It's the most important change in this patch and reason for sending it. > I dont see the need to comment every line in basic patch like this.
The commit message should reflect what is inside the patch. However, owrt is not as strict "yet" as upstream is, so the patch is fine and i will update the commit message when i import the patch. Thanks, John _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
