On Wed, 2012-05-23 at 02:34 +0200, Luka Perkov wrote: > It's the most important change in this patch and reason for sending it. > I dont see the need to comment every line in basic patch like this.
Yes, you are right, it is a small change. I just think a title such as "lantiq: p2601hnfx fix leds, partitions, buttons" without even a description, would have been better. I guess the patch guideline 'one fix per patch' made me comment, and the better option was to mention each trivial fix, rather than suggest 3 trivial patches. Thanks, Conor _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
