On 23/05/12 10:47, Conor O'Gorman wrote: > On Wed, 2012-05-23 at 02:34 +0200, Luka Perkov wrote: >> It's the most important change in this patch and reason for sending it. >> I dont see the need to comment every line in basic patch like this. > > Yes, you are right, it is a small change. I just think a title such as > > "lantiq: p2601hnfx fix leds, partitions, buttons" > > without even a description, would have been better. I guess the patch > guideline 'one fix per patch' made me comment, and the better option was > to mention each trivial fix, rather than suggest 3 trivial patches. >
i agree. and the next patch should try and follow those guidelines. The thing is i know this patch was the result of 3 very long and hard nights for a few people and i can imagine that they were happy to get it out the door :-) however i will use the subject proposed above when i push it and add a small description text. I think that would be the ideal route to resolve this and make every one happy... Thanks, John _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
