Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

On 7 April 2011 12:04, Peter Lebbing wrote: > Any chance that you can get a datasheet for the FC chip? It would help > implementing FC functionality a lot. I can ask them, but I doubt it. For what they care, I am not much more than a random guy on the internet ;-) Also since I don't have access

Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

Hi Jonas, On 06/04/11 13:34, Jonas Gorski wrote: > On 5 April 2011 14:00, Jonas Gorski wrote: >> Probably you should dump the (default) register values of the FC and the M >> and compare them and try to find a difference (best if it's some RO >> register). > > Good candidates are the Queue Weigh

Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

On 5 April 2011 14:00, Jonas Gorski wrote: > I talked with the Lantiq guys, and they said there should be > differences in the default reset values of some registers, so only > indirect hints. Probably you should dump the (default) register values > of the FC and the M and compare them and try to

Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

Hi, On 3 April 2011 15:28, Peter Lebbing wrote: > Yeah, that's the whole problem. If I look at the datasheets I can find about > the F model, it would seem the chip identification will not match at all. In > practice, it turns out people with a chip labeled as FC have a register set > very simila

Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

Hi Jonas, yes, we are trying to find out the needed info. i will start by setting up a testbed today for the "I" version to get to know the codebase and then move on to find out the info we are missing. John > @John: Since the ADM6996FC and -M are still marketed by Lantiq, > perhaps you can she

Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

On 3 April 2011 15:28, Peter Lebbing wrote: > Hi, > > On 03/04/11 14:37, Jonas Gorski wrote: >> Looking at the datasheet, the chip seems to have Chip ID registers at >> A0/A1 (p. 161). You can try to read them in the adm6996_probe and use >> them to verify the chip is an ADM6996M (or do chip ident

Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

Hi, On 03/04/11 14:37, Jonas Gorski wrote: > Looking at the datasheet, the chip seems to have Chip ID registers at > A0/A1 (p. 161). You can try to read them in the adm6996_probe and use > them to verify the chip is an ADM6996M (or do chip identification > based on them). At least the ADM6996F dat

Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

On 3 April 2011 14:16, Peter Lebbing wrote: > This driver implements support for 802.1Q VLANs. It is written for the > ADM6996M switch chip, but there are currently problems with the chip > detection. It also triggers on other ADM6996 models, and before this patch > can be committed, it needs to b

Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

> could oyu resent the all in one patch to the list so patchwork grabs the > full version, currently only the fix is listed in patchwork A new version of the patch. Please note it is a patch on latest backfire. The patch should apply to trunk, but the directory generic-2.6 was renamed to generic!

Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

On 2011-02-19 1:49 PM, Peter Lebbing wrote: > Hello Felix, > > You wrote the adm6996.c driver. The driver "triggered" on the Chip Identifier > of > my ADM6996M chip, so I wrote VLAN support for that chip, supposing that all > chips identified by that same Chip Identifier would probably be similar

Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

Hello Felix, You wrote the adm6996.c driver. The driver "triggered" on the Chip Identifier of my ADM6996M chip, so I wrote VLAN support for that chip, supposing that all chips identified by that same Chip Identifier would probably be similar. The detection code masked the "Version Number" and onl

Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

I suppose we need to figure out this chip identification/detection before the patch can be accepted. So, David: - Have you tried using the driver, the VLANs? Did it happen to work, did it fail catastrophically, dit it just do nothing? :) - Could you perhaps compile the ADM6996 driver with #defin

Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

On 12/01/11 13:43, David Goodenough wrote: > On Wednesday 12 January 2011, Peter Lebbing wrote: >> On 12/01/11 13:19, David Goodenough wrote: >>> Given that they are do different, perhaps your driver should be named >>> as the adm6996m.c rather than just adm6996.c, and then we can have >>> an adm69

Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

On Wednesday 12 January 2011, Peter Lebbing wrote: > On 12/01/11 13:19, David Goodenough wrote: > > The odd thing is that the current code (before your patch) detects my > > ADM6996FC. It does not do much with it, but it detects it. > > That is very odd indeed. I did not change the detection. Are

Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

On 12/01/11 13:19, David Goodenough wrote: > The odd thing is that the current code (before your patch) detects my > ADM6996FC. It does not do much with it, but it detects it. That is very odd indeed. I did not change the detection. Are you sure it is my patch that changes the behaviour, and not

Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

On Wednesday 12 January 2011, Peter Lebbing wrote: > On 11/01/11 14:30, David Goodenough wrote: > > OK, so does your code check to see if this is an M, or do we need to add > > that? Do you think we should have two different drivers, one for the M > > the other for the F and L, or can we interweave

Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

On 11/01/11 14:30, David Goodenough wrote: > OK, so does your code check to see if this is an M, or do we need to add that? > Do you think we should have two different drivers, one for the M the other for > the F and L, or can we interweave the code? The detection and initialization part of the dr

Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

On Tuesday 11 January 2011, Peter Lebbing wrote: > On 11/01/11 12:49, Peter Lebbing wrote: > > The ADM6996F and ADM6996L are accessed through an SPI interface, it > > seems, the same bus where the serial config EEPROM is located. I'm not > > 100% sure of the protocol used to access the switch chip

Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

On 11/01/11 12:49, Peter Lebbing wrote: > The ADM6996F and ADM6996L are accessed through an SPI interface, it seems, the > same bus where the serial config EEPROM is located. I'm not 100% sure of the > protocol used to access the switch chip from the CPU, the datasheet isn't very > definitive on th

Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

On 10/01/11 20:32, David Goodenough wrote: > Perhaps I should restate my question, that is unclear. Are there any register > values or other way programatically to tell which of the ADM6996 chips is > being used as the PHY on a particular system? ADM6996F and ADM6996M are very different. The M is

Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

On Monday 10 January 2011, David Goodenough wrote: > On Monday 10 January 2011, Peter Lebbing wrote: > > On -10/01/37 20:59, David Goodenough wrote: > > >> > >> pd f> > > > > > > Can I ask where you got this datasheet. The o

Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

On Monday 10 January 2011, Peter Lebbing wrote: > On -10/01/37 20:59, David Goodenough wrote: > >> >> f> > > > > Can I ask where you got this datasheet. The only ones I have managed to > > find are only viewable through a

Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

Peter Lebbing digitalbrains.com> writes: > It turned up in a web search. Don't know the particulars anymore. But a trick > I > learned from a friend is to google for " vcc", without quotes. > Because datasheets often mention a supply voltage with the symbol vcc. It > often > helps to narrow dow

Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

On -10/01/37 20:59, David Goodenough wrote: >> > > Can I ask where you got this datasheet. The only ones I have managed to find > are only viewable through a dreadful web interface. In particular do you > know if there is

Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

On Sunday 09 January 2011, Peter Lebbing wrote: > Hello, > > On 09/01/11 07:41, Scott Nicholas wrote: > > My machine also uses an ADM6996, but there are at least two very > > different ones. 6996F and 6996M are two which I came across. Can you > > tell me which this is for? > > Silly of me to for

Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

Oops. There was a mutex handling bug in the code I submitted. I tested all kinds of things, but forgot to enable VLAN, disable it again and /enable it/ /again/. The final step, that I forgot, was of course where it went wrong. Disabling the VLAN never released the mutex. Attached patch should fix

Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

Hello, On 09/01/11 07:41, Scott Nicholas wrote: > My machine also uses an ADM6996, but there are at least two very > different ones. 6996F and 6996M are two which I came across. Can you > tell me which this is for? Silly of me to forget to mention this. The datasheet I consulted was for the ADM69

Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

2011/1/9 Scott Nicholas > On Sun, Jan 9, 2011 at 2:54 AM, Peter Lebbing > wrote: > > Hello developers, > > > > I have written a switch driver for the Infineon ADM6996 switch chip, > which in my > > case is in a D-Link DSL-G624T modem/router. It implements 802.1Q based > VLAN > > support, via the

Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

Excellent. This chip is used on the Ubiquity Routerstation (not the Pro) and I have some of those and I will test this code. As has been pointed out elsewhere there are several variants on the AMD6996, the Routerstation uses the F variant. David On Saturday 08 January 2011, Peter Lebbing wrote:

Re: [OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

Hello, On Sun, Jan 9, 2011 at 2:54 AM, Peter Lebbing wrote: > Hello developers, > > I have written a switch driver for the Infineon ADM6996 switch chip, which in > my > case is in a D-Link DSL-G624T modem/router. It implements 802.1Q based VLAN > support, via the swconfig interface. Other fancy

[OpenWrt-Devel] [PATCH] 802.1Q VLAN support for Infineon ADM6996 switch chip

Hello developers, I have written a switch driver for the Infineon ADM6996 switch chip, which in my case is in a D-Link DSL-G624T modem/router. It implements 802.1Q based VLAN support, via the swconfig interface. Other fancy features of the switch chip are not (yet) implemented. Because the datash