On 12/01/11 13:43, David Goodenough wrote:
> On Wednesday 12 January 2011, Peter Lebbing wrote:
>> On 12/01/11 13:19, David Goodenough wrote:
>>> Given that they are do different, perhaps your driver should be named
>>> as the adm6996m.c rather than just adm6996.c, and then we can have
>>> an adm6996fl.c for the F, FC and L versions.
>>
>> I agree. But the detection code of adm6996.c (named as such) looks for Chip
>> Identification registers that *are* mentioned in the datasheet for the M
>> model, and very much *are not* in the datasheet for the F and L models.
>> And I didn't write the detection nor name the file.
>>
>> Are you sure it is adm6996.c that detects your FC? It seems so odd to me,
>> looking at the datasheets. Perhaps you could add some debug print
>> statements to adm6996.c in the chip detection code to see what it reads
>> and writes from the chip.
> Well adm6996.c is the only code that I could find that puts out a syslog entry
> saying it has found an ADM6996 PHY.
Yeah, and I see the Kconfig says:
config ADM6996_PHY
tristate "Driver for ADM6996 switches"
---help---
Currently supports the ADM6996F switch
I'm thinking there's something odd going on here with regard to datasheets.
I added Felix Fietkau to the recipients of this message, since he wrote the
detection code in adm6996.c.
Felix, if I look at the datasheet for the ADM6996F [1], in particular the
register descriptions, I don't see the code in adm6996_fixup() matching on that
chip. Instead, it matches the datasheet for the ADM6996M/MX [2], with the Chip
ID registers at register addresses 0xA0 and 0xA1. I used [2] to implement the
VLAN stuff and it works on the ADM6996M. I don't have an F model.
Still, the Kconfig says adm6996.c works for the F model. I'm thinking I have the
wrong datasheet for the F model. Could you give a pointer to the documentation
you used, or possibly help out otherwise in this confusion?
Peter.
[1]
<http://www.datasheetcatalog.org/datasheets2/21/2150254_1.pdf>
[2]
<http://media.digikey.com/PDF/Data%20Sheets/Infineon%20PDFs/Samurai%206M,MX,%20ADM6996M,MX.pdf>
--
I use the GNU Privacy Guard (GnuPG) in combination with Enigmail.
You can send me encrypted mail if you want some privacy.
My key is available at http://wwwhome.cs.utwente.nl/~lebbing/pubkey.txt
(new, larger key created on Nov 12, 2009)
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
