On Wednesday 12 January 2011, Peter Lebbing wrote: > On 11/01/11 14:30, David Goodenough wrote: > > OK, so does your code check to see if this is an M, or do we need to add > > that? Do you think we should have two different drivers, one for the M > > the other for the F and L, or can we interweave the code? > > The detection and initialization part of the driver was already written, by > Felix Fietkau. Since the M is a completely different chip than the F and L > models, it only detects the M model, using the Chip Identification > registers. > > I don't see any reason to interweave code for the M and the F. I see plenty > of reason not to. They are wholly different. They deserve spearate > drivers. Like I said, seems pretty much the only thing they have in common > is part of the name of the chip. > > Peter. The odd thing is that the current code (before your patch) detects my ADM6996FC. It does not do much with it, but it detects it.
Given that they are do different, perhaps your driver should be named as the adm6996m.c rather than just adm6996.c, and then we can have an adm6996fl.c for the F, FC and L versions. David _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
