[Openvpn-devel] [L] Change in openvpn[master]: dns: support running up/down command with privsep

2025-05-13 Thread d12fk (Code Review)
Attention is currently required from: MaxF, cron2, d12fk, flichtenheld, plaisthos. Hello MaxF, cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/839?usp=email to look at the new patch set (#25). The following approvals g

[Openvpn-devel] [L] Change in openvpn[master]: dns: support running up/down command with privsep

2025-05-13 Thread cron2 (Code Review)
Attention is currently required from: MaxF, d12fk, flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/839?usp=email ) Change subject: dns: support running up/down command with privsep

[Openvpn-devel] [PATCH v4] win: remove Wintun support

2025-05-13 Thread Gert Doering
From: Lev Stipakov Since DCO supports modern ciphers and server mode, there is no reason to support Wintun anymore. This also removes --windows-driver option support. The default driver is DCO, as it has been since 2.6. If for some reasons one doesn't want to use it, --disable-dco multiplatform

[Openvpn-devel] [L] Change in openvpn[master]: win: remove Wintun support

2025-05-13 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1021?usp=email ) Change subject: win: remove Wintun support .. Patch Set 4

[Openvpn-devel] [L] Change in openvpn[master]: win: remove Wintun support

2025-05-13 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1021?usp=email ) Change subject: win: remove Wintun support .. Patch Set 2

[Openvpn-devel] [L] Change in openvpn[master]: win: remove Wintun support

2025-05-13 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1021?usp=email ) Change subject: win: remove Wintun support .. Patch Set 2

[Openvpn-devel] [L] Change in openvpn[master]: win: remove Wintun support

2025-05-13 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1021?usp=email ) Change subject: win: remove Wintun support .. Patch Set 3

[Openvpn-devel] [PATCH v3] win: remove Wintun support

2025-05-13 Thread Gert Doering
From: Lev Stipakov Since DCO supports modern ciphers and server mode, there is no reason to support Wintun anymore. This also removes --windows-driver option support. The default driver is DCO, as it has been since 2.6. If for some reasons one doesn't want to use it, --disable-dco multiplatform

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-05-13 Thread cron2 (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email ) Change subject: dns: apply settings via script on unixoid systems ..

[Openvpn-devel] [PATCH v5] win: remove Wintun support

2025-05-13 Thread Gert Doering
From: Lev Stipakov Since DCO supports modern ciphers and server mode, there is no reason to support Wintun anymore. This also removes --windows-driver option support. The default driver is DCO, as it has been since 2.6. If for some reasons one doesn't want to use it, --disable-dco multiplatform

[Openvpn-devel] [L] Change in openvpn[master]: dns: support running up/down command with privsep

2025-05-13 Thread d12fk (Code Review)
Attention is currently required from: MaxF, d12fk, flichtenheld, plaisthos. Hello MaxF, cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/839?usp=email to look at the new patch set (#24). The change is no longer submittab

[Openvpn-devel] [PATCH applied] Re: win: remove Wintun support

2025-05-13 Thread Gert Doering
The patch looks big, and we needed a few tries due to conflicts with the commit before that also changed message types *and* introduced a WINTUN references... sorry for the noise. Under the hood, the patch is quit simple, just taking away special case branches and code, and I like that a lot :-)

[Openvpn-devel] [L] Change in openvpn[master]: win: remove Wintun support

2025-05-13 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1021?usp=email ) Change subject: win: remove Wintun support .. Patch Set 5

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-05-13 Thread d12fk (Code Review)
Attention is currently required from: cron2, d12fk, flichtenheld, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email to look at the new patch set (#24). The following approvals got outdated a

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-05-13 Thread cron2 (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email ) Change subject: dns: apply settings via script on unixoid systems ..