Attention is currently required from: flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1021?usp=email )
Change subject: win: remove Wintun support ...................................................................... Patch Set 2: Code-Review+1 (4 comments) Patchset: PS2: I like this - so much code and special cases going out :-) - one comment, two questions remain File include/openvpn-msg.h: http://gerrit.openvpn.net/c/openvpn/+/1021/comment/6f74688f_234eb585 : PS2, Line 47: msg_register_ring_buffers, I am a bit worried about taking out message number enums, leading to testing challenges when having openvpn.exe talking to an iservice that is from a different build version (this might not affect anyone but me, but I usually just build an openvpn.exe and use "the rest" from a regular .msi install) File src/openvpn/forward.h: http://gerrit.openvpn.net/c/openvpn/+/1021/comment/1d13e680_6724da03 : PS2, Line 406: } is that related to wintun? ("it does not say so, and I'm not aware of the origins of this code") File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/1021/comment/bd5e03db_47c6ab5d : PS2, Line 2230: } this is similar to the thing in `forward.h` - is this related to wintun particulars, or "windows read/write" in general? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1021?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I43ec390040bffeec05270271ea7fb54fb219c536 Gerrit-Change-Number: 1021 Gerrit-PatchSet: 2 Gerrit-Owner: stipa <lstipa...@gmail.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Tue, 13 May 2025 13:40:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
