Attention is currently required from: d12fk, flichtenheld, plaisthos.

cron2 has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/838?usp=email )

Change subject: dns: apply settings via script on unixoid systems
......................................................................


Patch Set 24: Code-Review-1

(3 comments)

Patchset:

PS22:
> What about incoming dhcp-options?  These still do not make it into a 
> `--dns-updown` call - having th […]
Clarified that on IRC: internal "decoupling of what-goes-in from what-goes-out" 
happens in gerrit#904.


Patchset:

PS24:
getting really close :-) - OpenBSD and OpenSolaris tested, both *work*, but 
have the annoying habit of leaving an extra blank line at the top of the 
restored resolv.conf (accumulating).  So one `\n` needs to go.


File distro/dns-scripts/resolvconf_file-dns-updown.sh:

http://gerrit.openvpn.net/c/openvpn/+/838/comment/438f64f9_6cfc18d5 :
PS22, Line 85:
> Still does not work, but it's way more interesting now. […]
We are getting very close... but... the concatenation part "new text plus 
existing config" is adding a newline, which leads to the resulting file growing 
an extra newline for each openvpn call

```
obsd75$ cat /etc/resolv.conf
### openvpn tun1 begin ###
nameserver 10.194.0.1
nameserver fd00:abcd:194::1
### openvpn tun1 end ###


lookup file bind
nameserver 195.30.0.2
nameserver 195.30.0.1
nameserver 2001:608::2
```

... this file started out with no empty lines...



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ifbe4ffb44d3bfcaa50adb38cacb3436fcdc71b10
Gerrit-Change-Number: 838
Gerrit-PatchSet: 24
Gerrit-Owner: d12fk <he...@openvpn.net>
Gerrit-Reviewer: cron2 <g...@greenie.muc.de>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Attention: d12fk <he...@openvpn.net>
Gerrit-Comment-Date: Tue, 13 May 2025 17:13:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: cron2 <g...@greenie.muc.de>
Comment-In-Reply-To: d12fk <he...@openvpn.net>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to