[Openvpn-devel] [S] Change in openvpn[master]: t_client.sh: conditionally skip ifconfig+route check

Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/768?usp=email to review the following change. Change subject: t_client.sh: conditionally skip ifconfig+route c

[Openvpn-devel] [M] Change in openvpn[master]: pass link_socket object to i/o functions

ordex has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/431?usp=email ) Change subject: pass link_socket object to i/o functions .. Abandoned -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/431?usp=emai

[Openvpn-devel] [L] Change in openvpn[master]: io_work: convert shift argument to uintptr_t

ordex has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/432?usp=email ) Change subject: io_work: convert shift argument to uintptr_t .. Abandoned -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/432?usp=

[Openvpn-devel] [XL] Change in openvpn[master]: multiproto: move generic event handling code in dedicated files

ordex has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/441?usp=email ) Change subject: multiproto: move generic event handling code in dedicated files .. Abandoned -- To view, visit http://gerrit.openvpn.net/c

[Openvpn-devel] [S] Change in openvpn[master]: if a local IPv6 address is provided, socket must be v6-only

ordex has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/435?usp=email ) Change subject: if a local IPv6 address is provided, socket must be v6-only .. Abandoned -- To view, visit http://gerrit.openvpn.net/c/ope

[Openvpn-devel] [M] Change in openvpn[master]: allow user to specify 'local' multiple times in config files

Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/436?usp=email ) Change subject: allow user to specify 'local' multiple times in config files ..

[Openvpn-devel] [S] Change in openvpn[master]: io_work: pass event_arg object to event handler in case of socket event

ordex has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/433?usp=email ) Change subject: io_work: pass event_arg object to event handler in case of socket event .. Abandoned -- To view, visit http://gerrit.open

[Openvpn-devel] [S] Change in openvpn[master]: override ai_family if 'local' numeric address was specified

ordex has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/437?usp=email ) Change subject: override ai_family if 'local' numeric address was specified .. Abandoned -- To view, visit http://gerrit.openvpn.net/c/ope

[Openvpn-devel] [L] Change in openvpn[master]: Bind to multiple ipv4/ipv6 addresses

ordex has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/438?usp=email ) Change subject: Bind to multiple ipv4/ipv6 addresses .. Abandoned -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/438?usp=email To

[Openvpn-devel] [M] Change in openvpn[master]: event/multi: add event_arg object to make event handling more generic

ordex has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/430?usp=email ) Change subject: event/multi: add event_arg object to make event handling more generic .. Abandoned -- To view, visit http://gerrit.openvp

[Openvpn-devel] [L] Change in openvpn[master]: allow tcp/udp server to listen on multiple ports at the same time

Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/434?usp=email ) Change subject: allow tcp/udp server to listen on multiple ports at the same time

[Openvpn-devel] [L] Change in openvpn[master]: Using the same wait function for both TCP and UDP

ordex has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/440?usp=email ) Change subject: Using the same wait function for both TCP and UDP .. Abandoned -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/440

[Openvpn-devel] [PATCH applied] Re: Change dev null to be a driver type instead of a special mode of tun/tap

This is just basic refactoring, making future work on special-case hacks like "--dev null" or "af_unix" more streamlined. No functional change expected or seen. The change to tun.c looks huge but is mostly re-indenting after getting rid of the DEV_TYPE_NULL condition (-> git show -w) in open_tun_

[Openvpn-devel] [M] Change in openvpn[master]: Change dev null to be a driver type instead of a special mode of tun/tap

cron2 has uploaded a new patch set (#12) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/748?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Change dev null to be a driver type instead of a special

[Openvpn-devel] [M] Change in openvpn[master]: Change dev null to be a driver type instead of a special mode of tun/tap

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/748?usp=email ) Change subject: Change dev null to be a driver type instead of a special mode of tun/tap .. Change dev null to be a driver type instead of

[Openvpn-devel] [PATCH applied] Re: Use print_tun_backend_driver instead of custom code to print type

Straight forward code simplification and generalization. Your patch has been applied to the master branch. commit 193b4f9dd0b09379c0f8f2be0613a1405bbdac8a Author: Arne Schwabe Date: Tue Sep 24 14:55:13 2024 +0200 Use print_tun_backend_driver instead of custom code to print type Sign

[Openvpn-devel] [S] Change in openvpn[master]: Use print_tun_backend_driver instead of custom code to print type

cron2 has uploaded a new patch set (#12) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/749?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Use print_tun_backend_driver instead of custom code to pr

[Openvpn-devel] [S] Change in openvpn[master]: Use print_tun_backend_driver instead of custom code to print type

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/749?usp=email ) Change subject: Use print_tun_backend_driver instead of custom code to print type .. Use print_tun_backend_driver instead of custom code t

[Openvpn-devel] [PATCH v11] Automatically enable ifconfig-exec/route-exec behaviour for afunix tun/tap

From: Arne Schwabe Change-Id: I0a2957699757665d70514ba7cafe833443018ad6 Signed-off-by: Arne Schwabe Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/750 Thi

[Openvpn-devel] [L] Change in openvpn[master]: Introduce DRIVER_AFUNIX backend for use with lwipovpn

Attention is currently required from: cron2, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/747?usp=email ) Change subject: Introduce DRIVER_AFUNIX backend for use with lwipovpn .

[Openvpn-devel] [L] Change in openvpn[master]: Introduce DRIVER_AFUNIX backend for use with lwipovpn

Attention is currently required from: cron2, flichtenheld. Hello cron2, flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/747?usp=email to look at the new patch set (#11). The following approvals got outdated and were removed: Code-Review-

[Openvpn-devel] [M] Change in openvpn[master]: Change dev null to be a driver type instead of a special mode of tun/tap

Attention is currently required from: cron2, flichtenheld. Hello cron2, flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/748?usp=email to look at the new patch set (#11). The following approvals got outdated and were removed: Code-Review-

[Openvpn-devel] [S] Change in openvpn[master]: Automatically enable ifconfig-exec/route-exec behaviour for afunix tu...

Attention is currently required from: cron2, flichtenheld, plaisthos. Hello cron2, flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/750?usp=email to look at the new patch set (#11). The following approvals got outdated and were removed: C

[Openvpn-devel] [S] Change in openvpn[master]: WIP print child exit code

Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/767?usp=email to review the following change. Change subject: WIP print child exit code

[Openvpn-devel] [S] Change in openvpn[master]: Use print_tun_backend_driver instead of custom code to print type

Attention is currently required from: flichtenheld, plaisthos. Hello cron2, flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/749?usp=email to look at the new patch set (#11). The change is no longer submittable: checks~ChecksSubmitRule is

[Openvpn-devel] [L] Change in openvpn[master]: Introduce DRIVER_AFUNIX backend for use with lwipovpn

Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/747?usp=email ) Change subject: Introduce DRIVER_AFUNIX backend for use with lwipovpn .

[Openvpn-devel] [PATCH v11] Introduce DRIVER_AFUNIX backend for use with lwipovpn

From: Arne Schwabe lwipovpn is a using lwip TCP/IP implementation with an AF_UNIX implementation to emulate a tun/tap device without messing with the TCP/IP stack of the host. For more information about lwipovpn see https://github.com/OpenVPN/lwipovpn Change-Id: I65099ef00822d08fd3f5480c80892f3

[Openvpn-devel] [L] Change in openvpn[master]: Remove support for compression on send

Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/755?usp=email to look at the new patch set (#4). Change subject: Remove support for compression on send

[Openvpn-devel] [PATCH applied] Re: Introduce DRIVER_AFUNIX backend for use with lwipovpn

This patch "in itself" is not that complex, but the implications on testing ("run server and client on the same machine, do a full 'ping' or even 'http' through the tunnel without namespace/VRF/... support") are very nice :-) Stared-at-code, fed to GHA and local test builds, and ran one of my t_c

[Openvpn-devel] [L] Change in openvpn[master]: Introduce DRIVER_AFUNIX backend for use with lwipovpn

cron2 has uploaded a new patch set (#12) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/747?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Introduce DRIVER_AFUNIX backend for use with lwipovpn ...

[Openvpn-devel] [L] Change in openvpn[master]: Introduce DRIVER_AFUNIX backend for use with lwipovpn

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/747?usp=email ) Change subject: Introduce DRIVER_AFUNIX backend for use with lwipovpn .. Introduce DRIVER_AFUNIX backend for use with lwipovpn lwipovpn is

[Openvpn-devel] [PATCH v11] Change dev null to be a driver type instead of a special mode of tun/tap

From: Arne Schwabe Change-Id: I5987ebb7c38ab176eed7efc004ea54f606a77a12 Signed-off-by: Arne Schwabe Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/748 Thi

[Openvpn-devel] [M] Change in openvpn[master]: Change dev null to be a driver type instead of a special mode of tun/tap

Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/748?usp=email ) Change subject: Change dev null to be a driver type instead of a special mode of tun/tap .

[Openvpn-devel] [PATCH v11] Use print_tun_backend_driver instead of custom code to print type

From: Arne Schwabe Also show the device type that we opened always instead of certain conditions only. Change-Id: Ib8f12516dbe294e21d3fed77478fb7660d4600c1 Signed-off-by: Arne Schwabe Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I reque

[Openvpn-devel] [S] Change in openvpn[master]: Automatically enable ifconfig-exec/route-exec behaviour for afunix tu...

Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/750?usp=email ) Change subject: Automatically enable ifconfig-exec/route-exec behaviour for afunix tun/tap ...

[Openvpn-devel] [L] Change in openvpn[master]: Introduce DRIVER_AFUNIX backend for use with lwipovpn

Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/747?usp=email ) Change subject: Introduce DRIVER_AFUNIX backend for use with lwipovpn .

[Openvpn-devel] [PATCH] Configurable installation directories

Hi there! Continuing the packaging of the latest OpenVPN-linux for NixOS, I would like to propose the following addition to the build system. What it does is it allows you to customize the installation paths for DBus and systemd services and adds the option to disable the generation of `openvpn3_s

[Openvpn-devel] [S] Change in openvpn[master]: Automatically enable ifconfig-exec/route-exec behaviour for afunix tu...

cron2 has uploaded a new patch set (#12) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/750?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Automatically enable ifconfig-exec/route-exec behaviour f

[Openvpn-devel] [PATCH applied] Re: Automatically enable ifconfig-exec/route-exec behaviour for afunix tun/tap

This is basically just a convenience, to avoid having to explicitly add --ifconfig-noexec --route-noexec to the options whenever using --dev null or --dev-node af_unix: ("because there is no device to be configured"), and as such does not change anything for all other cases. Your patch has been ap

[Openvpn-devel] [S] Change in openvpn[master]: Automatically enable ifconfig-exec/route-exec behaviour for afunix tu...

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/750?usp=email ) Change subject: Automatically enable ifconfig-exec/route-exec behaviour for afunix tun/tap .. Automatically enable ifconfig-exec/route-exe

[Openvpn-devel] [S] Change in openvpn[master]: Automatically enable --compress migrate on the server

Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/756?usp=email ) Change subject: Automatically enable --compress migrate on the server ..

[Openvpn-devel] [M] Change in openvpn[master]: mroute: properly print protocol at the end of the string

ordex has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/439?usp=email ) Change subject: mroute: properly print protocol at the end of the string .. Abandoned -- To view, visit http://gerrit.openvpn.net/c/openvp

[Openvpn-devel] [PATCH v2] Ensure that the AF_UNIX socket pair has at least 65k of buffer space

From: Arne Schwabe Without this change, pinging a lwipovpn client with something like a 3000 byte payload on macOS often fails as the default buffer sizes on macOS are 2048 for send and 4096 for receive. Change-Id: Ice015df81543c01094479929f0cb3075ca4f3813 Signed-off-by: Arne Schwabe Acked-by:

[Openvpn-devel] [S] Change in openvpn[master]: Ensure that the AF_UNIX socket pair has at least 65k of buffer space

Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/754?usp=email ) Change subject: Ensure that the AF_UNIX socket pair has at least 65k of buffer space .