Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/756?usp=email )
Change subject: Automatically enable --compress migrate on the server ...................................................................... Patch Set 4: (1 comment) File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/756/comment/834676ef_0db434b3 : PS4, Line 3456: if (options->comp.alg == COMP_ALG_LZO || options->comp.alg == COMP_ALG_LZO_NO) I think you need to check for && !options->comp.flag & COMP_F_SWAP for COMP_ALG_LZO because otherwise we also enable this for copress lzo. Although those configs that have compress lzo will also have pushable ciphers, so I don't think there isa config that will break. But I would say that is the same as compress lz4 enabling compress migrate. btw. instead of introducing COMP_ALG_LZO_NO here you could test for (options->comp.alg == COMP_ALG_STUB && !options->comp.flag & COMP_F_SWAP) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/756?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I00209b880cfcedd93e28f97fc3941d8b85e095f3 Gerrit-Change-Number: 756 Gerrit-PatchSet: 4 Gerrit-Owner: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Tue, 24 Sep 2024 15:07:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
