Attention is currently required from: flichtenheld, plaisthos.
ralf_lici has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/736?usp=email )
Change subject: Minor fix on ifconfig parameter warning
..
Pa
Acked-by: Gert Doering
Taken the "patchset looks great" from Antonio as ACK, fixed the
"msg( M_FATAL," space on the go (trivial whitespace fixes are
acceptable).
Not tested beyond minimal compile test and stare-at-code.
Your patch has been applied to the master branch.
commit b7c6920eab5d5606
Stared-at-code, and compile-tested. Agree with Frank :-)
Your patch has been applied to the master branch.
commit aef8a872aa51331f781265fdb6b3c340463637a8
Author: Ilia Shipitsin
Date: Mon Jul 8 23:08:19 2024 +0200
sample/sample-plugins/defer/multi-auth.c: handle strdup errors
Signe
Hi,
On Mon, Jul 08, 2024 at 11:08:20PM +0200, Ilia Shipitsin wrote:
> multi->auth_token = strdup((char *)BPTR(&session_token));
> +if (!multi->auth_token)
> +{
> +msg( M_FATAL, "Failed allocate memory for multi->auth_token");
> +}
I do wonder if this is the right approach
Your patch has been applied to the master branch.
commit 611fa55ed1ef7e78e6015e77ace19aa4b2bf744e
Author: Ilia Shipitsin
Date: Mon Jul 8 23:08:22 2024 +0200
tests/unit_tests/openvpn/test_auth_token.c: handle strdup errors
Signed-off-by: Ilia Shipitsin
Acked-by: Frank Lichtenhel
ralf_lici has abandoned this change. (
http://gerrit.openvpn.net/c/openvpn/+/736?usp=email )
Change subject: Minor fix on ifconfig parameter warning
..
Abandoned
Commit is a subset of another commit
--
To view, visit http://ge
Sorry for taking so long to handle this. These old code ruins make
my head spin...
Anyway. Arne has ACKed it, GHA likes it, my server and client test rigs
find nothing to complain.
Did stare-at-code while the tests were running... all reasonable
changes, nothing should have a behavioural change
cron2 has uploaded a new patch set (#9) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/380?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: tun: use is_tun_p2p more consistently
.
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/380?usp=email )
Change subject: tun: use is_tun_p2p more consistently
..
tun: use is_tun_p2p more consistently
Using "tun" as the variable name for the re
Attention is currently required from: flichtenheld, its_Giaan, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/587?usp=email )
Change subject: Ensures all params are ready before invoking dco_set_peer()
Attention is currently required from: flichtenheld, its_Giaan, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/587?usp=email )
Change subject: Ensures all params are ready before invoking dco_set_peer()
I did not have an obvious way to trigger this, so I first just fed it to
the DCO-enabled server/client testbed (nothing broke).
Then, after quite a bit of discussion, it was made clear that this is
for "UDP p2mp server configs". To see the effect, one needs to run with
DCO debugging (--verb 7),
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/587?usp=email )
Change subject: Ensures all params are ready before invoking dco_set_peer()
..
Ensures all params are ready before invoking dco_set_peer()
cron2 has uploaded a new patch set (#6) to the change originally created by
its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/587?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by stipa, Code-Review-1 by cron2
Change subject: Ensures all params are ready befor
Hi,
On Mon, Sep 09, 2024 at 01:39:30PM +0200, Gert Doering wrote:
> Your patch has been applied to the master branch.
Note: while this is a bugfix, it does not need to go to 2.6 - there is
no mssfix support in-kernel for DCO v2, and the upcoming DCOv3-no-called-
"ovpn" will be 2.7-only.
(FreeBSD
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/735?usp=email )
Change subject: crypto_openssl: Suppress deprecation warnings with OpenSSL 3
for GCC as well
From: Marco Baffo
Removed superfluous calls to 'add_route_ipv6' for adding ipv6 routes after tun
opening in OpenBSD, NetBSD and Darwin.
Change-Id: I235891212b15277349810913c9c1763da5c48587
Signed-off-by: Marco Baffo
Acked-by: Frank Lichtenheld
---
This change was reviewed on Gerrit and appro
I'll have a look, thanks!
On Mon, Sep 9, 2024, 09:30 Gert Doering wrote:
> Hi,
>
> On Mon, Jul 08, 2024 at 11:08:20PM +0200, Ilia Shipitsin wrote:
> > multi->auth_token = strdup((char *)BPTR(&session_token));
> > +if (!multi->auth_token)
> > +{
> > +msg( M_FATAL, "Failed all
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/737?usp=email
to review the following change.
Change subject: Fix check_addr_clash argument order
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/738?usp=email
to review the following change.
Change subject: Move to common backend_driver type in struct tuntap
..
From: Lev Stipakov
Since version 1.4, dco-win drivere supports data_v3 features
such as:
- AEAD tag at the end
- 64bit pktid
We have to:
- check in runtime if driver supports data_v3 features (we might be
running with the older driver)
- if those features are negotiated, we pass them to
Attention is currently required from: flichtenheld, plaisthos, stipa.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/733?usp=email )
Change subject: dco-win: factor out getting dco version info own function
..
Attention is currently required from: mrbff, plaisthos.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/731?usp=email
to look at the new patch set (#2).
The change is no longer submittable: checks~ChecksSubmitRule is uns
>
> Is the GUI support already committed? I seem to remember seeing a PR
> for that "weeks ago"... and someone needs to bring Tunnelblick on board.
>
GUI patch is still in a private branch -- will submit a PR soon.
I've sent a note to Jon about the change.
Selva
___
Hi,
On Mon, Sep 09, 2024 at 12:01:54PM -0400, Selva Nair wrote:
> > Is the GUI support already committed? I seem to remember seeing a PR
> > for that "weeks ago"... and someone needs to bring Tunnelblick on board.
>
> I've sent a note to Jon about the change.
Thanks :-)
gert
--
"If was one th
Hi there! Any updates on this proposal?
пн, 2 сент. 2024 г. в 22:34, Petr Portnov :
> Hi there! While working on packaging `openvpn3-linux` for NixOS I've
> discovered a problem with `asio_path` child path being too strict (since
> not all distros have `asio` as the parent of `include` directory)
From: Selva Nair
Not all of these touch uninitialzed members of the struct, but that
could change in future.
Change-Id: I71bc847b48da54b70f60ccd7c4521ec699daf9cb
Signed-off-by: Selva Nair
---
There is an unused & uninitialized struct user_pass in tun.c for ANDROID.
Could be removed?
src/openv
Acked-by: Gert Doering
Thanks. Not tested beyond "does it compile", as the changes are very
straightforward :-)
Your patch has been applied to the master and released/2.6 branch.
commit aa1dd09b5fc196499c84d2ef9b0c254ebb1745d8 (master)
commit f9ab7edbebd6dfb3fd384b56626aabb3171ac0ad (release/2
28 matches
Mail list logo
