Attention is currently required from: flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/733?usp=email )
Change subject: dco-win: factor out getting dco version info own function ...................................................................... Patch Set 1: (5 comments) Patchset: PS1: Overall the factoring-out looks good, but there's one textual change that I find to be "less clear now", and a few remarks. File src/openvpn/dco_win.c: http://gerrit.openvpn.net/c/openvpn/+/733/comment/728ea9f7_3e755e74 : PS1, Line 102: msg(D_DCO_DEBUG, "dco data_v3: %d", dco->supports_data_v3); I think keeping the "supports" here (= not changing the text) would ease understanding of the logs. http://gerrit.openvpn.net/c/openvpn/+/733/comment/69aa1495_3d39dec2 : PS1, Line 474: ZeroMemory(&version, sizeof(version)); `CLEAR(version)` exists (if you change this line anyway). Or just zeroize on assign `OVPN_VERSION = {0}`? http://gerrit.openvpn.net/c/openvpn/+/733/comment/4fdb9c97_bc7702f6 : PS1, Line 481: return BSTR(&out); technically this does something else if no DCO driver can be found - the old code returns "N/A", the new code returns "0.0.0". Is this intentional? http://gerrit.openvpn.net/c/openvpn/+/733/comment/bd3ba22f_ce91aaf0 : PS1, Line 562: dco_get_version(&version); see above wrt `CLEAR()` or `= {0}` -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/733?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I8e8ddd35bd3cc3334faf7f57118d1892512ae9f7 Gerrit-Change-Number: 733 Gerrit-PatchSet: 1 Gerrit-Owner: stipa <lstipa...@gmail.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: cron2 <g...@greenie.muc.de> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Mon, 09 Sep 2024 14:30:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
