Sorry for taking so long to handle this. These old code ruins make
my head spin...
Anyway. Arne has ACKed it, GHA likes it, my server and client test rigs
find nothing to complain.
Did stare-at-code while the tests were running... all reasonable
changes, nothing should have a behavioural change (except the fix in
ifconfig_sanity_check()). Good catch on print_topology() ;-)
Quite a few of the old
"else if (tt->type == DEV_TYPE_TUN && tt->topology == TOP_SUBNET)"
are my doing, I think... seems "if (tun)" was really very unclear...
Also thanks for restructuring the Darwin section to be "just as all
the other platforms" :-)
Your patch has been applied to the master branch.
commit 976a65346d2193181f4f5664f798e16fcbf43345
Author: Frank Lichtenheld
Date: Fri Sep 6 18:25:14 2024 +0200
tun: use is_tun_p2p more consistently
Signed-off-by: Frank Lichtenheld <fr...@lichtenheld.com>
Acked-by: Arne Schwabe <arne-open...@rfc2549.org>
Message-Id: <20240906162514.78671-1-fr...@lichtenheld.com>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg29091.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
