Attention is currently required from: flichtenheld, its_Giaan, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/587?usp=email )
Change subject: Ensures all params are ready before invoking dco_set_peer()
......................................................................
Patch Set 5: Code-Review-1
(1 comment)
Patchset:
PS5:
I'm not sure the patch is actually fixing the problematic behaviour ("not
updating mssfix correctly on pushed values").
If I run the code with `--tun-mtu 500` on the command line (proto UDP, IPv4), I
see
```
2024-09-09 12:36:53 us=890850 dco_set_peer: peer-id 0, keepalive 10/30, mss 460
```
which sounds reasonable.
if I run with `--tun-mtu 1500` locally, and the server pushes `--tun-mtu 1400`,
I get
```
2024-09-09 12:37:43 us=641363 net_iface_mtu_set: mtu 1400 for tun7
2024-09-09 12:37:43 us=642421 Data Channel MTU parms [ mss_fix:1400 max_frag:0
tun_mtu:1400 tun_max_mtu:1600 headroom:136 payload:1768 tailroom:562 ET:0 ]
2024-09-09 12:37:43 us=642891 dco_set_peer: peer-id 1, keepalive 10/30, mss 1400
```
which is not what I'd expect - but it is the same behaviour as "without this
patch".
So, to proceed here, I need instructions for "how to demonstrate the problem",
which actually see a change in behaviour with the patch...
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/587?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ic8538e734dba53cd43fead3961e4401c8037e079
Gerrit-Change-Number: 587
Gerrit-PatchSet: 5
Gerrit-Owner: its_Giaan <gianma...@mandelbit.com>
Gerrit-Reviewer: cron2 <g...@greenie.muc.de>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: stipa <lstipa...@gmail.com>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: its_Giaan <gianma...@mandelbit.com>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Comment-Date: Mon, 09 Sep 2024 10:45:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
