[Openvpn-devel] [S] Change in openvpn[master]: Fix DNS options duplication on PUSH_UPDATE

2025-07-31 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1121?usp=email ) Change subject: Fix DNS options duplication on PUSH_UPDATE

[Openvpn-devel] [S] Change in openvpn[master]: Fix DNS options duplication on PUSH_UPDATE

2025-07-31 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1121?usp=email ) Change subject: Fix DNS options duplication on PUSH_UPDATE

[Openvpn-devel] [S] Change in openvpn[master]: Fix DNS options duplication on PUSH_UPDATE

2025-07-31 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1121?usp=email ) Change subject: Fix DNS options duplication on PUSH_UPDATE

[Openvpn-devel] [M] Change in openvpn[master]: move macOS dns-updown common code into functions

2025-07-09 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1074?usp=email ) Change subject: move macOS dns-updown common code into functions .

[Openvpn-devel] [S] Change in openvpn[master]: mac dns: compare servers before restoring backup

2025-07-09 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1075?usp=email ) Change subject: mac dns: compare servers before restoring backup .

[Openvpn-devel] [S] Change in openvpn[master]: mac dns: compare servers before restoring backup

2025-07-09 Thread d12fk (Code Review)
Attention is currently required from: d12fk, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1075?usp=email to look at the new patch set (#4). Change subject: mac dns: compare servers before restoring backup

[Openvpn-devel] [S] Change in openvpn[master]: mac dns: do not run dns-updown in parallel

2025-07-09 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1076?usp=email ) Change subject: mac dns: do not run dns-updown in parallel .. Pa

[Openvpn-devel] [S] Change in openvpn[master]: mac dns: do not run dns-updown in parallel

2025-07-09 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1076?usp=email to look at the new patch set (#3). Change subject: mac dns: do not run dns-updown in parallel

[Openvpn-devel] [S] Change in openvpn[master]: mac dns: compare servers before restoring backup

2025-07-08 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1075?usp=email ) Change subject: mac dns: compare servers before restoring backup .

[Openvpn-devel] [S] Change in openvpn[master]: mac dns: do not run dns-updown in parallel

2025-07-08 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1076?usp=email ) Change subject: mac dns: do not run dns-updown in parallel .. Pa

[Openvpn-devel] [S] Change in openvpn[master]: mac dns: do not run dns-updown in parallel

2025-07-07 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1076?usp=email ) Change subject: mac dns: do not run dns-updown in parallel .. Pa

[Openvpn-devel] [XS] Change in openvpn[master]: dns: do not run updown scripts with lwipovpn

2025-07-03 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1077?usp=email to review the following change. Change subject: dns: do not run updown scripts with lwipovpn ..

[Openvpn-devel] [S] Change in openvpn[master]: mac dns: compare servers before restoring backup

2025-07-02 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1075?usp=email to review the following change. Change subject: mac dns: compare servers before restoring backu

[Openvpn-devel] [M] Change in openvpn[master]: move macOS dns-updown common code into functions

2025-07-02 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1074?usp=email to review the following change. Change subject: move macOS dns-updown common code into function

[Openvpn-devel] [S] Change in openvpn[master]: mac dns: do not run dns-updown in parallel

2025-07-02 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1076?usp=email to review the following change. Change subject: mac dns: do not run dns-updown in parallel

[Openvpn-devel] [M] Change in openvpn[master]: prevent search domain races with macOS dns-updown

2025-07-02 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1073?usp=email to review the following change. Change subject: prevent search domain races with macOS dns-updo

[Openvpn-devel] [XS] Change in openvpn[master]: dns: create NRPT registry key if it doesn't exist

2025-06-26 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1069?usp=email ) Change subject: dns: create NRPT registry key if it doesn't exist .

[Openvpn-devel] [XS] Change in openvpn[master]: dns: create NRPT registry key if it doesn't exist

2025-06-26 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1069?usp=email to look at the new patch set (#3). Change subject: dns: create NRPT registry ke

[Openvpn-devel] [XS] Change in openvpn[master]: dns: create NRPT registry key if it doesn't exist

2025-06-26 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1069?usp=email to look at the new patch set (#2). Change subject: dns: create NRPT registry key if it doesn'

[Openvpn-devel] [XS] Change in openvpn[master]: dns: create NRPT registry key if it doesn't exist

2025-06-26 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1069?usp=email to review the following change. Change subject: dns: create NRPT registry key if it doesn't exi

[Openvpn-devel] [M] Change in openvpn[master]: run forced --dns-updown without --script-security

2025-06-26 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1065?usp=email ) Change subject: run forced --dns-updown without --script-security

[Openvpn-devel] [M] Change in openvpn[master]: run forced --dns-updown without --script-security

2025-06-26 Thread d12fk (Code Review)
Attention is currently required from: d12fk, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1065?usp=email to look at the new patch set (#2). Change subject: run forced --dns-updown without --script-security

[Openvpn-devel] [XS] Change in openvpn[master]: fix macOS dns-updown handling of parallel full redirects

2025-06-25 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1066?usp=email to review the following change. Change subject: fix macOS dns-updown handling of parallel full

[Openvpn-devel] [M] Change in openvpn[master]: run forced --dns-updown without --script-security

2025-06-25 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1065?usp=email to review the following change. Change subject: run forced --dns-updown without --script-securi

[Openvpn-devel] [L] Change in openvpn[master]: dns: deal with --dhcp-options when --dns is active

2025-06-18 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos, stipa. Hello flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/904?usp=email to look at the new patch set (#24). Change subject: dns: deal with --dhcp

[Openvpn-devel] [M] Change in openvpn[master]: dns: add updown script for macOS

2025-06-17 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1062?usp=email to look at the new patch set (#2). The following approvals got outdated and were remove

[Openvpn-devel] [XS] Change in openvpn[master]: fix typo in haikuos dns-updown script

2025-06-17 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1061?usp=email to look at the new patch set (#2). The change is no longer submittable: checks~C

[Openvpn-devel] [M] Change in openvpn[master]: dns: add updown script for macOS

2025-06-12 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1062?usp=email to review the following change. Change subject: dns: add updown script for macOS ..

[Openvpn-devel] [XS] Change in openvpn[master]: fix typo in haikuos dns-updown script

2025-06-12 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1061?usp=email to review the following change. Change subject: fix typo in haikuos dns-updown script .

[Openvpn-devel] [L] Change in openvpn[master]: dns: deal with --dhcp-options when --dns is active

2025-06-05 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/904?usp=email ) Change subject: dns: deal with --dhcp-options when --dns is active ..

[Openvpn-devel] [L] Change in openvpn[master]: dns: deal with --dhcp-options when --dns is active

2025-06-04 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos, stipa. Hello flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/904?usp=email to look at the new patch set (#22). The following approvals got outdated a

[Openvpn-devel] [S] Change in openvpn[master]: win: fix collecting DNS exclude data

2025-05-20 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1028?usp=email to look at the new patch set (#3). Change subject: win: fix collecting DNS exclude data .

[Openvpn-devel] [XS] Change in openvpn[master]: win: fix collecting DNS exclude data

2025-05-20 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1028?usp=email to look at the new patch set (#2). Change subject: win: fix collecting DNS exclude data .

[Openvpn-devel] [S] Change in openvpn[master]: dns: fix potential NULL pointer dereference

2025-05-20 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1026?usp=email to look at the new patch set (#3). Change subject: dns: fix potential NULL pointer dereferenc

[Openvpn-devel] [XS] Change in openvpn[master]: win: fix collecting DNS exclude domains

2025-05-20 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1028?usp=email to review the following change. Change subject: win: fix collecting DNS exclude domains ...

[Openvpn-devel] [M] Change in openvpn[master]: dns: fix potential NULL pointer dereference

2025-05-19 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1026?usp=email to look at the new patch set (#2). Change subject: dns: fix potential NULL pointer dereferenc

[Openvpn-devel] [L] Change in openvpn[master]: dns: deal with --dhcp-options when --dns is active

2025-05-19 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/904?usp=email ) Change subject: dns: deal with --dhcp-options when --dns is active .

[Openvpn-devel] [M] Change in openvpn[master]: dns: fix potential NULL pointer dereference

2025-05-19 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1026?usp=email to review the following change. Change subject: dns: fix potential NULL pointer dereference ...

[Openvpn-devel] [XS] Change in openvpn[master]: fix typo in haikuos dns-updown script

2025-05-15 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1023?usp=email to review the following change. Change subject: fix typo in haikuos dns-updown script .

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-05-14 Thread d12fk (Code Review)
Attention is currently required from: cron2, d12fk, flichtenheld, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email to look at the new patch set (#25). The following approvals got outdated a

[Openvpn-devel] [L] Change in openvpn[master]: dns: support running up/down command with privsep

2025-05-13 Thread d12fk (Code Review)
Attention is currently required from: MaxF, cron2, d12fk, flichtenheld, plaisthos. Hello MaxF, cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/839?usp=email to look at the new patch set (#25). The following approvals g

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-05-13 Thread d12fk (Code Review)
Attention is currently required from: cron2, d12fk, flichtenheld, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email to look at the new patch set (#24). The following approvals got outdated a

[Openvpn-devel] [L] Change in openvpn[master]: dns: support running up/down command with privsep

2025-05-13 Thread d12fk (Code Review)
Attention is currently required from: MaxF, d12fk, flichtenheld, plaisthos. Hello MaxF, cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/839?usp=email to look at the new patch set (#24). The change is no longer submittab

[Openvpn-devel] [L] Change in openvpn[master]: dns: support running up/down command with privsep

2025-05-10 Thread d12fk (Code Review)
Attention is currently required from: MaxF, cron2, flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/839?usp=email ) Change subject: dns: support running up/down command with privsep

[Openvpn-devel] [L] Change in openvpn[master]: dns: support running up/down command with privsep

2025-05-10 Thread d12fk (Code Review)
Attention is currently required from: MaxF, d12fk, flichtenheld, plaisthos. Hello MaxF, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/839?usp=email to look at the new patch set (#23). The following approvals got outdated and

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-05-10 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email to look at the new patch set (#23). Change subject: dns: apply settings via scri

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-05-10 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email ) Change subject: dns: apply settings via script on unixoid systems ..

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-04-27 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email to look at the new patch set (#22). The following approvals got outdated and were

[Openvpn-devel] [L] Change in openvpn[master]: dns: support running up/down command with privsep

2025-04-27 Thread d12fk (Code Review)
Attention is currently required from: MaxF, d12fk, plaisthos. Hello MaxF, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/839?usp=email to look at the new patch set (#22). The change is no longer submittable: checks~ChecksSubm

[Openvpn-devel] [L] Change in openvpn[master]: dns: deal with --dhcp-options when --dns is active

2025-04-27 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. Hello flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/904?usp=email to look at the new patch set (#15). The following approvals got outdated and were

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-04-27 Thread d12fk (Code Review)
Attention is currently required from: cron2, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email ) Change subject: dns: apply settings via script on unixoid systems .. Pat

[Openvpn-devel] [L] Change in openvpn[master]: dns: deal with --dhcp-options when --dns is active

2025-04-27 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/904?usp=email ) Change subject: dns: deal with --dhcp-options when --dns is active .

[Openvpn-devel] [XL] Change in openvpn[master]: win: implement --dns option support with NRPT

2025-04-09 Thread d12fk (Code Review)
Attention is currently required from: plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/837?usp=email ) Change subject: win: implement --dns option support with NRPT .. Patch Set 18:

[Openvpn-devel] [XL] Change in openvpn[master]: win: implement --dns option support with NRPT

2025-04-09 Thread d12fk (Code Review)
Attention is currently required from: plaisthos. d12fk has removed a vote from this change. ( http://gerrit.openvpn.net/c/openvpn/+/837?usp=email ) Change subject: win: implement --dns option support with NRPT .. Removed Code

[Openvpn-devel] [L] Change in openvpn[master]: dns: support running up/down command with privsep

2025-04-04 Thread d12fk (Code Review)
Attention is currently required from: MaxF, d12fk, plaisthos. Hello MaxF, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/839?usp=email to look at the new patch set (#21). The change is no longer submittable: checks~ChecksSubm

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-04-04 Thread d12fk (Code Review)
Attention is currently required from: cron2, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email ) Change subject: dns: apply settings via script on unixoid systems .. Pat

[Openvpn-devel] [L] Change in openvpn[master]: dns: support running up/down command with privsep

2025-04-04 Thread d12fk (Code Review)
Attention is currently required from: MaxF, d12fk, plaisthos. Hello MaxF, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/839?usp=email to look at the new patch set (#20). The change is no longer submittable: checks~ChecksSubm

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-04-04 Thread d12fk (Code Review)
Attention is currently required from: cron2, d12fk, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email to look at the new patch set (#20). The change is no longer submittable: checks~ChecksSu

[Openvpn-devel] [XL] Change in openvpn[master]: win: implement --dns option support with NRPT

2025-04-04 Thread d12fk (Code Review)
Attention is currently required from: plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/837?usp=email ) Change subject: win: implement --dns option support with NRPT .. Patch S

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-03-31 Thread d12fk (Code Review)
Attention is currently required from: cron2, d12fk, flichtenheld, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email to look at the new patch set (#19). The following approvals got outdated a

[Openvpn-devel] [L] Change in openvpn[master]: dns: deal with --dhcp-options when --dns is active

2025-03-31 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/904?usp=email to look at the new patch set (#12). Change subject: dns: deal with --dhcp-options when --dns i

[Openvpn-devel] [L] Change in openvpn[master]: dns: deal with --dhcp-options when --dns is active

2025-03-27 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/904?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed

[Openvpn-devel] [L] Change in openvpn[master]: dns: deal with --dhcp-options when --dns is active

2025-03-26 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/904?usp=email to look at the new patch set (#8). Change subject: dns: deal with --dhcp-options when -

[Openvpn-devel] [XL] Change in openvpn[master]: win: implement --dns option support with NRPT

2025-03-26 Thread d12fk (Code Review)
Attention is currently required from: plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/837?usp=email ) Change subject: win: implement --dns option support with NRPT .. Patch S

[Openvpn-devel] [L] Change in openvpn[master]: dns: support running up/down command with privsep

2025-03-26 Thread d12fk (Code Review)
Attention is currently required from: MaxF, d12fk, plaisthos. Hello MaxF, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/839?usp=email to look at the new patch set (#17). The change is no longer submittable: checks~ChecksSubm

[Openvpn-devel] [XL] Change in openvpn[master]: win: implement --dns option support with NRPT

2025-03-25 Thread d12fk (Code Review)
Attention is currently required from: plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/837?usp=email ) Change subject: win: implement --dns option support with NRPT .. Patch S

[Openvpn-devel] [L] Change in openvpn[master]: dns: deal with --dhcp-options when --dns is active

2025-03-20 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/904?usp=email ) Change subject: dns: deal with --dhcp-options when --dns is active

[Openvpn-devel] [M] Change in openvpn[master]: dns: don't publish env vars to non-dns scripts

2025-03-19 Thread d12fk (Code Review)
Attention is currently required from: cron2, d12fk, flichtenheld, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/840?usp=email to look at the new patch set (#17). Change subject: dns: don't publish en

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-03-19 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email to look at the new patch set (#16). The following approvals got outdated and were

[Openvpn-devel] [XL] Change in openvpn[master]: win: implement --dns option support with NRPT

2025-03-19 Thread d12fk (Code Review)
Attention is currently required from: plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/837?usp=email ) Change subject: win: implement --dns option support with NRPT .. Patch S

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-03-19 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email ) Change subject: dns: apply settings via script on unixoid systems ..

[Openvpn-devel] [M] Change in openvpn[master]: dns: clean up --dhcp-options when --dns is active

2025-03-18 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/904?usp=email to look at the new patch set (#5). Change subject: dns: clean up --dhcp-options when --

[Openvpn-devel] [L] Change in openvpn[master]: dns: don't publish env vars to non-dns scripts

2025-03-17 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/840?usp=email to look at the new patch set (#15). Change subject: dns: don't publish env vars

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-03-17 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email to look at the new patch set (#15). Change subject: dns: apply settings via script on unixoid

[Openvpn-devel] [L] Change in openvpn[master]: dns: support running up/down command with privsep

2025-03-17 Thread d12fk (Code Review)
Attention is currently required from: MaxF, d12fk, flichtenheld, plaisthos. Hello MaxF, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/839?usp=email to look at the new patch set (#15). The following approvals got outdated and

[Openvpn-devel] [M] Change in openvpn[master]: dns: clean up --dhcp-options when --dns is active

2025-03-17 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/904?usp=email to look at the new patch set (#6). Change subject: dns: clean up --dhcp-options when --

[Openvpn-devel] [L] Change in openvpn[master]: dns: support running up/down script with privsep

2025-03-14 Thread d12fk (Code Review)
Attention is currently required from: MaxF, d12fk, plaisthos. Hello MaxF, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/839?usp=email to look at the new patch set (#14). The change is no longer submittable: checks~ChecksSubm

[Openvpn-devel] [M] Change in openvpn[master]: dns: clean up --dhcp-options when --dns is active

2025-03-13 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/904?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed

[Openvpn-devel] [M] Change in openvpn[master]: win: match search domains when creating exclude rules

2025-03-13 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/905?usp=email to look at the new patch set (#3). Change subject: win: match search domains when creating exc

[Openvpn-devel] [XS] Change in openvpn[master]: win: calculate address string buffer size

2025-03-13 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/908?usp=email to review the following change. Change subject: win: calculate address string buffer size ..

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-03-13 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email to look at the new patch set (#14). Change subject: dns: apply settings via script on unixoid

[Openvpn-devel] [L] Change in openvpn[master]: dns: don't publish env vars to non-dns scripts

2025-03-13 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/840?usp=email ) Change subject: dns: don't publish env vars to non-dns scripts .

[Openvpn-devel] [M] Change in openvpn[master]: win: match search domains when creating exclude rules

2025-03-13 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/905?usp=email ) Change subject: win: match search domains when creating exclude rules .

[Openvpn-devel] [L] Change in openvpn[master]: dns: don't publish env vars to non-dns scripts

2025-03-13 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/840?usp=email to look at the new patch set (#14). The following approvals got outdated and were

[Openvpn-devel] [M] Change in openvpn[master]: win: match search domains when creating exclude rules

2025-03-12 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/905?usp=email ) Change subject: win: match search domains when creating exclude rules .

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-03-11 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email ) Change subject: dns: apply settings via script on unixoid systems .

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

2025-03-11 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos, stipa. Hello cron2, flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/824?usp=email to look at the new patch set (#13). The following approvals got out

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-03-11 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email to look at the new patch set (#13). The following approvals got outdated and were removed: Code

[Openvpn-devel] [S] Change in openvpn[master]: dns: clean up --dhcp-options when --dns is active

2025-03-11 Thread d12fk (Code Review)
Attention is currently required from: d12fk, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/904?usp=email to look at the new patch set (#3). The change is no longer submittable: checks~ChecksSubmitRule is uns

[Openvpn-devel] [L] Change in openvpn[master]: dns: do not use netsh to set name server addresses

2025-03-11 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/825?usp=email to look at the new patch set (#13). The change is no longer submittable: checks~C

[Openvpn-devel] [L] Change in openvpn[master]: dns: support running up/down script with privsep

2025-03-11 Thread d12fk (Code Review)
Attention is currently required from: MaxF, d12fk, plaisthos. Hello MaxF, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/839?usp=email to look at the new patch set (#13). The change is no longer submittable: checks~ChecksSubm

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

2025-03-11 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/824?usp=email ) Change subject: dns: support multiple domains without DHCP .

[Openvpn-devel] [L] Change in openvpn[master]: dns: don't publish env vars to non-dns scripts

2025-03-11 Thread d12fk (Code Review)
Attention is currently required from: cron2, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/840?usp=email ) Change subject: dns: don't publish env vars to non-dns scripts .. Patch

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-03-07 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email ) Change subject: dns: apply settings via script on unixoid systems .

[Openvpn-devel] [M] Change in openvpn[master]: win: match search domains when creating exclude rules

2025-03-07 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/905?usp=email to review the following change. Change subject: win: match search domains when creating exclude

[Openvpn-devel] [S] Change in openvpn[master]: dns: clean up --dhcp-options when --dns is active

2025-03-06 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/904?usp=email to review the following change. Change subject: dns: clean up --dhcp-options when --dns is activ

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-03-06 Thread d12fk (Code Review)
Attention is currently required from: plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email ) Change subject: dns: apply settings via script on unixoid systems .. Patch Set

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-03-06 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email to look at the new patch set (#12). Change subject: dns: apply settings via script on unixoid

[Openvpn-devel] [L] Change in openvpn[master]: dns: don't publish env vars to non-dns scripts

2025-03-06 Thread d12fk (Code Review)
Attention is currently required from: d12fk, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/840?usp=email to look at the new patch set (#11). Change subject: dns: don't publish env vars to non-dns scripts ..

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-03-06 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email to look at the new patch set (#11). The following approvals got outdated and were removed: Code

  1   2   >