Attention is currently required from: plaisthos, stipa.

d12fk has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/837?usp=email )

Change subject: win: implement --dns option support with NRPT
......................................................................


Patch Set 14:

(2 comments)

File src/openvpnserv/interactive.c:

http://gerrit.openvpn.net/c/openvpn/+/837/comment/b99905f4_e88c89db :
PS14, Line 2259:         MsgToEventLog(M_SYSERR, TEXT("IsInterfaceConnected: "
> At least on my machine I have 6 "real" network adapters (according to 
> Get-NetAdapter | Format-List N […]
Hm, I do not have adapters I can reproduce this on my system. Shall we do a 
joined session figuring this out, or do you have an idea already, why these 
adapters are listed in the interfaces registry hive, but fail to produce a LUID?


http://gerrit.openvpn.net/c/openvpn/+/837/comment/44df0b7c_cc86afff :
PS14, Line 2510:     for (int i = 0; i < _countof(data); ++i)
> Does it really make sense to create keys for all adapters, even if there are 
> no domains/servers defi […]
Yeah, if no domains or nameservers are defined the adapters are not added as 
exclude data, so there will be no RoutingX NRPT rules for those. I think that 
was what you were asking, right?



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/837?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I576e74f3276362606e9cbd50bb5adbebaaf209cc
Gerrit-Change-Number: 837
Gerrit-PatchSet: 14
Gerrit-Owner: d12fk <he...@openvpn.net>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: stipa <lstipa...@gmail.com>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: stipa <lstipa...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Mar 2025 03:54:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: stipa <lstipa...@gmail.com>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to