Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1077?usp=email
to review the following change.
Change subject: dns: do not run updown scripts with lwipovpn
......................................................................
dns: do not run updown scripts with lwipovpn
Running the script doesn't make sense with the AFUNIX dev node, so we
simply clear any scripts that have been set before.
Change-Id: I7e9a0c668e0950257632452cfd9eeb236f0120f2
Signed-off-by: Heiko Hund <he...@ist.eigentlich.net>
---
M src/openvpn/options.c
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/77/1077/1
diff --git a/src/openvpn/options.c b/src/openvpn/options.c
index af097f8..0662b49 100644
--- a/src/openvpn/options.c
+++ b/src/openvpn/options.c
@@ -61,6 +61,7 @@
#include "xkey_common.h"
#include "dco.h"
#include "options_util.h"
+#include "tun_afunix.h"
#include <ctype.h>
@@ -3593,6 +3594,13 @@
struct gc_arena gc = gc_new();
struct dns_options *dns = &o->dns_options;
+ if (is_tun_afunix(o->dev_node))
+ {
+ /* Disable running dns-updown script with lwipovpn */
+ dns->updown_flags = DNS_UPDOWN_NO_FLAGS;
+ dns->updown = NULL;
+ }
+
if (dns->servers || dns_updown_user_set(dns) || dns_updown_forced(dns))
{
/* Clean up env from --dhcp-option DNS config */
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1077?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I7e9a0c668e0950257632452cfd9eeb236f0120f2
Gerrit-Change-Number: 1077
Gerrit-PatchSet: 1
Gerrit-Owner: d12fk <he...@openvpn.net>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-MessageType: newchange
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
