Attention is currently required from: plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/837?usp=email )
Change subject: win: implement --dns option support with NRPT ...................................................................... Patch Set 14: (2 comments) File src/openvpnserv/interactive.c: http://gerrit.openvpn.net/c/openvpn/+/837/comment/d4afefe5_56002315 : PS14, Line 2259: MsgToEventLog(M_SYSERR, TEXT("IsInterfaceConnected: " > Sure. In my case it is probably Hyper-V virtual adapters. […] The code fails now without error message if ConvertInterfaceGuidToLuid() fails. However, I wonder why it fails in the first place with those interfaces. Basically that means that for any interface, where this conversion fails, there will be no exclude rules ever, and not even a diagnostic message to explain this. Leaves an uneasy feeling behind for me. http://gerrit.openvpn.net/c/openvpn/+/837/comment/085ad92a_b096baa2 : PS14, Line 2510: for (int i = 0; i < _countof(data); ++i) > But there are: https://usercontent.irccloud-cdn.com/file/eJy2zlR6/image. […] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/837?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I576e74f3276362606e9cbd50bb5adbebaaf209cc Gerrit-Change-Number: 837 Gerrit-PatchSet: 14 Gerrit-Owner: d12fk <he...@openvpn.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: stipa <lstipa...@gmail.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Thu, 27 Mar 2025 01:28:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: d12fk <he...@openvpn.net> Comment-In-Reply-To: stipa <lstipa...@gmail.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
