[Openvpn-devel] [PATCH] Set DNS Domain using iservice

From: Selva Nair Use wmic instead of directly editing the registry as the former does not take full effect unless the dns client service is restarted. Editing the registry appears to work erratically depending on whether its followed with a dchp renew or ipconfig /registerdns etc. DOMAIN-SEARCH

[Openvpn-devel] Summary of the community meeting (24th September 2020)

Hi, Here's the summary of the IRC meeting. --- COMMUNITY MEETING Place: #openvpn-meeting on irc.freenode.net Date: Thu 24th September 2020 Time: 20:00 CEST (18:00 UTC) Planned meeting topics for this meeting were here: Your local

[Openvpn-devel] [PATCH] Alias ADAPTER_DOMAIN_SUFFIX to DOMAIN

From: Lev Stipakov ADAPTER_DOMAIN_SUFFIX is an openvpn3 replacement for DOMAIN, which is used there for split-dns. This is pushed by modern Access Server. This change improves compatibility between OpenVPN community client and Access Server. Signed-off-by: Lev Stipakov --- doc/man-sections/vp

[Openvpn-devel] [PATCH applied] Re: openvpnmsica: Simplify find_adapters() to void return

Indeed, that looks simple and straightforward :-) - compile tested on MinGW. Your patch has been applied to the master and release/2.5 branch. commit 7f7b05395c3eb634e198d12e212360958c3ca8fb (master) commit 29e61986af6bfe4ca41163c4a1c74d90b1b0bdea (release/2.5) Author: Simon Rozman via Openvpn-de

[Openvpn-devel] [PATCH applied] Re: netsh: Delete WINS servers on TUN close

Your patch has been applied to the master and release/2.5 branch. I have not tested this at all (no WINS infra), but "it looks reasonable and compiles" (Ubuntu 18, mingw). commit 370395b3348c4307cdea955abaa36ba315cc128e (master) commit b77fc7121003d988eaa3eaeef2ec46bff73202cf (release/2.5) Autho

[Openvpn-devel] [PATCH applied] Re: netsh: Clear existing IPv6 DNS servers before configuring new ones

Your patch has been applied to the master and release/2.5 branch. In my win7 tests this does not seem to be *needed* - I ran a test with an IPv6 DNS server, and then the same test without, and the "ipconfig /all" output showed "no more IPv6 DNS server" (before applying this patch) - but this might

[Openvpn-devel] [PATCH applied] Re: netsh: Specify interfaces by index rather than name

This patch is good and a useful change (I have stared-at-code and it make sense, and Lev has reviewed and tested it on Win10/MSVC). I have test compiled this in MinGW on Ubuntu 18.04 and tested IPv6 route installation/removal on Win7/64 with the GUI running as Administrator (= netsh commands used,

Re: [Openvpn-devel] [PATCH] openvpnmsica: Skip legacy TAP-Windows6 adapters from evaluation

Hi, > Legacy TAP-Windows6 adapters (marked as IF_TYPE_ETHERNET_CSMACD 0x6) > fail to upgrade to the new driver on Windows 7: Device cannot start > (Code 10). Does "legacy" adapter mean the one which was built before https://github.com/OpenVPN/tap-windows6/commit/c869bc91c2537868d012af6cf833889420

Re: [Openvpn-devel] [PATCH] openvpnmsica: Simplify find_adapters() to void return

Hi, > to return result code. It still logs any error thou. though > -static UINT > +static void Indeed, the return value of find_adapters() has never been used. Compiled with MSVC. Acked-by: Lev Stipakov ___ Openvpn-devel mailing list Openvpn-dev

Re: [Openvpn-devel] [PATCH 3/3] netsh: Delete WINS servers on TUN close

Hi, > +"%s%s interface ipv4 delete winsservers %lu all", For DNS we use "dns", so it would be nice to unify it - either use dnsservers/winsservers or dns/wins. But that could be done later. Code makes sense, compiled/tested on MSVC/Win10. Acked-by: Lev Stipakov __

Re: [Openvpn-devel] [PATCH v6 1/2] Selectively reformat too long lines

Hi Antonio, Here's I have aligned the last line to add next new proto, already aligned. Yes, you’re right “UDPv6” also needs to be aligned, and space needs to be added for all lines, thank you. V7 is sent -- Best Regards, Vladislav Grishenko > -Original Message- > From

[Openvpn-devel] [PATCH v7] Selectively reformat too long lines

Per https://community.openvpn.net/openvpn/wiki/CodeStyle the maximum line length is 80 characters. This patch allows to split upcoming changes into CodeStyle-conformant (w/o real code change) and more feature-specific. Upcoming changes adds new PROTO_AUTO, so existing proto_names array is reformatt

Re: [Openvpn-devel] [PATCH 2/3] netsh: Clear existing IPv6 DNS servers before configuring new ones

Hi, > When there are no IPv6 DNS published, the adapter state is not > sanitized and might contain IPv6 DNS server from a previous session. In this case, shouldn't the "set dns" call below overwrite the previous value? > netsh_ifconfig_options() clears DNS servers for IPv4 already. Agreed, let'

Re: [Openvpn-devel] [PATCH v6 1/2] Selectively reformat too long lines

Hi, On 20/09/2020 22:57, Vladislav Grishenko wrote: > @@ -3170,7 +3179,7 @@ static const struct proto_names proto_names[] = { > {"udp6","UDPv6", AF_INET6, PROTO_UDP}, > {"tcp6-server","TCPv6_SERVER", AF_INET6, PROTO_TCP_SERVER}, > {"tcp6-client","TCPv6_CLIENT", AF_INET6, PROTO_TCP_C

Re: [Openvpn-devel] [PATCH 1/3] netsh: Specify interfaces by index rather than name

Good old "name vs index" thing. According to "man" of netsh, index indeed could be used for "set address" and "add route": > interface - Interface name or index. > +DWORD adapter_index; > if (r6->adapter_index) /* vpn server special route */ > { > -

[Openvpn-devel] [PATCH] openvpnmsica: Skip legacy TAP-Windows6 adapters from evaluation

Legacy TAP-Windows6 adapters (marked as IF_TYPE_ETHERNET_CSMACD 0x6) fail to upgrade to the new driver on Windows 7: Device cannot start (Code 10). Ignoring those adapters on Windows 7 triggers creation of a new TAP adapter on setup eliminating the need for user intervention. Signed-off-by: Simon