This patch is good and a useful change (I have stared-at-code and
it make sense, and Lev has reviewed and tested it on Win10/MSVC).
I have test compiled this in MinGW on Ubuntu 18.04 and tested IPv6 route
installation/removal on Win7/64 with the GUI running as Administrator
(= netsh commands used, not iservice) and it is also doing the right
things. I have tested "ipv6 ifconfig", "ipv6 route" and "ipv6 DNS",
but not "IPv4 configs" or "enable DHCP".
At this point in the release cycle I would normally have not
included it into release/2.5 anymore - we're trying to eventually
reach a release, and not merge refactoring things anymore - *but*
since this is well-contained, and 2/3+3/3 are actual bugfixes that
sort of need this as prerequisite, so be it.
Let's see if we beat the number of release candidates 2.1 had... :-)
Your patch has been applied to the master and release/2.5 branch.
commit 6020e94bcf9eda89aa6573cb2eb1faf6d267cb46 (master)
commit 422343040f137cf970aea0cf8f1f248d5dc50b9d (release/2.5)
Author: Simon Rozman via Openvpn-devel
Date: Thu Sep 24 08:44:50 2020 +0200
netsh: Specify interfaces by index rather than name
Signed-off-by: Simon Rozman <si...@rozman.si>
Acked-by: Lev Stipakov <lstipa...@gmail.com>
Message-Id: <20200924064452.1001-1-si...@rozman.si>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg21076.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
