Hi Antonio,

 

Here's I have aligned the last line to add next new proto, already aligned.

Yes, you’re right “UDPv6” also needs to be aligned, and space needs to be added 
for all lines, thank you.

V7 is sent

 



 

--

Best Regards, Vladislav Grishenko

 

> -----Original Message-----

> From: Antonio Quartulli <a...@unstable.cc>

> Sent: Thursday, September 24, 2020 1:12 PM

> To: Vladislav Grishenko <themi...@yandex-team.ru>; openvpn-

> de...@lists.sourceforge.net

> Subject: Re: [Openvpn-devel] [PATCH v6 1/2] Selectively reformat too long 
> lines

> 

> Hi,

> 

> On 20/09/2020 22:57, Vladislav Grishenko wrote:

> > @@ -3170,7 +3179,7 @@ static const struct proto_names proto_names[] = {

> >      {"udp6","UDPv6", AF_INET6, PROTO_UDP},

> >      {"tcp6-server","TCPv6_SERVER", AF_INET6, PROTO_TCP_SERVER},

> >      {"tcp6-client","TCPv6_CLIENT", AF_INET6, PROTO_TCP_CLIENT},

> > -    {"tcp6","TCPv6", AF_INET6, PROTO_TCP},

> > +    {"tcp6",       "TCPv6", AF_INET6, PROTO_TCP},

> 

> What are you actually fixing here? Adding a tab?

> I feel there should be a space after each ',', but that is probably out of 
> the scope

> of this patch?

> 

> 

> --

> Antonio Quartulli

_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to