Hi, > Legacy TAP-Windows6 adapters (marked as IF_TYPE_ETHERNET_CSMACD 0x6) > fail to upgrade to the new driver on Windows 7: Device cannot start > (Code 10).
Does "legacy" adapter mean the one which was built before https://github.com/OpenVPN/tap-windows6/commit/c869bc91c2537868d012af6cf833889420350387 (merged in 10/2019) ? I just installed 2.4.6 (released in 04/2018) on Windows 7 and upgraded it to 2.5rc1 without any issues. Am I missing something? Also, is it supposed to be only Windows 7 specific? > + OSVERSIONINFOEX osvi = { sizeof(OSVERSIONINFOEX), > HIBYTE(_WIN32_WINNT_WIN8), LOBYTE(_WIN32_WINNT_WIN8) }; > + DWORDLONG const dwlConditionMask = > VerSetConditionMask(VerSetConditionMask(0, VER_MAJORVERSION, > VER_GREATER_EQUAL), VER_MINORVERSION, VER_GREATER_EQUAL); > + BOOL bSkipLegacyAdapters = !VerifyVersionInfo(&osvi, VER_MAJORVERSION | > VER_MINORVERSION, dwlConditionMask); Cannot we use IsWindows7OrGreater() ? It should work even though msiexec is not manifested. > + if (CM_Get_DevNode_Status(&node->ulStatus, &node->ulProblemNumber, > devinfo_data.DevInst, 0) != CR_SUCCESS) > + { > + node->ulStatus = 0; > + node->ulProblemNumber = 0; > + } Is this change related to the bug we're supposingly fixing? What does it do, why is it needed? -- -Lev _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
