Re: [opensource-dev] Review Request: STORM-524 : Refresh L$ balance

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/6/#review17 --- Ship it! Looks fine to me. - Vadim On 2010-12-08 21:59:58, Merov

Re: [opensource-dev] Review Request: STORM-524 : Refresh L$ balance

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/6/#review21 --- Merov, why do we need those added calls? And the one in draw() looks

Re: [opensource-dev] Review Request: STORM-524 : Refresh L$ balance

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/6/#review22 --- Ship it! No more objections. - Vadim On 2010-12-10 16:21:57, Mero

[opensource-dev] Review Request: STORM-702 Make it possible to wear partial outfits

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/14/ --- Review request for Viewer. Summary --- Enabled the "Replace Current Out

Re: [opensource-dev] Review Request: VWR-20962 CTRL-\ Last chatter

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/16/#review23 --- Ship it! Looks plausible and works for me. - Vadim On 2010-12-13

Re: [opensource-dev] Review Request: (STORM-771) As someone working with outfits, copy/paste in Current Outfit Folder should paste links (which are supported) rather than objects (which are not)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/20/#review26 --- Ship it! Looks fine. I'm only not sure about forcing links in outfi

Re: [opensource-dev] Review Request: Bug Fix for STORM-776 and STORM-288

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/21/#review28 --- Ship it! Looks plausible and works for me. - Vadim On 2010-12-15

Re: [opensource-dev] Review Request: Modify Viewer to statically link to KDU v6.4.1 if available

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/3/#review57 --- Ship it! No significant objections. (I didn't actually review llimag

Re: [opensource-dev] Review Request: Upgrade libcurl to 7.21.1

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/52/#review60 --- Ship it! Builds and works fine on Linux/x86. - Vadim On 2010-12-

Re: [opensource-dev] Review Request: The world map can point to the wrong URL

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/61/#review76 --- Looks good overall, I only have a minor point. indra/newview/llsta

Re: [opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/63/#review79 --- Ship it! No reason not to submit. :-) indra/llkdu/llimagej2ckdu.h

Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/65/#review85 --- Seems plausible. indra/newview/llpanelmaininventory.cpp

Re: [opensource-dev] Review Request: Constraints in XUI files don't match the constraints imposed elsewhere in the viewer/server code.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/57/#review86 --- How do you know the server constraints? - Vadim On 2010-12-22 12:

Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

> On 2010-12-24 10:55:28, Vadim ProductEngine wrote: > > indra/newview/llpanelmaininventory.cpp, line 509 > > <http://codereview.secondlife.com/r/65/diff/1/?file=274#file274line509> > > > > This line can now be removed at all. > > Jonathan Yap wrote

Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

> On 2010-12-24 15:30:55, Jonathan Yap wrote: > > indra/newview/llpanelmaininventory.cpp, line 948 > > > > > > I updated the code per Aleric's suggestion but the 2nd diff failed to > > upload. There must be some unusual

Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

> On 2010-12-24 13:25:16, Aleric Inglewood wrote: > > indra/newview/llpanelmaininventory.cpp, line 948 > > > > > > While you're removing that empty line anyway, I thought I'd help you to > > not learn the bad coding habb

Re: [opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/63/#review94 --- Thanks, Merov. I have no more objections. indra/llimagej2coj/llima

Re: [opensource-dev] Review Request: The world map can point to the wrong URL

> On 2010-12-23 05:16:08, Vadim ProductEngine wrote: > > indra/newview/llstartup.cpp, lines 3098-3099 > > <http://codereview.secondlife.com/r/61/diff/1/?file=230#file230line3098> > > > > Frankly speaking, I'm not a fan of adding another setting to

Re: [opensource-dev] Review Request: The world map can point to the wrong URL

> On 2010-12-23 05:16:08, Vadim ProductEngine wrote: > > indra/newview/llstartup.cpp, lines 3098-3099 > > <http://codereview.secondlife.com/r/61/diff/1/?file=230#file230line3098> > > > > Frankly speaking, I'm not a fan of adding another setting to

Re: [opensource-dev] Review Request: The world map can point to the wrong URL

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/61/#review103 --- Ship it! - Vadim On 2010-12-22 22:15:00, Merov Linden wrote: >

Re: [opensource-dev] Review Request: (STORM-383) Context menu cannot be open for Landmark that are located in the My inventory->Trash folder

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/77/#review170 --- indra/newview/llpanellandmarks.cpp

Re: [opensource-dev] Review Request: (STORM-383) Context menu cannot be open for Landmark that are located in the My inventory->Trash folder

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/77/#review177 --- Ship it! Alright then. - Vadim On Jan. 17, 2011, 8:17 a.m., Set

Re: [opensource-dev] Review Request: STORM-2 As a User, I want to set my own default views with specific UI layout so I can tailor my Viewer experience to the activities I'm most interested in.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/98/#review181 --- Ship it! Looks good, given that this is a first pass implementatio

[opensource-dev] Review Request: STORM-373 "Rename" context menu option disabled for incomplete inventory items

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/101/ --- Review request for Viewer. Summary --- Refresh the inventory context m

[opensource-dev] Review Request: STORM-243 Suppress version change message in the viewer

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/109/ --- Review request for Viewer. Summary --- Removed the "You just entered a

Re: [opensource-dev] Review Request: STORM-243 Suppress version change message in the viewer

ry as well. - Vadim --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/109/#review183 --- On Jan. 18, 2011, 9:02 a.m., Vadi

[opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/ --- Review request for Viewer. Summary --- Made all keys localizable. Th

Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml

-465 is about unlocalized key names. - Vadim --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review208 --- On Jan.

[opensource-dev] Review Request: STORM-610 Changes to Environment Editor: water color change is not saved

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/125/ --- Review request for Viewer and Seth ProductEngine. Summary --- Now when

Re: [opensource-dev] Review Request: STORM-643 mini-map control displayed at top of Nearby people tab

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/124/#review262 --- Why was this request closed as submitted if it hasn't been approve

Re: [opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/127/#review263 --- Ship it! Looks plausible at first sight. - Vadim On Jan. 28, 2

Re: [opensource-dev] Review Request: STORM-643 mini-map control displayed at top of Nearby people tab

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/124/#review270 --- Ship it! Fine with me. No evident issues spotted. - Vadim On J

Re: [opensource-dev] Review Request: (STORM-316) Debug: Inventory.Folders by Name/Sort by Date/Sort by Name/System Folders to Top Do not apply and settings changes do not persist after relogging

a.m.) > > > Review request for Viewer and Vadim ProductEngine. > > > Summary > --- > > - Added "Sort Folders Always by Name" setting. > - Removed unused settings Inventory.Folders by Name/Sort by Date/Sort by > Name/System Folders to Top. >

Re: [opensource-dev] Review Request: Use consistent path for all *.py scripts

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/129/#review284 --- Why didn't you choose "!/usr/bin/env python"? It seems more flexib

Re: [opensource-dev] Review Request: Use consistent path for all *.py scripts

> On Jan. 31, 2011, 11:47 a.m., Kent Quirk wrote: > > I would much prefer that we put the /usr/bin/env python form, since env can > > find whichever python is currently set up, including someone that has it in > > /usr/local/bin, or wherever they've chosen. Env is more likely to be found > > i

Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml

This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review291 --- On Jan. 19, 2011, 8:30 a.m., Vadim ProductEngine wrote: > > --- &

Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml

f older shortcuts (see comments in STORM-362). - Vadim --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review307 --- On Ja

Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/ --- (Updated Feb. 3, 2011, 8:20 a.m.) Review request for Viewer. Changes

Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml

e extensive changes -- but > > I'm worried about this. Is this fix robust under localization? > > > > I haven't had time to investigate these issues yet; does someone else have > > the knowledge to discuss? > > > > Vadim ProductEngine wrote: > 1)

Re: [opensource-dev] Review Request: VWR-22220 Chat preferences > font size should increase size of input text as well

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/139/#review362 --- indra/newview/llchatbar.h

Re: [opensource-dev] Review Request: OPEN-29: Error out if lldir_.h is included when building for a different platform.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/148/#review363 --- Ship it! The changes look reasonable, and cleanups are always app

Re: [opensource-dev] Review Request: (STORM-949) please remove actual usernames from XUI files

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/151/#review373 --- Ship it! Looks fine. :-) - Vadim On Feb. 15, 2011, 2:48 p.m.,

Re: [opensource-dev] Review Request: VWR-22220 Chat preferences > font size should increase size of input text as well

> On Feb. 15, 2011, 6:40 a.m., Vadim ProductEngine wrote: > > indra/newview/llchatbar.h, line 83 > > <http://codereview.secondlife.com/r/139/diff/4/?file=790#file790line83> > > > > Use tabs for indentation, not spaces. > > > > This note

Re: [opensource-dev] Review Request: VWR-22220 Chat preferences > font size should increase size of input text as well

> On Feb. 15, 2011, 6:40 a.m., Vadim ProductEngine wrote: > > indra/newview/llchatbar.h, line 83 > > <http://codereview.secondlife.com/r/139/diff/4/?file=790#file790line83> > > > > Use tabs for indentation, not spaces. > > > > This note

Re: [opensource-dev] Review Request: (STORM-28) As a User, I want the ability to send my calling card to others

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/159/#review382 --- Looks good, except for a seemingly redundant code piece. indra/n

Re: [opensource-dev] Review Request: (STORM-28) As a User, I want the ability to send my calling card to others

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/159/#review383 --- Ship it! Never mind, now I see that the buddies_uuids vector is a

[opensource-dev] Review Request: STORM-236 Allow the "Speak" button to be removed, like other buttons

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/170/ --- Review request for Viewer. Summary --- Cumulative diff of changes made

Re: [opensource-dev] Review Request: STORM-236 Allow the "Speak" button to be removed, like other buttons

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/170/#review415 --- On March 3, 2011, 10:33 a.m., Vadim ProductEngine wrote: &g

Re: [opensource-dev] Review Request: STORM-236 Allow the "Speak" button to be removed, like other buttons

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/170/ --- (Updated March 4, 2011, 3:45 a.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: STORM-236 Allow the "Speak" button to be removed, like other buttons

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/170/ --- (Updated March 4, 2011, 9:09 a.m.) Review request for Viewer. Changes ---

[opensource-dev] Review Request: STORM-1016 Crash: ctrl-shift-w hides undocked Side Bar panels if almost any floater is opened

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/175/ --- Review request for Viewer and Seth ProductEngine. Summary --- Reason:

[opensource-dev] Review Request: STORM-1018 Improve error messaging for External Editor feature

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/179/ --- Review request for Viewer and Seth ProductEngine. Summary --- Let the

Re: [opensource-dev] Review Request: STORM-1018 Improve error messaging for External Editor feature

-- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/179/#review432 ------- On March 7, 2011, 9:16 a.m., Vadim ProductEngine wrote: > > -

Re: [opensource-dev] Review Request: STORM-1018 Improve error messaging for External Editor feature

ssage (in the panel xml > > instead of strings.xml) and why having it in the panel xml has any > > advantage. > > Vadim ProductEngine wrote: > It's because the XUI preview tool and script editing provide different > ways to specify external editor. >

[opensource-dev] Review Request: STORM-971 Disable the 'Stop Tracking' menu item in Mini-map floater when location tracking gets stopped.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/200/ --- Review request for Viewer. Summary --- Changes: - Removed the menu fro

Re: [opensource-dev] Review Request: STORM-971 Disable the 'Stop Tracking' menu item in Mini-map floater when location tracking gets stopped.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/200/#review457 --- On March 14, 2011, 8:44 a.m., Vadim ProductEngine wrote: >

Re: [opensource-dev] Review Request: STORM-971 Disable the 'Stop Tracking' menu item in Mini-map floater when location tracking gets stopped.

------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/200/#review457 --- On March 14, 2011, 8:44 a.m., Vadim ProductEngine wrote: > > ---

Re: [opensource-dev] Review Request: (STORM-250) Unexpected "More" text appears in the About Landmark panel after minimizing the floater

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/198/#review472 --- Ship it! Looks good. Please fix the two minor doc issues and subm

Re: [opensource-dev] Review Request: Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/197/#review473 --- Ship it! Looks good, apart from hard-coded radiuses and unclear p

Re: [opensource-dev] Review Request: fix for STORM-1049: [crashhunters] crash at LLViewerFetchedTexture::forceToSaveRawImage(int, bool)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/193/#review474 --- Bao, please upload a diff. - Vadim On None, Xiaohong Bao wrote:

Re: [opensource-dev] Review Request: STORM-1016 Crash: ctrl-shift-w hides undocked Side Bar panels if almost any floater is opened

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/175/ --- (Updated March 17, 2011, 9:24 a.m.) Review request for Viewer and Seth Prod

Re: [opensource-dev] Review Request: (STORM-1086) Agent's own calling card created on startup is placed into Friends/All folder instead of Calling Cards

ch 18, 2011, 4:43 p.m.) > > > Review request for Viewer and Vadim ProductEngine. > > > Summary > --- > > Agent's own calling card created on startup is placed into Calling Cards > folder. > If there is an agent's calling card found within Calling

Re: [opensource-dev] Review Request: (STORM-1097) Empty floater created upon docking Places side panel

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/219/#review490 --- Ship it! Fine. :-) - Vadim On March 22, 2011, 2 p.m., Seth Pro

Re: [opensource-dev] Review Request: Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/229/#review496 --- I think that pressing the Speak button or the fly-out button shoul

Re: [opensource-dev] Review Request: Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"

> On March 24, 2011, 6:04 a.m., Vadim ProductEngine wrote: > > indra/newview/skins/default/xui/en/notifications.xml, line 6616 > > <http://codereview.secondlife.com/r/229/diff/1/?file=1319#file1319line6616> > > > > I guess you meant that *voice* is e

Re: [opensource-dev] Review Request: Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/229/#review499 --- Looks good now. I only have one question, see below. indra/newvi

Re: [opensource-dev] Review Request: Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/229/#review502 --- Ship it! No more objections. Thanks, Jonathan! To avoid problems

Re: [opensource-dev] Review Request: (STORM-941) IM log naming should go by SL name, not DN.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/249/#review549 --- Looks fine, except for two issues. indra/llui/llurlaction.h

Re: [opensource-dev] Review Request: Change to description for ShowNetStatus in debbug settings.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/251/#review554 --- Ship it! I have no objections code-wise, but shouldn't the new st

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/#review556 --- indra/newview/llnearbychatbar.h

Re: [opensource-dev] Review Request: STORM-236 Actual Code Review

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/113/#review557 --- This review request is obsolete. Wolfpup, please close it. - Vadi

Re: [opensource-dev] Review Request: Use consistent path for all *.py scripts

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/129/#review558 --- The code has been integrated. Merov, please close the review reque

Re: [opensource-dev] Review Request: STORM-987 : llimage_libtest : create an independent executable to exercise llimage outside the viewer

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/195/#review559 --- Sorry, I haven't had time to investigate the build issue further.

Re: [opensource-dev] Review Request: STORM-1121: make llimage_libtest build on Linux

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/247/#review560 --- Hasn't this code been integrated already? - Vadim On March 31,

Re: [opensource-dev] Review Request: fix for STORM-1049: [crashhunters] crash at LLViewerFetchedTexture::forceToSaveRawImage(int, bool)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/193/#review561 --- Somebody please close this empty request. - Vadim On None, Xiao

Re: [opensource-dev] Review Request: STORM-610 : Changes to Environment Editor: water color change is not saved

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/254/#review569 --- Ship it! Thanks for help with this, Merov! - Vadim On April 6,

[opensource-dev] Review Request: STORM-1118 Viewer crashes when user tries to upload image without JFIF header

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/255/ --- Review request for Viewer. Summary --- * Added checks for image file c

Re: [opensource-dev] Review Request: fix for STORM-973: [crashhunters] crash at LLViewerTextureList::removeImageFromList(LLViewerFetchedTexture *)7

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/252/#review571 --- A description would not hurt: * What caused the bug? * What fixes

Re: [opensource-dev] Review Request: fix for STORM-973: [crashhunters] crash at LLViewerTextureList::removeImageFromList(LLViewerFetchedTexture *)7

> On April 8, 2011, 10:08 a.m., Vadim ProductEngine wrote: > > A description would not hurt: > > * What caused the bug? > > * What fixes it? Ah, and the fix fails to apply cleanly to viewer-development AND to BaoLinden/viewer-development

Re: [opensource-dev] Review Request: KDU Improvements: Compress j2c with precincts

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/256/#review573 --- Ship it! Not that I understand much about this KDU stuff... but I

Re: [opensource-dev] Review Request: fix for STORM-973: [crashhunters] crash at LLViewerTextureList::removeImageFromList(LLViewerFetchedTexture *)7

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/252/#review575 --- indra/newview/llviewertexturelist.cpp

Re: [opensource-dev] Review Request: fix for STORM-973: [crashhunters] crash at LLViewerTextureList::removeImageFromList(LLViewerFetchedTexture *)7

> On April 8, 2011, 12:53 p.m., Vadim ProductEngine wrote: > > > I regenerated the viewer-development-storm-973 branch based on the latest > viewer-development branch. > If you still can not apply the patch directly, I am afraid you should do the > manual merge. O

Re: [opensource-dev] Review Request: fix for STORM-973: [crashhunters] crash at LLViewerTextureList::removeImageFromList(LLViewerFetchedTexture *)7

> On April 8, 2011, 12:53 p.m., Vadim ProductEngine wrote: > > > > Vadim ProductEngine wrote: > > I regenerated the viewer-development-storm-973 branch based on the > latest viewer-development branch. > > If you still can not apply the patch directly, I

Re: [opensource-dev] Review Request: fix for STORM-973: [crashhunters] crash at LLViewerTextureList::removeImageFromList(LLViewerFetchedTexture *)7

> On April 8, 2011, 12:53 p.m., Vadim ProductEngine wrote: > > > > Vadim ProductEngine wrote: > > I regenerated the viewer-development-storm-973 branch based on the > latest viewer-development branch. > > If you still can not apply the patch directly, I

Re: [opensource-dev] Review Request: (STORM-941) IM log naming should go by SL name, not DN.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/249/#review582 --- indra/newview/llimview.cpp

Re: [opensource-dev] Review Request: (STORM-1042) Disabled 'Save' button at the 'Create Landmark' panel

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/261/#review583 --- Ship it! - Vadim On April 11, 2011, 9:27 a.m., Seth ProductEngi

Re: [opensource-dev] Review Request: STORM-1118 Viewer crashes when user tries to upload image without JFIF header

with it as long as we only read small chunks this way. - Vadim --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/255/#review580 ---

Re: [opensource-dev] Review Request: STORM-1118 Viewer crashes when user tries to upload image without JFIF header

current > > position (File begin + 2)?) > > Vadim ProductEngine wrote: > Yep, pretty obvious. If I start documenting every line, code will > eventually look even worse than without comments. > > Boroondas Gupte wrote: > Is it? Took me some while to figure thi

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/#review591 --- Thanks, Jonathan. No major issues this time. I've got a few comme

Re: [opensource-dev] Review Request: (STORM-941) IM log naming should go by SL name, not DN.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/249/#review593 --- Ship it! Looks plausible. - Vadim On April 13, 2011, 8:11 a.m.

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/#review596 --- Ship it! doc/contributions.txt

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

> On April 13, 2011, 10:24 a.m., Vadim ProductEngine wrote: > > indra/newview/llbottomtray.cpp, lines 560-561 > > <http://codereview.secondlife.com/r/244/diff/3/?file=1450#file1450line560> > > > > Any reason not to move this to LLNearbyChatBar::post

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/262/#review598 --- Ship it! No major objections. indra/newview/llfloaterworldmap.c

Re: [opensource-dev] Review Request: STORM-1103 Nearby sidebar minimap should be optional

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/265/#review603 --- Ship it! Looks fine and works well for me, however I don't quite

Re: [opensource-dev] Review Request: STORM-1103 Nearby sidebar minimap should be optional

> On April 14, 2011, 12:37 p.m., Boroondas Gupte wrote: > > indra/newview/skins/default/xui/en/panel_people.xml, lines 117-127 > > > > > > I'd prefer to have the attributes ordered semantically (i.e. 'name' > > first,

Re: [opensource-dev] Review Request: fix for STORM-973: [crashhunters] crash at LLViewerTextureList::removeImageFromList(LLViewerFetchedTexture *)7

> On April 8, 2011, 3:48 p.m., Boroondas Gupte wrote: > > indra/newview/llviewertexturelist.h, line 191 > > > > > > Any reason for this to be BOOL instead of bool? > > Also, remove the space between the name and th

Re: [opensource-dev] Review Request: fix for STORM-973: [crashhunters] crash at LLViewerTextureList::removeImageFromList(LLViewerFetchedTexture *)7

> On April 8, 2011, 12:53 p.m., Vadim ProductEngine wrote: > > indra/newview/llviewertexturelist.cpp, lines 502-517 > > <http://codereview.secondlife.com/r/252/diff/1/?file=1407#file1407line502> > > > > Almost every line of this method is a potential crashe

Re: [opensource-dev] Review Request: STORM-1118 Viewer crashes when user tries to upload image without JFIF header

ine size than reading into > > an actual buffer? (According to indra/llcommon/llapr.h, it returns -1 on > > failure.) > > > > There's also a static method LLAPRFile::size, but that seems to operate > > on not-yet-opened files given by filename. > &g

Re: [opensource-dev] Review Request: STORM-1103 Nearby sidebar minimap should be optional

> On April 14, 2011, 1:01 p.m., Vadim ProductEngine wrote: > > indra/newview/skins/default/xui/en/menu_people_nearby_view_sort.xml, line 45 > > <http://codereview.secondlife.com/r/265/diff/1/?file=1474#file1474line45> > > > > I'd say "View Mini-M

Re: [opensource-dev] Review Request: STORM-1175 Fixing close button, for Custom Port warning, in Preferences > Setup > Network

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/271/ --- (Updated April 19, 2011, 7:57 a.m.) Review request for Viewer. Changes --

  1   2   3   >