> On Jan. 31, 2011, 3:19 p.m., Merov Linden wrote: > > Good I think. I'm assuming that localization hasn't left those outside > > strings.xml for a reason (like: make sure no one ever tries to translate > > them).
No, there was no reason. It's just only two keys were initially localized (Home and End) that were described in STORM-362. Obviously, the added localization also introduced the "Missing String" warnings, so to avoid them we now have to localize all keys. - Vadim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review291 ----------------------------------------------------------- On Jan. 19, 2011, 8:30 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/108/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2011, 8:30 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Made all keys localizable. > > > This addresses bug STORM-465. > http://jira.secondlife.com/browse/STORM-465 > > > Diffs > ----- > > indra/newview/skins/default/xui/en/strings.xml 38465c40c060 > > Diff: http://codereview.secondlife.com/r/108/diff > > > Testing > ------- > > Tested on Linux. No keys produce the warning for me. > > > Thanks, > > Vadim > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
