----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/200/ -----------------------------------------------------------
Review request for Viewer. Summary ------- Changes: - Removed the menu from LLFloaterMap (the mini-map floater) that had conflicted with the one in the LLNetMap widget. - Fixed updating of the "Stop Tracking" menu item; moved that code out of draw() to avoid excessive updates. - Preventively fixed LLTracker::isTracking() to return strictly 1 or 0 (BOOL is known to cause hard-to-debug side effects with values > 1 because it's essentially just an int and thus doesn't enforce any limitations on the value). Originally based on the patch by Twisted Laws: https://codereview.secondlife.com/r/133/ This addresses bug STORM-971. http://jira.secondlife.com/browse/STORM-971 Diffs ----- indra/newview/llfloatermap.h 439fc3a274d8 indra/newview/llfloatermap.cpp 439fc3a274d8 indra/newview/llnetmap.cpp 439fc3a274d8 indra/newview/lltracker.h 439fc3a274d8 Diff: http://codereview.secondlife.com/r/200/diff Testing ------- Thanks, Vadim
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
