----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/ -----------------------------------------------------------
(Updated Feb. 3, 2011, 8:20 a.m.) Review request for Viewer. Changes ------- - Reordered strings more logically. - Removed duplicated "1" string. - Using a script, found two more duplicates ("Home", "Esc"), removed them. - Using the same script, found out that the arrow keys names ("Left", "Right", "Up", "Down") were duplicated as well. Fixed that by renaming HUD direction strings and updated the code utilizing them accordingly. Automated the work as much as possible to avoid further errors (I hope that helped :-)). Summary ------- Made all keys localizable. This addresses bug STORM-465. http://jira.secondlife.com/browse/STORM-465 Diffs (updated) ----- indra/newview/llmaniprotate.cpp b542f8134a2b indra/newview/skins/default/xui/da/strings.xml b542f8134a2b indra/newview/skins/default/xui/de/strings.xml b542f8134a2b indra/newview/skins/default/xui/en/strings.xml b542f8134a2b indra/newview/skins/default/xui/es/strings.xml b542f8134a2b indra/newview/skins/default/xui/fr/strings.xml b542f8134a2b indra/newview/skins/default/xui/it/strings.xml b542f8134a2b indra/newview/skins/default/xui/ja/strings.xml b542f8134a2b indra/newview/skins/default/xui/nl/strings.xml b542f8134a2b indra/newview/skins/default/xui/pl/strings.xml b542f8134a2b indra/newview/skins/default/xui/pt/strings.xml b542f8134a2b Diff: http://codereview.secondlife.com/r/108/diff Testing ------- Tested on Linux. No keys produce the warning for me. Thanks, Vadim
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges