[Openocd-development] Disable continuous polling during reset

2009-06-09 Thread Øyvind Harboe
Changed reset handling: save off polling state, disable polling and restore after reset. With timer based polling enabled a drscan/irscan sequence in a reset event script could have a poll run inbetween commands, which would cause havoc, occasionally. Passed smoketests. Note that reset may expli

Re: [Openocd-development] Cygwin & EOL settings - an idea..

2009-06-09 Thread Øyvind Harboe
> Maybe I'm missing something subtle, but as I understand it, the problem is > that a shell script (which will never be attempted to be run by native > Windows) is sometimes failing because it has CRLF "Windows" line-endings. > > Why don't we set the svn:eol-style property on that file to be LF? Th

Re: [Openocd-development] Cygwin & EOL settings - an idea..

2009-06-09 Thread Peter Denison
On Tue, 9 Jun 2009, Duane Ellis wrote: > Could there be something we could put in the "configure script" - that > tells CYGWIN - to behave? > ie: Perhaps something like the SHELLOPTS thing? > > For example - maybe in the "bootstrap" script? > And in the "CONFIGURE' script? > And in the Makefiles?

Re: [Openocd-development] [patch] workaround CFI alignment error traps

2009-06-09 Thread David Brownell
On Tuesday 09 June 2009, Brian Hutchinson wrote: > What do these alignment traps look like when they happen? I just updated to > the latest OpenOCD (SVN 2177) and when I do reset init ... it thinks my > target isn't halted and times out: I'd get messages about data alignment, giving addresses li

Re: [Openocd-development] RFC: struct cleanup and more

2009-06-09 Thread David Brownell
On Tuesday 09 June 2009, Rick Altherr wrote: > I'm proposing that we use encapsulation and possibly ADTs to define   > clear boundaries for functionality in the code base.  Rather than have   > one massive code base, I'd like to see subsystems that can be worked   > on internally with minimal effec

Re: [Openocd-development] RFC: struct cleanup and more

2009-06-09 Thread Rick Altherr
The strong vs weak typing issue is very vague and either side could be defended for nearly every programming language as you can see from this very discussion. See http://en.wikipedia.org/wiki/Strongly-typed_programming_language for more examples. In the grand scheme of things, weak vs stro

Re: [Openocd-development] [patch] workaround CFI alignment error traps

2009-06-09 Thread Zach Welch
On Tue, 2009-06-09 at 15:13 -0700, David Brownell wrote: > Tweak the csb337 code so that it doesn't enable alignment traps when > it completes the "reset init" sequence. > > It turns out that the current CFI code reliably triggers such traps. > I don't have time now to sort out what flavor bug tha

Re: [Openocd-development] [patch] improve "poll" docs, and report bgnd polling status

2009-06-09 Thread Zach Welch
On Tue, 2009-06-09 at 15:12 -0700, David Brownell wrote: > Move the documentation for the "poll" command up with > other server configuration. Explain what it's about; > reference the related "$target_name curstate" method. > > Update "poll" output to report whether background polling > is enable

Re: [Openocd-development] RFC: struct cleanup and more

2009-06-09 Thread David Brownell
On Tuesday 09 June 2009, Rick Altherr wrote: > > although this is the first time I've ever > > heard anyone apply that term to C.  ... > > I've commonly heard C and C++ referred to as strongly-typed. Never *once* have I heard that usage before yours. Usually C gets described as a wea

Re: [Openocd-development] [patch] workaround CFI alignment error traps

2009-06-09 Thread Brian Hutchinson
On Tue, Jun 9, 2009 at 6:13 PM, David Brownell wrote: > Tweak the csb337 code so that it doesn't enable alignment traps when > it completes the "reset init" sequence. > > It turns out that the current CFI code reliably triggers such traps. > I don't have time now to sort out what flavor bug that

Re: [Openocd-development] RFC: struct cleanup and more

2009-06-09 Thread Rick Altherr
On Jun 9, 2009, at 6:41 PM, David Brownell wrote: On Monday 01 June 2009, Rick Altherr wrote: C and C++ are both strongly typed I'm used to definitions of "strong" typing that preclude the inability to break out of the type system. That would be "very strong". "strong" just means that

Re: [Openocd-development] assert vs. error messages

2009-06-09 Thread Michael Bruck
Errors in user input should detected where user input is parsed. This includes checks that pre-conditions for internal API calls are satisfied. Internal functions should use an assert. Moving user error diagnostics from the user input functions to internal functions is a clear violation of the AP

Re: [Openocd-development] My source [find target, interface etc.] lines in my .cfg files don't work with latest build

2009-06-09 Thread Brian Hutchinson
On Tue, Jun 9, 2009 at 8:05 PM, Zach Welch wrote: > On Tue, 2009-06-09 at 17:52 -0400, Brian Hutchinson wrote: > > > > > > On Tue, Jun 9, 2009 at 5:26 PM, Brian Hutchinson > > wrote: > > I searched and saw the thread on find tcl/target etc. from a > > week ago but can't figure ou

Re: [Openocd-development] RFC: struct cleanup and more

2009-06-09 Thread David Brownell
On Monday 01 June 2009, Rick Altherr wrote: > C and C++ are both strongly typed I'm used to definitions of "strong" typing that preclude the inability to break out of the type system. C makes that trivial: cast to/from "void *" pointers, and you're done. That's because it was intended from the

Re: [Openocd-development] Jlink not running under cygwin

2009-06-09 Thread Xiaofan Chen
On Tue, Jun 9, 2009 at 11:44 PM, Gene Smith wrote: > I now get a successful build under cygwin. When I plug the jlink usb to > windows and run openocd I see the the "Cannot find jlink Interface!" > error as printed below. Do I need another special windows driver when > running jlink in cygwin? To b

Re: [Openocd-development] My source [find target, interface etc.] lines in my .cfg files don't work with latest build

2009-06-09 Thread Zach Welch
On Tue, 2009-06-09 at 17:52 -0400, Brian Hutchinson wrote: > > > On Tue, Jun 9, 2009 at 5:26 PM, Brian Hutchinson > wrote: > I searched and saw the thread on find tcl/target etc. from a > week ago but can't figure out what is going on. Do we not use > source [find interf

Re: [Openocd-development] unable to open ftdi device

2009-06-09 Thread Paul J THACKER
Paul, Rick, I found the problem. My usbfs somehow got unmounted. Thanks for the ideas. Cheers, Paul Rick Altherr wrote: > There is a udev rule file in the contrib folder. It's been a while > since I've messed with Linux device nodes, but I believe the device will > show up in /sys but udev ne

[Openocd-development] Cygwin & EOL settings - an idea..

2009-06-09 Thread Duane Ellis
All - I saw a while ago something about "SHELLOPTS=igncr" I suffered from similar problems with "LANG=", to the point where - my core scripts set & export - and override all "LOCALE" settings and force them to ENGLISH , more correctly "C" - not english. Once I did that, many of my problems wh

Re: [Openocd-development] RFC: add doc/interface/*, doc/target/*, and doc/board/*

2009-06-09 Thread David Brownell
On Thursday 21 May 2009, Zach Welch wrote: > Hi all, > > In thinking about user documentation, I was wondering whether we should > think about adding doc/target/ and doc/boards directories. In it, we > would place a documentation file for each supported target and board, > respectively. It may b

Re: [Openocd-development] unable to open ftdi device

2009-06-09 Thread Paul J THACKER
Hi Paul, From configure.log: ./configure --enable-ft2232_ftd2xx --no-create --no-recursion The libs are installed: thack...@cea05:~/openocd/openocd-0.1.0> ll /usr/local/lib/libftd* lrwxrwxrwx 1 root root 34 2009-05-21 09:52 /usr/local/lib/libftd2xx.so -> /usr/local/lib/libftd2xx.so.0.4.10

Re: [Openocd-development] unable to open ftdi device

2009-06-09 Thread Paul J THACKER
Hi Rick, I saw the openocd.udev file. Unfortunately, OpenSUSE doesn't have a group named "plugdev". I created the following using some existing rules as an example, but it doesn't help: BUS=="usb", SYSFS{idVendor}=="0403", SYSFS{idProduct}=="cff8", MODE="664", RUN="/etc/udev/setmode" These ar

[Openocd-development] [patch] workaround CFI alignment error traps

2009-06-09 Thread David Brownell
Tweak the csb337 code so that it doesn't enable alignment traps when it completes the "reset init" sequence. It turns out that the current CFI code reliably triggers such traps. I don't have time now to sort out what flavor bug that is; I just need flash reading/writing to work. --- tcl/board/csb

[Openocd-development] [patch] improve "poll" docs, and report bgnd polling status

2009-06-09 Thread David Brownell
Move the documentation for the "poll" command up with other server configuration. Explain what it's about; reference the related "$target_name curstate" method. Update "poll" output to report whether background polling is enabled or not. Also fix a small typo; PC's have "complementary" tools. So

Re: [Openocd-development] My source [find target, interface etc.] lines in my .cfg files don't work with latest build

2009-06-09 Thread Brian Hutchinson
On Tue, Jun 9, 2009 at 5:26 PM, Brian Hutchinson wrote: > I searched and saw the thread on find tcl/target etc. from a week ago but > can't figure out what is going on. Do we not use source [find > interface/jtagkey.cfg] type lines in our configs anymore? > > I guess I've missed something ... tou

Re: [Openocd-development] unable to open ftdi device

2009-06-09 Thread Rick Altherr
There is a udev rule file in the contrib folder. It's been a while since I've messed with Linux device nodes, but I believe the device will show up in /sys but udev needs to create the /dev node. -- Rick Altherr kc8...@kc8apf.net "He said he hadn't had a byte in three days. I had a short, so

Re: [Openocd-development] unable to open ftdi device

2009-06-09 Thread Paul Thomas
Paul, With my ft2232 device it shows up as /dev/usbdevX.Y_epZ. Did you build openocd with libftdi and/or ftd2xx support? Is libftdi or ftd2xx installed on your system? thanks, Paul On Tue, Jun 9, 2009 at 2:32 PM, Paul J THACKER wrote: > Hi, > > Openocd-0.1.0 on OpenSUSE 11.0 with Amontec jtagk

[Openocd-development] unable to open ftdi device

2009-06-09 Thread Paul J THACKER
Hi, Openocd-0.1.0 on OpenSUSE 11.0 with Amontec jtagkey-tiny: thack...@cea05:~/cartesio/eclipse/trunk> openocd -f jtagkey-tiny.cfg Open On-Chip Debugger 0.1.0 (2009-05-21-09:56) Release BUGS? Read http://svn.berlios.de/svnroot/repos/openocd/trunk/BUGS $URL: https://kc8...@svn.berlios.de/svnr

[Openocd-development] My source [find target, interface etc.] lines in my .cfg files don't work with latest build

2009-06-09 Thread Brian Hutchinson
I searched and saw the thread on find tcl/target etc. from a week ago but can't figure out what is going on. Do we not use source [find interface/jtagkey.cfg] type lines in our configs anymore? I guess I've missed something ... tough to be on vacation and come back to a full inbox :) Regards, B

Re: [Openocd-development] Idea on dr/irscan command handling

2009-06-09 Thread Øyvind Harboe
Having thought of the problem with asynchronous stuff like DCC feedback, I'm now leaning towards defining a macro that wraps dr/irscan sequences with poll off/on. I'm thinking that the entire reset procedure should be w/polling off too. -- Øyvind Harboe Embedded software and hardware consulting

Re: [Openocd-development] Problems with svn eol line endings and Cygwin when using Windows svn client

2009-06-09 Thread Rick Altherr
Don't know about this one though: ./tools/uncrustify1.sh Whose file is that? Dunno. Based on 'svn log', it looks like Rick's contribution. I am not a fan of automated cleanup tools (other than sed), so I am unlikely to try it. "Machines that can know good style... that'll be the d

Re: [Openocd-development] Idea on dr/irscan command handling

2009-06-09 Thread David Brownell
On Tuesday 09 June 2009, Øyvind Harboe wrote: > > And the only event of interest seems to be transitioning > > from a "running" or "debug-running" state ... to something > > else.  With the only listeners being the TCL shell, or in > > some cases GDB (when a breakpoint or watchpoint fires). > > Th

[Openocd-development] Numonyx Flash support?

2009-06-09 Thread Brian Hutchinson
I have a board with Numonyx 256M NOR (PC28F256M29). The version of OpenOCD I'm currently running (1470M) can query, probe, flash info etc., but can't program it for some reason. Has anyone used Numonyx flash with OpenOCD yet? Just wondering if support has been added up stream from me or if I nee

Re: [Openocd-development] Idea on dr/irscan command handling

2009-06-09 Thread Øyvind Harboe
> And the only event of interest seems to be transitioning > from a "running" or "debug-running" state ... to something > else.  With the only listeners being the TCL shell, or in > some cases GDB (when a breakpoint or watchpoint fires). There are other events: - the target can send messages via

Re: [Openocd-development] Jlink not running under cygwin [Working now]

2009-06-09 Thread Gene Smith
Gene Smith wrote: > I now get a successful build under cygwin. When I plug the jlink usb to > windows and run openocd I see the the "Cannot find jlink Interface!" > error as printed below. Do I need another special windows driver when > running jlink in cygwin? To build I only copied usb.h and l

Re: [Openocd-development] Idea on dr/irscan command handling

2009-06-09 Thread David Brownell
On Tuesday 09 June 2009, Øyvind Harboe wrote: > On Tue, Jun 9, 2009 at 7:37 PM, David Brownell wrote: > > On Tuesday 09 June 2009, Ųyvind Harboe wrote: > >> - make all reset event scripts run with background > >>   events disabled. > > > > Surprises me that's not already the case... > > > > Note th

Re: [Openocd-development] Idea on dr/irscan command handling

2009-06-09 Thread Øyvind Harboe
On Tue, Jun 9, 2009 at 7:37 PM, David Brownell wrote: > On Tuesday 09 June 2009, Ųyvind Harboe wrote: >> - make all reset event scripts run with background >>   events disabled. > > Surprises me that's not already the case... > > Note that output of "poll" doesn't say whether the timer > thing is a

Re: [Openocd-development] Idea on dr/irscan command handling

2009-06-09 Thread Magnus Lundin
Øyvind Harboe wrote: > Q: should dr/irscan throw an error if polling is enabled? > > OpenOCD does background polling based on a timer, so > two consecutive ir/drscan commands could see other > JTAG operations intervening, wreaking havoc. > > Targets such as the OMAP needs to run a sequence > of jta

Re: [Openocd-development] Idea on dr/irscan command handling

2009-06-09 Thread David Brownell
On Tuesday 09 June 2009, Øyvind Harboe wrote: > - make all reset event scripts run with background > events disabled. Surprises me that's not already the case... Note that output of "poll" doesn't say whether the timer thing is active. So it's pretty much hidden. Also, that the documentation

[Openocd-development] Idea on dr/irscan command handling

2009-06-09 Thread Øyvind Harboe
Q: should dr/irscan throw an error if polling is enabled? OpenOCD does background polling based on a timer, so two consecutive ir/drscan commands could see other JTAG operations intervening, wreaking havoc. Targets such as the OMAP needs to run a sequence of jtag commands uninterrupted. Some ide

Re: [Openocd-development] cygwin libtool: s/ECHO=/echo=/

2009-06-09 Thread Gene Smith
Zach Welch wrote: > On Tue, 2009-06-09 at 11:05 -0400, Gene Smith wrote: >> Zach Welch wrote: >>> On Tue, 2009-06-09 at 09:58 -0400, Gene Smith wrote: I think most of the problem I discovered building under cygwin have been addressed today. However, I still have the problem with trunk/li

[Openocd-development] Jlink not running under cygwin

2009-06-09 Thread Gene Smith
I now get a successful build under cygwin. When I plug the jlink usb to windows and run openocd I see the the "Cannot find jlink Interface!" error as printed below. Do I need another special windows driver when running jlink in cygwin? To build I only copied usb.h and libusb.a as directed from

Re: [Openocd-development] cygwin libtool: s/ECHO=/echo=/

2009-06-09 Thread Zach Welch
On Tue, 2009-06-09 at 11:05 -0400, Gene Smith wrote: > Zach Welch wrote: > > On Tue, 2009-06-09 at 09:58 -0400, Gene Smith wrote: > >> I think most of the problem I discovered building under cygwin have been > >> addressed today. However, I still have the problem with trunk/libtool > >> needing t

Re: [Openocd-development] cygwin libtool: s/ECHO=/echo=/

2009-06-09 Thread Gene Smith
Zach Welch wrote: > On Tue, 2009-06-09 at 09:58 -0400, Gene Smith wrote: >> I think most of the problem I discovered building under cygwin have been >> addressed today. However, I still have the problem with trunk/libtool >> needing to be modified manually to change ECHO= to echo=. Seems to be

Re: [Openocd-development] cygwin libtool: s/ECHO=/echo=/

2009-06-09 Thread Zach Welch
On Tue, 2009-06-09 at 09:58 -0400, Gene Smith wrote: > I think most of the problem I discovered building under cygwin have been > addressed today. However, I still have the problem with trunk/libtool > needing to be modified manually to change ECHO= to echo=. Seems to be > OK in linux. It appea

[Openocd-development] cygwin libtool: s/ECHO=/echo=/

2009-06-09 Thread Gene Smith
I think most of the problem I discovered building under cygwin have been addressed today. However, I still have the problem with trunk/libtool needing to be modified manually to change ECHO= to echo=. Seems to be OK in linux. It appears to be a mismatch between the libtool version on my linux

Re: [Openocd-development] Problems with svn eol line endings and Cygwin when using Windows svn client

2009-06-09 Thread Michael Bruck
On Tue, Jun 9, 2009 at 1:19 PM, Zach Welch wrote: > On Tue, 2009-06-09 at 12:29 +0200, Michael Bruck wrote: >> IIRC I had to set >> >> SHELLOPTS=igncr >> >> globally to force cygwin bash to work with CRLF scripts. On the other >> hand I suspect that option is what breaks the autotools generated >>

Re: [Openocd-development] Problems with svn eol line endings and Cygwin when using Windows svn client

2009-06-09 Thread Zach Welch
On Tue, 2009-06-09 at 13:26 +0200, Øyvind Harboe wrote: > BTW, I'm using Eclipse w/Subclipse and svnkit(java implementation > of svn). > > >> If you try to run a .sh file under Cygwin and that file has Windows > >> line endings, it will fail w/a syntax error. > > > > Even with the bash igncr optio

Re: [Openocd-development] make maintainer-clean is does not work when build != src dir

2009-06-09 Thread Zach Welch
On Tue, 2009-06-09 at 12:39 +0200, Øyvind Harboe wrote: > On Tue, Jun 9, 2009 at 12:24 PM, Zach Welch wrote: > > On Tue, 2009-06-09 at 12:00 +0200, Øyvind Harboe wrote: > >> I use a different build & openocd src dir, this means "make > >> maintainer-clean" does not work... > >> > >> Is this old new

Re: [Openocd-development] Problems with svn eol line endings and Cygwin when using Windows svn client

2009-06-09 Thread Øyvind Harboe
BTW, I'm using Eclipse w/Subclipse and svnkit(java implementation of svn). >> If you try to run a .sh file under Cygwin and that file has Windows >> line endings, it will fail w/a syntax error. > > Even with the bash igncr option? My problem with that(on behalf of users) is that how the "#!¤&"#¤&

Re: [Openocd-development] Problems with svn eol line endings and Cygwin when using Windows svn client

2009-06-09 Thread Zach Welch
On Tue, 2009-06-09 at 12:29 +0200, Michael Bruck wrote: > IIRC I had to set > > SHELLOPTS=igncr > > globally to force cygwin bash to work with CRLF scripts. On the other > hand I suspect that option is what breaks the autotools generated > configure file for me. So I "correct" configure manually

Re: [Openocd-development] Problems with svn eol line endings and Cygwin when using Windows svn client

2009-06-09 Thread Zach Welch
On Tue, 2009-06-09 at 13:07 +0200, Øyvind Harboe wrote: > On Tue, Jun 9, 2009 at 1:02 PM, Zach Welch wrote: > > On Tue, 2009-06-09 at 12:54 +0200, Øyvind Harboe wrote: > >> > Some more information about the subject: > >> > > >> > http://www.cygwin.com/ml/cygwin/2008-12/msg00525.html > >> > > >> >

Re: [Openocd-development] Problems with svn eol line endings and Cygwin when using Windows svn client

2009-06-09 Thread Øyvind Harboe
On Tue, Jun 9, 2009 at 1:02 PM, Zach Welch wrote: > On Tue, 2009-06-09 at 12:54 +0200, Øyvind Harboe wrote: >> > Some more information about the subject: >> > >> >  http://www.cygwin.com/ml/cygwin/2008-12/msg00525.html >> > >> > I particularly like the postscript. :)  We are not alone here. >> >> I

Re: [Openocd-development] Problems with svn eol line endings and Cygwin when using Windows svn client

2009-06-09 Thread Zach Welch
On Tue, 2009-06-09 at 12:54 +0200, Øyvind Harboe wrote: > > Some more information about the subject: > > > > http://www.cygwin.com/ml/cygwin/2008-12/msg00525.html > > > > I particularly like the postscript. :) We are not alone here. > > I'm just going to close my eyes and hope I never hear of th

Re: [Openocd-development] Problems with svn eol line endings and Cygwin when using Windows svn client

2009-06-09 Thread Øyvind Harboe
> Some more information about the subject: > >  http://www.cygwin.com/ml/cygwin/2008-12/msg00525.html > > I particularly like the postscript. :)  We are not alone here. I'm just going to close my eyes and hope I never hear of this again :-) I've grepped the source tree and "guess-rev.sh" was the

Re: [Openocd-development] Problems with svn eol line endings and Cygwin when using Windows svn client

2009-06-09 Thread Zach Welch
On Tue, 2009-06-09 at 11:58 +0200, Øyvind Harboe wrote: > I've had a bit of problems with Cygwin and svn eol native > option. > > I thought I understood what was going on and I went ahead and > did some changes to svn head, but I have since discovered that > I do *not* understand what's going on s

Re: [Openocd-development] make maintainer-clean is does not work when build != src dir

2009-06-09 Thread Øyvind Harboe
On Tue, Jun 9, 2009 at 12:24 PM, Zach Welch wrote: > On Tue, 2009-06-09 at 12:00 +0200, Øyvind Harboe wrote: >> I use a different build & openocd src dir, this means "make >> maintainer-clean" does not work... >> >> Is this old news? >> >> This is reproduceable under Linux as well as Cygwin. >> >>

Re: [Openocd-development] Problems with svn eol line endings and Cygwin when using Windows svn client

2009-06-09 Thread Michael Bruck
IIRC I had to set SHELLOPTS=igncr globally to force cygwin bash to work with CRLF scripts. On the other hand I suspect that option is what breaks the autotools generated configure file for me. So I "correct" configure manually whenever it is regenerated by replacing '\\r' (see full-text search) w

Re: [Openocd-development] make maintainer-clean is does not work when build != src dir

2009-06-09 Thread Zach Welch
On Tue, 2009-06-09 at 12:00 +0200, Øyvind Harboe wrote: > I use a different build & openocd src dir, this means "make > maintainer-clean" does not work... > > Is this old news? > > This is reproduceable under Linux as well as Cygwin. > > I tricked myself into believing that "make maintainer-clea

[Openocd-development] make maintainer-clean is does not work when build != src dir

2009-06-09 Thread Øyvind Harboe
I use a different build & openocd src dir, this means "make maintainer-clean" does not work... Is this old news? This is reproduceable under Linux as well as Cygwin. I tricked myself into believing that "make maintainer-clean" worked from the build directory at some point and confused that with

[Openocd-development] Problems with svn eol line endings and Cygwin when using Windows svn client

2009-06-09 Thread Øyvind Harboe
I've had a bit of problems with Cygwin and svn eol native option. I thought I understood what was going on and I went ahead and did some changes to svn head, but I have since discovered that I do *not* understand what's going on so svn head is a bit in limbo... 1. "guess-rev.sh" was busted becaus

[Openocd-development] to extern, or not to extern?

2009-06-09 Thread Zach Welch
Hi all, I want to remove the 'extern' keyword from all function prototypes. The extern keyword is redundant in such contexts, adds bulk, and visually make its difficult to spot "real" extern declarations. Some may have noticed that I have already stopped adding them to new functions that I am def

[Openocd-development] Problems with make maintainer-clean

2009-06-09 Thread Øyvind Harboe
I've tried to figure out why ltmain.sh does not get deleted when checking out OpenOCD using Eclipse and building it under Cygwin. For a while I thought it was because Makefile.am used svn native line endings, but that wasn't it. I'll give up on this for now, but at least anyone else running int

Re: [Openocd-development] assert vs. error messages

2009-06-09 Thread Øyvind Harboe
I'm satisfied that I've put the performance issue with checking at too low a level on the radar. I'll leave this to Zach's judgement (he's the one who's working on it currently), but I'm reserving the right to raise an objection later based on measured performance problems(referring to Rick pointi

Re: [Openocd-development] assert vs. error messages

2009-06-09 Thread David Brownell
On Monday 08 June 2009, Zach Welch wrote: > Basically, the JTAG library should not make policy to abort, if it will > be used by script commands. Right, it should not be possible for anything done by a client to cause the server to crash. ___ Openocd-de

Re: [Openocd-development] assert vs. error messages

2009-06-09 Thread Rick Altherr
On Jun 8, 2009, at 11:51 PM, Øyvind Harboe wrote: On Tue, Jun 9, 2009 at 8:29 AM, Zach Welch wrote: On Tue, 2009-06-09 at 07:57 +0200, Øyvind Harboe wrote: How about a clearer policy of using assert()'s? I'm thinking that error()'s should be reserved for "real" runtime errors.

Re: [Openocd-development] assert vs. error messages

2009-06-09 Thread Øyvind Harboe
jtag_add_pathmove() is not a high performance API, so here runtime (debugging or otherwise) checks do not really affect anything much. A better example would be jtag_add_dr_out(). Here I don't want lots of runtime checks as this is used in the innermost loops. All checks on userdata must happen hi

Re: [Openocd-development] assert vs. error messages

2009-06-09 Thread Zach Welch
On Tue, 2009-06-09 at 08:51 +0200, Øyvind Harboe wrote: > On Tue, Jun 9, 2009 at 8:29 AM, Zach Welch wrote: > > On Tue, 2009-06-09 at 07:57 +0200, Øyvind Harboe wrote: > >> How about a clearer policy of using assert()'s? > >> > >> I'm thinking that error()'s should be reserved for "real" runtime er