Re: [Openocd-development] Segfault in SVN 1743+

2009-05-11 Thread Øyvind Harboe
Fix committed. irscan has always been badly broken. I wonder if it has ever been used -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com ___ Openocd-development mailing list Openocd-development@lists.be

[Openocd-development] fix ancient bug & SEGFAULT in irscan

2009-05-11 Thread Øyvind Harboe
I couldn't believe my eyes when I saw what the bug was. irscan has *always* been broken. I checked as far back as svn 345. A couple of possible explanations: - irscan has never really been used - events have somehow conspired to hide the bugs - I'm missing something Known problems in irscan: -

[Openocd-development] trunk broken since rev 1730 (segfault)

2009-05-11 Thread Nicolas Pitre
This is a really nasty breakage since the symptom consists of stack corruption. In my case, I was able to observe the problem by adding some printf's in src/flash/nand.c with the execution path below. src/flash/nand.c, line 1200, in handle_nand_erase_command(): p = get_nand_device_by_

Re: [Openocd-development] doxygen update

2009-05-11 Thread Nico Coesel
> >On Mon, 2009-05-11 at 10:08 +0200, Nico Coesel wrote: >> Zach, >> I'm a little concerned here. I've seen many doxygen generated API >> 'reference' manuals. Most of them are useless because they don't >> describe why a certain function is there and what its relation is to >> other functions. Do

Re: [Openocd-development] svn head build issues

2009-05-11 Thread Øyvind Harboe
On Mon, May 11, 2009 at 9:44 PM, Nicolas Pitre wrote: > On Mon, 11 May 2009, Øyvind Harboe wrote: > >> OK. >> >> Try patch attached. Builds on Cygwin(x86 32 bits). > > Works for me on x86-64. Committed. Thanks! -- Øyvind Harboe Embedded software and hardware consulting services http://consultin

Re: [Openocd-development] svn head build issues

2009-05-11 Thread Nicolas Pitre
On Mon, 11 May 2009, Øyvind Harboe wrote: > OK. > > Try patch attached. Builds on Cygwin(x86 32 bits). Works for me on x86-64. Nicolas ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo

Re: [Openocd-development] Beagleboard EMU0 EMU1

2009-05-11 Thread Dirk Behme
Rick Altherr wrote: > > On May 10, 2009, at 11:43 PM, Laurent Gauch wrote: > >> Hi all BeagleBoard + OpenOCD users, >> >> What is the setup for Emu0 Emu1 pin : >> - need both left open >> - need both EMU0 EMU1 pull-down resistors >> - need EMU0 pull-down resistors ... ... > My recollection of thi

Re: [Openocd-development] svn head build issues

2009-05-11 Thread Øyvind Harboe
OK. Try patch attached. Builds on Cygwin(x86 32 bits). -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com Index: C:/workspace/openocd/src/jtag/jtag.c === --- C:/workspace/openocd/src/jtag

Re: [Openocd-development] missing ltmain.sh? notes on r1695

2009-05-11 Thread Zach Welch
On Mon, 2009-05-11 at 10:22 -0700, Rick Altherr wrote: > On May 11, 2009, at 7:15 AM, Spencer Oliver wrote: > > >> This one-time step comes from the addition of the > >> AC_PROG_LIBTOOL macro. > >> It will be performed automatically in the bootstrap script > >> for newly checked out working copies

Re: [Openocd-development] svn head build issues

2009-05-11 Thread Zach Welch
Exactly. This is what that type was designed to do. On Mon, 2009-05-11 at 18:16 +0100, Nick Brereton wrote: > How about C99's intptr_t ? > > -Original Message- > From: openocd-development-boun...@lists.berlios.de > [mailto:openocd-development-boun...@lists.berlios.de] On Behalf Of David

Re: [Openocd-development] missing ltmain.sh? notes on r1695

2009-05-11 Thread Rick Altherr
On May 11, 2009, at 7:15 AM, Spencer Oliver wrote: This one-time step comes from the addition of the AC_PROG_LIBTOOL macro. It will be performed automatically in the bootstrap script for newly checked out working copies. Sorry for the inconvenience. Any reason for the libtool change? I have

Re: [Openocd-development] svn head build issues

2009-05-11 Thread Nick Brereton
How about C99's intptr_t ? -Original Message- From: openocd-development-boun...@lists.berlios.de [mailto:openocd-development-boun...@lists.berlios.de] On Behalf Of David Brownell Sent: 11 May 2009 18:12 To: Øyvind Harboe Cc: openocd-development@lists.berlios.de Subject: Re: [Openocd-deve

Re: [Openocd-development] svn head build issues

2009-05-11 Thread David Brownell
On Monday 11 May 2009, Øyvind Harboe wrote: > >> so I could either go with a union or these fancy games. > > > > How about using a design that doesn't rely on type punning? > > > > It'll be more clear to read/understand, and less fragile for > > folk using "other" systems (e.g. 64-bit) and for deve

Re: [Openocd-development] svn head build issues

2009-05-11 Thread Øyvind Harboe
>> so I could either go with a union or these fancy games. > > How about using a design that doesn't rely on type punning? > > It'll be more clear to read/understand, and less fragile for > folk using "other" systems (e.g. 64-bit) and for developers. union? -- Øyvind Harboe Embedded software and

Re: [Openocd-development] svn head build issues

2009-05-11 Thread David Brownell
On Monday 11 May 2009, Øyvind Harboe wrote: > I'm using a single callback function prototype w/4 arguments. Sometime > an argument is an "int"'s other times a pointer, Ugly... If it has to be a pointer sometimes, make it *always* a pointer. You can generally convert int->pointer without losing bi

Re: [Openocd-development] Segfault in SVN 1743+

2009-05-11 Thread Øyvind Harboe
I can reproduce this crash using the dummy interface and the attached file. It's not quite obvious what's going on, but since it crashes every time it probably won't be too hard to figure out... openocd -f test.cfg -- Øyvind Harboe Embedded software and hardware consulting services http://cons

Re: [Openocd-development] svn head build issues

2009-05-11 Thread Øyvind Harboe
On Mon, May 11, 2009 at 6:21 PM, Nicolas Pitre wrote: > On Mon, 11 May 2009, Øyvind Harboe wrote: > >> > /* >> >  * We don't care about the real pointer but only the low 32 bits of it >> >  * for some funky hash lookup.  The double cast removes warnings on >> >  * 64-bit machines. >> >  */ >> > #d

Re: [Openocd-development] svn head build issues

2009-05-11 Thread Nicolas Pitre
On Mon, 11 May 2009, Øyvind Harboe wrote: > > /* > >  * We don't care about the real pointer but only the low 32 bits of it > >  * for some funky hash lookup.  The double cast removes warnings on > >  * 64-bit machines. > >  */ > > #define PTR_TO_HASH(X) ((int)(long)(x)) > > Any reason not to use

Re: [Openocd-development] Beagleboard EMU0 EMU1

2009-05-11 Thread Rick Altherr
On May 10, 2009, at 11:43 PM, Laurent Gauch wrote: Hi all BeagleBoard + OpenOCD users, What is the setup for Emu0 Emu1 pin : - need both left open - need both EMU0 EMU1 pull-down resistors - need EMU0 pull-down resistors ... Regards, Laurent Gauch http://www.amontec.com

Re: [Openocd-development] svn head build issues

2009-05-11 Thread Øyvind Harboe
> /* >  * We don't care about the real pointer but only the low 32 bits of it >  * for some funky hash lookup.  The double cast removes warnings on >  * 64-bit machines. >  */ > #define PTR_TO_HASH(X) ((int)(long)(x)) Any reason not to use an inline fn? That would throw in some typechecking W

Re: [Openocd-development] svn head build issues

2009-05-11 Thread Nicolas Pitre
On Mon, 11 May 2009, Nicolas Pitre wrote: > On Mon, 11 May 2009, Øyvind Harboe wrote: > > > 2009/5/11 Nicolas Pitre : > > > > > > cc1: warnings being treated as errors > > > jtag.c: In function ‘jtag_check_value_mask_callback': > > > jtag.c:703: error: cast from pointer to integer of different si

Re: [Openocd-development] svn head build issues

2009-05-11 Thread Nicolas Pitre
On Mon, 11 May 2009, Øyvind Harboe wrote: > On Mon, May 11, 2009 at 5:25 PM, Nicolas Pitre wrote: > > On Mon, 11 May 2009, Øyvind Harboe wrote: > > > >> 2009/5/11 Nicolas Pitre : > >> > > >> > cc1: warnings being treated as errors > >> > jtag.c: In function ‘jtag_check_value_mask_callback': > >>

Re: [Openocd-development] Segfault in SVN 1743+

2009-05-11 Thread Øyvind Harboe
As a workaround: try "verify_ircapture disable" That disables the code I broke in 1743 (which I'll fix of course...) -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com ___ Openocd-development mailing li

Re: [Openocd-development] svn head build issues

2009-05-11 Thread Øyvind Harboe
On Mon, May 11, 2009 at 5:25 PM, Nicolas Pitre wrote: > On Mon, 11 May 2009, Øyvind Harboe wrote: > >> 2009/5/11 Nicolas Pitre : >> > >> > cc1: warnings being treated as errors >> > jtag.c: In function ‘jtag_check_value_mask_callback': >> > jtag.c:703: error: cast from pointer to integer of differ

[Openocd-development] Segfault in SVN 1743+

2009-05-11 Thread Strontium
Hi, Testing my openocd scripts on any version above or equal to 1743 results in a segfault. I am trying to work on OMAP3 support this instruction from my script causes the segfault: jtag tapenable omap3.cpu If no one has any ideas what it could be I will look deeper into it tomorrow. da

Re: [Openocd-development] svn head build issues

2009-05-11 Thread Nicolas Pitre
On Mon, 11 May 2009, Øyvind Harboe wrote: > 2009/5/11 Nicolas Pitre : > > > > cc1: warnings being treated as errors > > jtag.c: In function ‘jtag_check_value_mask_callback': > > jtag.c:703: error: cast from pointer to integer of different size > > jtag.c: In function ‘jtag_add_scan_check': > > jta

Re: [Openocd-development] svn head build issues

2009-05-11 Thread Øyvind Harboe
2009/5/11 Nicolas Pitre : > > cc1: warnings being treated as errors > jtag.c: In function ‘jtag_check_value_mask_callback': > jtag.c:703: error: cast from pointer to integer of different size > jtag.c: In function ‘jtag_add_scan_check': > jtag.c:740: error: cast to pointer from integer of different

[Openocd-development] svn head build issues

2009-05-11 Thread Nicolas Pitre
cc1: warnings being treated as errors jtag.c: In function ‘jtag_check_value_mask_callback': jtag.c:703: error: cast from pointer to integer of different size jtag.c: In function ‘jtag_add_scan_check': jtag.c:740: error: cast to pointer from integer of different size ___

[Openocd-development] ftdi_set_interface correctness patch

2009-05-11 Thread Strontium
Hi, I discovered this little correctness bug when messing with trying to work out why my flyswatter was unreliable. in ft2232.c ftdi_set_interface needs to be called to set the active interface BEFORE ftdi_usb_open_desc, because ftdi_usb_open_desc needs to know which interface to open. Th

Re: [Openocd-development] missing ltmain.sh? notes on r1695

2009-05-11 Thread Spencer Oliver
> This one-time step comes from the addition of the > AC_PROG_LIBTOOL macro. > It will be performed automatically in the bootstrap script > for newly checked out working copies. Sorry for the inconvenience. > Any reason for the libtool change? I have also noticed the build takes quite a bit lo

Re: [Openocd-development] Amontec JTAGkey issues

2009-05-11 Thread Alan Carvalho de Assis
On 5/8/09, Alan Carvalho de Assis wrote: > Hi list, > > I am trying to get an Amontec JTAGkey working with OpenOCD on Ubuntu > 8.10, but I have no success. > > I tried too old revision as 516 with no success, I followed this tutorial: > http://docs.tinyos.net/index.php/OpenOCD_for_IMote2 > > I use

[Openocd-development] USB performance regressions fixed

2009-05-11 Thread Øyvind Harboe
The USB performance regressions should now be fixed(including those w/verify_ircapture enabled). -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com ___ Openocd-development mailing list Openocd-development@lis

Re: [Openocd-development] massive #include reductions

2009-05-11 Thread Zach Welch
On Mon, 2009-05-11 at 10:16 +0200, Michael Bruck wrote: > The patches break compile on cygwin. Please apply the attached patch > to fix this. > > The log message is essentially the same as with r1573: > Michael Bruck : sys/select.h must preceed windows.h. > > The patch also changes "windows.h" to

Re: [Openocd-development] doxygen update

2009-05-11 Thread Zach Welch
On Mon, 2009-05-11 at 10:08 +0200, Nico Coesel wrote: > Zach, > I'm a little concerned here. I've seen many doxygen generated API > 'reference' manuals. Most of them are useless because they don't > describe why a certain function is there and what its relation is to > other functions. Doxygen is a

Re: [Openocd-development] massive #include reductions

2009-05-11 Thread Michael Bruck
The patches break compile on cygwin. Please apply the attached patch to fix this. The log message is essentially the same as with r1573: Michael Bruck : sys/select.h must preceed windows.h. The patch also changes "windows.h" to similar to how it's used in replacements.h Michael On Mon, May 11,

Re: [Openocd-development] doxygen update

2009-05-11 Thread Nico Coesel
Zach, I'm a little concerned here. I've seen many doxygen generated API 'reference' manuals. Most of them are useless because they don't describe why a certain function is there and what its relation is to other functions. Doxygen is a fine tool to get a list of functions and their parameters but t

[Openocd-development] doxygen update

2009-05-11 Thread Zach Welch
Hi all, As a consequence of my recent clean-up work, I turned on some of the basic GraphViz features in doxygen. This feature can be turned off by change the HAVE_DOT Doxyfile setting from YES to NO. Its file dependency graphs are now much more insightful than before I started my clean-up, so I