On Fri, 31 Jan 2025 12:37:04 GMT, Lukasz Kostyra wrote:
> This is a cleanup follow-up, removing `FontFileWriter.FontTracker` and all
> related uses. `FontTracker` was tracking font size use when SecurityManager
> was present, however since we removed SM, `FontTracker` was no longer
> activated
On Fri, 31 Jan 2025 12:37:04 GMT, Lukasz Kostyra wrote:
> This is a cleanup follow-up, removing `FontFileWriter.FontTracker` and all
> related uses. `FontTracker` was tracking font size use when SecurityManager
> was present, however since we removed SM, `FontTracker` was no longer
> activated
On Fri, 31 Jan 2025 12:37:04 GMT, Lukasz Kostyra wrote:
> This is a cleanup follow-up, removing `FontFileWriter.FontTracker` and all
> related uses. `FontTracker` was tracking font size use when SecurityManager
> was present, however since we removed SM, `FontTracker` was no longer
> activated
This is a cleanup follow-up, removing `FontFileWriter.FontTracker` and all
related uses. `FontTracker` was tracking font size use when SecurityManager was
present, however since we removed SM, `FontTracker` was no longer activated and
as such was dead code.
`FontFileWriter.FontTracker` and its
On Fri, 31 Jan 2025 02:37:42 GMT, Michael Strauß wrote:
> When the current editor value of a `ComboBox` is added to its items list, the
> editor value may be changed to an entirely unrelated item in the list.
> However, our expectation would be that the editor reflects the newly added
> item i
> When the current editor value of a `ComboBox` is added to its items list, the
> editor value may be changed to an entirely unrelated item in the list.
> However, our expectation would be that the editor reflects the newly added
> item instead.
>
> Under normal circumstances, adding items to t
On Fri, 31 Jan 2025 17:27:47 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> update copyright header
>
> modules/javafx.controls/src/main/java/javafx/scene/control/ListView.java line
> 1315:
On Fri, 31 Jan 2025 19:41:06 GMT, Kevin Rushforth wrote:
> What testing have you done?
All disabled tests fail on my mac, I did not run the CI job (no need, I know
they fail).
Additionally, I ran the CI job with the tests disabled - this test runs fine
(there were some unrelated failures on so
On Fri, 31 Jan 2025 20:07:38 GMT, Andy Goryachev wrote:
>> tests/system/src/test/java/test/robot/javafx/scene/NodeInitializationBackgroundThreadTest.java
>> line 305:
>>
>>> 303: return c;
>>> 304: }, (c) -> {
>>> 305: c.show(); // fails here
>>
>> As mentioned
On Fri, 31 Jan 2025 20:54:31 GMT, Andy Goryachev wrote:
>> Created a test that validates various Nodes can be initialized in a
>> background thread.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> review comments
tests/
On Wed, 29 Jan 2025 23:54:44 GMT, Andy Goryachev wrote:
> Created a test that validates various Nodes can be initialized in a
> background thread.
I like the overall structure of this test. I left several mostly "fit and
finish" type comments.
I will test it as part of finishing the review. W
On Fri, 31 Jan 2025 19:49:02 GMT, Andy Goryachev wrote:
> > What testing have you done?
>
> All disabled tests fail on my mac, I did not run the CI job (no need, I know
> they fail). Additionally, I ran the CI job with the tests disabled - this
> test runs fine (there were some unrelated failu
On Fri, 31 Jan 2025 19:36:02 GMT, Kevin Rushforth wrote:
>> Created a test that validates various Nodes can be initialized in a
>> background thread.
>
> tests/system/src/test/java/test/robot/javafx/scene/NodeInitializationBackgroundThreadTest.java
> line 779:
>
>> 777:
>> 778: private st
On Thu, 16 Jan 2025 16:04:17 GMT, Marius Hanl wrote:
>> This PR fixes the horizontal virtualization performed in the
>> `TableRowSkinBase`, which significantly improves performance with many
>> columns (and thus many cells). Scrolling up and down as well as scrolling
>> left and right feels mu
> Implementation of
> [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09)
> and `EXTENDED_UTILITY` stage style.
Michael Strauß has updated the pull request incrementally with one additional
commit since the last revision:
added StageTester to MonkeyTester
--
On Thu, 30 Jan 2025 23:02:36 GMT, Andy Goryachev wrote:
>> Modified the resize algorithm to work well with fractional scale, thanks for
>> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>>
>> Removed earlier manual tester in favor of the monkey tester.
>>
>> It is important
On Fri, 31 Jan 2025 21:09:12 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> tests/system/src/test/java/test/robot/javafx/scene/NodeInitializationBackgroundThreadTest.java
On Fri, 31 Jan 2025 19:18:17 GMT, Michael Strauß wrote:
>> When the current editor value of a `ComboBox` is added to its items list,
>> the editor value may be changed to an entirely unrelated item in the list.
>> However, our expectation would be that the editor reflects the newly added
>> it
> Created a test that validates various Nodes can be initialized in a
> background thread.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
better name
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1690/files
On Tue, 4 Apr 2023 15:22:48 GMT, John Hendrikx wrote:
> This provides and uses a new implementation of `ExpressionHelper`, called
> `ListenerManager` with improved semantics.
>
> # Behavior
>
> |Listener...|ExpressionHelper|ListenerManager|
> |---|---|---|
> |Invocation Order|In order they wer
> Created a test that validates various Nodes can be initialized in a
> background thread.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
review comments
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1690/file
On Fri, 31 Jan 2025 20:00:17 GMT, Kevin Rushforth wrote:
> It's a Friday and your system is tired after a long week?
It is also raining today...
-
PR Comment: https://git.openjdk.org/jfx/pull/1690#issuecomment-2628374259
On Fri, 31 Jan 2025 23:02:35 GMT, Andy Goryachev wrote:
>> I think this change is why the Tooltip test is no longer failing. The
>> failure mode reported in
>> [JDK-8348100](https://bugs.openjdk.org/browse/JDK-8348100) happens when
>> constructing Tooltip on a background thread.
>
> The very
> Created a test that validates various Nodes can be initialized in a
> background thread.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
fast loop
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1690/files
-
On Fri, 31 Jan 2025 21:39:12 GMT, Kevin Rushforth wrote:
>> tests/system/src/test/java/test/robot/javafx/scene/NodeInitializationBackgroundThreadTest.java
>> line 732:
>>
>>> 730: private void test(Supplier generator,
>>> Consumer operation) {
>>> 731: AtomicReference ref = new At
On Fri, 31 Jan 2025 18:34:29 GMT, Kevin Rushforth wrote:
>> Created a test that validates various Nodes can be initialized in a
>> background thread.
>
> tests/system/src/test/java/test/robot/testharness/RobotTestBase.java line 81:
>
>> 79: @AfterAll
>> 80: public static void teardownOn
On Fri, 31 Jan 2025 20:05:01 GMT, Andy Goryachev wrote:
>> tests/system/src/test/java/test/robot/javafx/scene/NodeInitializationBackgroundThreadTest.java
>> line 755:
>>
>>> 753: inFx(() -> {
>>> 754: operation.accept(v
On Fri, 31 Jan 2025 19:16:44 GMT, Kevin Rushforth wrote:
>> Created a test that validates various Nodes can be initialized in a
>> background thread.
>
> tests/system/src/test/java/test/robot/javafx/scene/NodeInitializationBackgroundThreadTest.java
> line 305:
>
>> 303: return c;
>
28 matches
Mail list logo
