On Fri, 31 Jan 2025 18:34:29 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Created a test that validates various Nodes can be initialized in a
>> background thread.
>
> tests/system/src/test/java/test/robot/testharness/RobotTestBase.java line 81:
>
>> 79: @AfterAll
>> 80: public static void teardownOnce() {
>> 81: Util.shutdown();
>
> Should you pass "stage" here, or do you ensure that the stage is always
> closed some other way?
No, this method closes all the open stages.
> tests/system/src/test/java/test/robot/testharness/RobotTestBase.java line 183:
>
>> 181: * @param milliseconds the number of milliseconds to sleep
>> 182: */
>> 183: protected void sleep(int milliseconds) {
>
> Maybe use `long` rather than `int` to match `Thread.sleep` and `Util.sleep`?
> It probably doesn't matter in practice.
it does not matter, no test should run 23 days
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1690#discussion_r1937904580
PR Review Comment: https://git.openjdk.org/jfx/pull/1690#discussion_r1937912338
