On Fri, 31 Jan 2025 20:05:01 GMT, Andy Goryachev <[email protected]> wrote:
>> tests/system/src/test/java/test/robot/javafx/scene/NodeInitializationBackgroundThreadTest.java
>> line 755:
>>
>>> 753: inFx(() -> {
>>> 754: operation.accept(visibleNode);
>>> 755: });
>>
>> Does this need to be done for each thread? I can see why it might make sense
>> to do that, as it preserves the relative frequency of operations on the FX
>> app thread versus the frequency off thread regardless of how many threads
>> you have. It would risk flooding the FX event queue if the number of
>> background threads were huge, but you limit it based on the number of
>> physical HW threads, so this seems OK.
>
> yes, jiggling the visible node during the test adds stress to the system,
> which is the intended behavior.
Yes, I know. I was pointing out the fact that the frequency of the jitter will
increase as the number of background threads increases. Which I think is fine.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1690#discussion_r1937928906
