On Fri, 31 Jan 2025 20:54:31 GMT, Andy Goryachev <[email protected]> wrote:
>> Created a test that validates various Nodes can be initialized in a
>> background thread.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> review comments
tests/system/src/test/java/test/robot/javafx/scene/NodeInitializationBackgroundThreadTest.java
line 732:
> 730: private <T extends Node> void test(Supplier<T> generator,
> Consumer<T> operation) {
> 731: AtomicReference<T> ref = new AtomicReference();
> 732: runAndWait(() -> {
What was the rationale for this change? This means we are no longer testing the
ability to construct a node off thread.
Related to this, I think a separate set of tests where we construct instances
of the node in a loop would be useful, in addition to the set of tests that
mutates the node in a loop.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1690#discussion_r1937983747
