Re: RFR: 8183521: Unable to type characters with tilde with swiss german keyboard layout [v2]

2024-10-01 Thread Andy Goryachev
On Tue, 1 Oct 2024 20:17:52 GMT, Martin Fox wrote: >> The glass code on Windows does its own dead key processing so at certain >> points it must clear the dead key state that the OS is maintaining. It does >> this by simulating a SPACE key press but this only works reliably if the >> SPACE key

Re: RFR: 8183521: Unable to type characters with tilde with swiss german keyboard layout [v2]

2024-10-01 Thread Martin Fox
On Tue, 1 Oct 2024 20:17:52 GMT, Martin Fox wrote: >> The glass code on Windows does its own dead key processing so at certain >> points it must clear the dead key state that the OS is maintaining. It does >> this by simulating a SPACE key press but this only works reliably if the >> SPACE key

Re: RFR: 8301121: RichTextArea Control (Incubator) [v17]

2024-10-01 Thread Andy Goryachev
On Tue, 1 Oct 2024 15:46:23 GMT, Andy Goryachev wrote: >> Incubating a new feature - rich text control, **RichTextArea**, intended to >> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. >> The main design goal is to provide a control that is complete enough to be >> us

Re: RFR: 8340852: ScrollPane should not consume navigation keys when it doesn't have direct focus

2024-10-01 Thread John Hendrikx
On Tue, 1 Oct 2024 19:50:44 GMT, Andy Goryachev wrote: > > Here is a minimal working example > > Very helpful, thank you. > > I would say the use of arrow keys to traverse focus in this case _looks to > me_ to be application-specific. In other words, this may or may not be the > desired behav

Re: RFR: 8301121: RichTextArea Control (Incubator) [v15]

2024-10-01 Thread Kevin Rushforth
On Tue, 1 Oct 2024 15:30:39 GMT, Andy Goryachev wrote: >> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/RichTextArea.java >> line 1166: >> >>> 1164: * This method does nothing if the model or the caret position is >>> {@code null}. >>> 1165: * The

Re: RFR: 8301121: RichTextArea Control (Incubator) [v15]

2024-10-01 Thread Kevin Rushforth
On Tue, 1 Oct 2024 15:33:26 GMT, Andy Goryachev wrote: > > I think the following behavior is probably what we want for RichTextArea > > (control) methods: > > I fully agree. > > I believe this is how it currently works (unless I missed a spot). Good. I think it's just `cut` that has a problem

Re: RFR: 8301121: RichTextArea Control (Incubator) [v7]

2024-10-01 Thread Kevin Rushforth
On Tue, 1 Oct 2024 15:15:12 GMT, Andy Goryachev wrote: >> This is still pending, since the docs haven't been updated. Is an exception >> really what you want in this case? This method is the target of a function >> tag: We definitely don't want to produce an exception when the user presses >>

Re: RFR: 8301121: RichTextArea Control (Incubator) [v17]

2024-10-01 Thread Kevin Rushforth
On Tue, 1 Oct 2024 15:46:23 GMT, Andy Goryachev wrote: >> Incubating a new feature - rich text control, **RichTextArea**, intended to >> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. >> The main design goal is to provide a control that is complete enough to be >> us

Re: RFR: 8301121: RichTextArea Control (Incubator) [v17]

2024-10-01 Thread Andy Goryachev
On Tue, 1 Oct 2024 16:06:56 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 26 commits: >> >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - whitespace

Re: RFR: 8301121: RichTextArea Control (Incubator) [v15]

2024-10-01 Thread Andy Goryachev
On Mon, 30 Sep 2024 21:52:33 GMT, Kevin Rushforth wrote: > I think the following behavior is probably what we want for RichTextArea > (control) methods: I fully agree. I believe this is how it currently works (unless I missed a spot). > modules/jfx.incubator.richtext/src/main/java/jfx/incubat

Re: RFR: 8301121: RichTextArea Control (Incubator) [v16]

2024-10-01 Thread Andy Goryachev
> Incubating a new feature - rich text control, **RichTextArea**, intended to > bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The > main design goal is to provide a control that is complete enough to be useful > out-of-the box, as well as open to extension by the appl

Re: RFR: 8301121: RichTextArea Control (Incubator) [v7]

2024-10-01 Thread Andy Goryachev
On Mon, 30 Sep 2024 20:57:30 GMT, Kevin Rushforth wrote: >> changed this and similar methods to throw an exception > > This is still pending, since the docs haven't been updated. Is an exception > really what you want in this case? This method is the target of a function > tag: We definitely do

Re: RFR: 8332895: Support interpolation for backgrounds and borders [v43]

2024-10-01 Thread John Hendrikx
On Fri, 27 Sep 2024 22:22:27 GMT, Michael Strauß wrote: >> This PR completes the CSS Transitions story (see #870) by adding >> interpolation support for backgrounds and borders, making them targetable by >> transitions. >> >> `Background` and `Border` objects are deeply immutable, but not >>

Re: RFR: 8340852: ScrollPane should not consume navigation keys when it doesn't have direct focus

2024-10-01 Thread John Hendrikx
On Mon, 30 Sep 2024 16:27:50 GMT, Andy Goryachev wrote: > I do not see much behavioral difference between controls inside a regular > VBox and VBox inside a ScrollPane > > https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/research/FocusPolicyResearch.java > > Am I doing thi

Re: RFR: 8301121: RichTextArea Control (Incubator) [v17]

2024-10-01 Thread Andy Goryachev
> Incubating a new feature - rich text control, **RichTextArea**, intended to > bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The > main design goal is to provide a control that is complete enough to be useful > out-of-the box, as well as open to extension by the appl

Re: RFR: 8340852: ScrollPane should not consume navigation keys when it doesn't have direct focus

2024-10-01 Thread John Hendrikx
On Thu, 26 Sep 2024 21:17:55 GMT, John Hendrikx wrote: > This change modifies `ScrollPaneBehavior` to only consume keys that are > targetted at it. As `KeyEvent`s are in almost all cases only intended for > the targetted node (as visually that's where the user expects the keyboard > input to

Re: RFR: 8301121: RichTextArea Control (Incubator) [v7]

2024-10-01 Thread Andy Goryachev
On Mon, 30 Sep 2024 21:33:39 GMT, Kevin Rushforth wrote: > You mean `StyleAttributeMap.Builder`, right? Question then: how do I now > create a StyleAttributeMap from a CSS style? No, these methods are in `RichParagraph.Builder`. CSS styles in StyleAttributeMap are a special case, the attribute

Re: RFR: 8340852: ScrollPane should not consume navigation keys when it doesn't have direct focus

2024-10-01 Thread John Hendrikx
On Mon, 30 Sep 2024 15:31:52 GMT, Andy Goryachev wrote: > SCCE = Self-contained code example, or "complete code sample" in > https://wiki.openjdk.org/display/OpenJFX/Submitting+a+Bug+Report Ah, thank you, I hadn't seen this before. > I am not entirely convinced that the proposed solution addre

Re: RFR: 8301121: RichTextArea Control (Incubator) [v15]

2024-10-01 Thread Andy Goryachev
On Mon, 30 Sep 2024 21:05:10 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> file operations > > modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/RichTextArea

Re: RFR: 8183521: Unable to type characters with tilde with swiss german keyboard layout

2024-10-01 Thread Andy Goryachev
On Mon, 30 Sep 2024 16:30:49 GMT, Martin Fox wrote: > The glass code on Windows does its own dead key processing so at certain > points it must clear the dead key state that the OS is maintaining. It does > this by simulating a SPACE key press but this only works reliably if the > SPACE key is

Re: RFR: 8340852: ScrollPane should not consume navigation keys when it doesn't have direct focus

2024-10-01 Thread Andy Goryachev
On Thu, 26 Sep 2024 21:17:55 GMT, John Hendrikx wrote: > This change modifies `ScrollPaneBehavior` to only consume keys that are > targetted at it. As `KeyEvent`s are in almost all cases only intended for > the targetted node (as visually that's where the user expects the keyboard > input to

Re: RFR: 8183521: Unable to type characters with tilde with swiss german keyboard layout [v2]

2024-10-01 Thread Martin Fox
On Tue, 1 Oct 2024 19:01:39 GMT, Andy Goryachev wrote: >> Martin Fox has updated the pull request incrementally with one additional >> commit since the last revision: >> >> No point in the kbState being static here > > modules/javafx.graphics/src/main/native-glass/win/ViewContainer.cpp line 5

Re: RFR: 8183521: Unable to type characters with tilde with swiss german keyboard layout [v2]

2024-10-01 Thread Martin Fox
> The glass code on Windows does its own dead key processing so at certain > points it must clear the dead key state that the OS is maintaining. It does > this by simulating a SPACE key press but this only works reliably if the > SPACE key is pressed without any modifiers. > > Currently the cod

Re: RFR: 8301121: RichTextArea Control (Incubator) [v18]

2024-10-01 Thread Andy Goryachev
> Incubating a new feature - rich text control, **RichTextArea**, intended to > bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The > main design goal is to provide a control that is complete enough to be useful > out-of-the box, as well as open to extension by the appl

Integrated: 8332895: Support interpolation for backgrounds and borders

2024-10-01 Thread Michael Strauß
On Tue, 30 Jul 2024 16:03:46 GMT, Michael Strauß wrote: > This PR completes the CSS Transitions story (see #870) by adding > interpolation support for backgrounds and borders, making them targetable by > transitions. > > `Background` and `Border` objects are deeply immutable, but not > interp

Re: RFR: 8340852: ScrollPane should not consume navigation keys when it doesn't have direct focus

2024-10-01 Thread Andy Goryachev
On Tue, 1 Oct 2024 10:49:58 GMT, John Hendrikx wrote: > Here is a minimal working example Very helpful, thank you. I would say the use of arrow keys to traverse focus in this case _looks to me_ to be application-specific. In other words, this may or may not be the desired behavior. In the c

Re: Integrated: 8340982: [win] Dead key followed by Space generates two characters instead of one

2024-10-01 Thread Johan Corveleyn
On Mon, Sep 30, 2024 at 5:23 PM Kevin Rushforth wrote: > > Gluon maintains JavaFX 17 and 21, so Johan can answer that. > > There is no maintainer for the JavaFX 8 or 11 code lines in OpenJDK. Ah yes, for 8 we use the Oracle JDK which includes its JavaFX build. So for backport to Oracle Java 8 I g

Re: RFR: 8301121: RichTextArea Control (Incubator) [v15]

2024-10-01 Thread Andy Goryachev
On Tue, 1 Oct 2024 16:17:31 GMT, Kevin Rushforth wrote: >> the javadoc was incorrect, thanks for catching. >> rephrased to say >> "Any failures, such as the control being not editable, or out of memory >> condition, will be silently ignored. " >> >> Currently, there is no way to provide an erro

Re: RFR: 8183521: Unable to type characters with tilde with swiss german keyboard layout [v2]

2024-10-01 Thread Andy Goryachev
On Tue, 1 Oct 2024 20:17:52 GMT, Martin Fox wrote: >> The glass code on Windows does its own dead key processing so at certain >> points it must clear the dead key state that the OS is maintaining. It does >> this by simulating a SPACE key press but this only works reliably if the >> SPACE key

RFR: 8341372: BackgroundPosition, BorderImage, BorderStroke, CornerRadii should be final

2024-10-01 Thread Michael Strauß
Backgrounds and borders are comprised of immutable and final types. The following types are marked with the `final` modifier: * Background * BackgroundFill * BackgroundImage * BackgroundSize * Border * BorderWidths The following types are not marked with the `final` modifier: * BackgroundPositi

Re: RFR: 8341372: BackgroundPosition, BorderImage, BorderStroke, CornerRadii should be final

2024-10-01 Thread Michael Strauß
On Tue, 1 Oct 2024 22:29:39 GMT, Andy Goryachev wrote: > There might be a very narrow use case (like debugging) when developer might > need to extend to supply a custom `toString()` or some other method. > > From a high level design standpoint, I do agree with making these classes > final. Ma

Re: RFR: 8183521: Unable to type characters with tilde with swiss german keyboard layout [v2]

2024-10-01 Thread Andy Goryachev
On Tue, 1 Oct 2024 20:17:52 GMT, Martin Fox wrote: >> The glass code on Windows does its own dead key processing so at certain >> points it must clear the dead key state that the OS is maintaining. It does >> this by simulating a SPACE key press but this only works reliably if the >> SPACE key

Re: RFR: 8341372: BackgroundPosition, BorderImage, BorderStroke, CornerRadii should be final

2024-10-01 Thread Andy Goryachev
On Tue, 1 Oct 2024 21:46:21 GMT, Michael Strauß wrote: > Backgrounds and borders are comprised of immutable and final types. The > following types are marked with the `final` modifier: > > * Background > * BackgroundFill > * BackgroundImage > * BackgroundSize > * Border > * BorderWidths > > Th

Re: RFR: 8340829: Generated API docs should clearly identify EA builds [v2]

2024-10-01 Thread Ambarish Rapte
On Fri, 27 Sep 2024 13:07:15 GMT, Kevin Rushforth wrote: >> This PR modifies the header and footer of the javadoc-generated API docs to >> add "DRAFT $VER-ea+$BLD" to clearly identify an ea build of the docs, and >> also to make it clear which build number the docs refer to. This matches was >

Re: RFR: 8183521: Unable to type characters with tilde with swiss german keyboard layout [v2]

2024-10-01 Thread Martin Fox
On Tue, 1 Oct 2024 20:17:52 GMT, Martin Fox wrote: >> The glass code on Windows does its own dead key processing so at certain >> points it must clear the dead key state that the OS is maintaining. It does >> this by simulating a SPACE key press but this only works reliably if the >> SPACE key