On Mon, 30 Sep 2024 21:52:33 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
> I think the following behavior is probably what we want for RichTextArea
> (control) methods:
I fully agree.
I believe this is how it currently works (unless I missed a spot).
> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/RichTextArea.java
> line 1166:
>
>> 1164: * This method does nothing if the model or the caret position is
>> {@code null}.
>> 1165: * The default implementation may throw an {@code
>> UnsupportedOperationException}
>> 1166: * if the control is not editable. When this happens, the copying
>> to clipboard will succeed.
>
> Same question here (and elsewhere so I won't repeat after this) : should this
> throw an exception here since it is the target of an input function tag? If
> so, then it should throw on a null model rather than doing nothing; as it
> stands, it is inconsistent.
the javadoc was incorrect, thanks for catching.
rephrased to say
"Any failures, such as the control being not editable, or out of memory
condition, will be silently ignored. "
Currently, there is no way to provide an error feedback (audio or visual), such
as `beep()`. Perhaps we need to add Tags.ERROR so that application can
implement its own.
Another issue is logging - it would be nice to provide a mechanism to plug in
into application logging subsystem, whatever that is. create a protected
method?
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1524#issuecomment-2386342688
PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1783085525
