On Tue, 1 Oct 2024 19:01:39 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Martin Fox has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> No point in the kbState being static here
>
> modules/javafx.graphics/src/main/native-glass/win/ViewContainer.cpp line 550:
>
>> 548:
>> 549: // Since we handle dead keys ourselves, reset the keyboard dead key
>> status (if any)
>> 550: static BYTE kbState[256] = {};
>
> my c++ is a bit rusty, do we need `static` here?
There's no point in this being static. I've updated the PR.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1585#discussion_r1783478748
