On Tue, 1 Oct 2024 15:30:39 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/RichTextArea.java
>> line 1166:
>>
>>> 1164: * This method does nothing if the model or the caret position is
>>> {@code null}.
>>> 1165: * The default implementation may throw an {@code
>>> UnsupportedOperationException}
>>> 1166: * if the control is not editable. When this happens, the
>>> copying to clipboard will succeed.
>>
>> Same question here (and elsewhere so I won't repeat after this) : should
>> this throw an exception here since it is the target of an input function
>> tag? If so, then it should throw on a null model rather than doing nothing;
>> as it stands, it is inconsistent.
>
> the javadoc was incorrect, thanks for catching.
> rephrased to say
> "Any failures, such as the control being not editable, or out of memory
> condition, will be silently ignored. "
>
> Currently, there is no way to provide an error feedback (audio or visual),
> such as `beep()`. Perhaps we need to add Tags.ERROR so that application can
> implement its own.
>
> Another issue is logging - it would be nice to provide a mechanism to plug in
> into application logging subsystem, whatever that is. create a protected
> method?
I don't think we want to get into the logging business. We currently use the
System logger for all of our logging. Unless there is some compelling reason we
need to do more, we should stick with that.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1783154150
