On Mon, 5 May 2025 21:28:08 GMT, Ziad El Midaoui wrote:
>> The issue was happening because `-fx-highlight-text-fill` was set to white ,
>> so when the background color is bright (>60% brightness ) the text is not
>> visible , the solution is to change the value to be dynamically set
>> dependi
On Mon, 5 May 2025 21:28:08 GMT, Ziad El Midaoui wrote:
>> The issue was happening because `-fx-highlight-text-fill` was set to white ,
>> so when the background color is bright (>60% brightness ) the text is not
>> visible , the solution is to change the value to be dynamically set
>> dependi
On Mon, 5 May 2025 21:28:08 GMT, Ziad El Midaoui wrote:
>> The issue was happening because `-fx-highlight-text-fill` was set to white ,
>> so when the background color is bright (>60% brightness ) the text is not
>> visible , the solution is to change the value to be dynamically set
>> dependi
On Mon, 5 May 2025 21:28:08 GMT, Ziad El Midaoui wrote:
>> The issue was happening because `-fx-highlight-text-fill` was set to white ,
>> so when the background color is bright (>60% brightness ) the text is not
>> visible , the solution is to change the value to be dynamically set
>> dependi
> The issue was happening because `-fx-highlight-text-fill` was set to white ,
> so when the background color is bright (>60% brightness ) the text is not
> visible , the solution is to change the value to be dynamically set depending
> on the level of brightness of the background this is done b
On Mon, 5 May 2025 17:37:31 GMT, Ziad El Midaoui wrote:
>> The issue was happening because `-fx-highlight-text-fill` was set to white ,
>> so when the background color is bright (>60% brightness ) the text is not
>> visible , the solution is to change the value to be dynamically set
>> dependi
On Mon, 5 May 2025 14:32:27 GMT, Kevin Rushforth wrote:
>> Ziad El Midaoui has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Created ModenaTest
>
> modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/skin/modena/ModenaT
On Mon, 5 May 2025 14:46:01 GMT, Andy Goryachev wrote:
>> Ziad El Midaoui has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Created ModenaTest
>
> modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/skin/modena/ModenaTe
> The issue was happening because `-fx-highlight-text-fill` was set to white ,
> so when the background color is bright (>60% brightness ) the text is not
> visible , the solution is to change the value to be dynamically set depending
> on the level of brightness of the background this is done b
On Mon, 5 May 2025 14:27:17 GMT, Ziad El Midaoui wrote:
>> The issue was happening because `-fx-highlight-text-fill` was set to white ,
>> so when the background color is bright (>60% brightness ) the text is not
>> visible , the solution is to change the value to be dynamically set
>> dependi
On Mon, 5 May 2025 14:27:17 GMT, Ziad El Midaoui wrote:
>> The issue was happening because `-fx-highlight-text-fill` was set to white ,
>> so when the background color is bright (>60% brightness ) the text is not
>> visible , the solution is to change the value to be dynamically set
>> dependi
> The issue was happening because `-fx-highlight-text-fill` was set to white ,
> so when the background color is bright (>60% brightness ) the text is not
> visible , the solution is to change the value to be dynamically set depending
> on the level of brightness of the background this is done b
On Sat, 3 May 2025 07:22:50 GMT, Michael Strauß wrote:
>> I can put the test in the `StylesheetTest` class, which might be more
>> appropriate for this case. what do you think ?
>
>> I can put the test in the `StylesheetTest` class, which might be more
>> appropriate for this case. what do you
On Thu, 1 May 2025 22:08:46 GMT, Ziad El Midaoui wrote:
> The issue was happening because `-fx-highlight-text-fill` was set to white ,
> so when the background color is bright (>60% brightness ) the text is not
> visible , the solution is to change the value to be dynamically set depending
> o
On Fri, 2 May 2025 23:27:38 GMT, Ziad El Midaoui wrote:
> I can put the test in the `StylesheetTest` class, which might be more
> appropriate for this case. what do you think ?
No, because you're not testing the `Stylesheet` class either. What you are
doing is testing the Modena theme, for whi
On Thu, 1 May 2025 22:08:46 GMT, Ziad El Midaoui wrote:
> The issue was happening because `-fx-highlight-text-fill` was set to white ,
> so when the background color is bright (>60% brightness ) the text is not
> visible , the solution is to change the value to be dynamically set depending
> o
On Fri, 2 May 2025 21:09:12 GMT, Michael Strauß wrote:
> I don't think we need to repeat that for each individual property, at least
> not manually.
Maybe not manually, but a reflection-based test that verifies each `Styleable`
property (and also verify that these properties are listed in the
On Fri, 2 May 2025 20:38:39 GMT, Andy Goryachev wrote:
> We already have `fontSetFromCSS()` test there, so I am not against adding a
> test in this file.
That's not my point. `fontSetFromCSS` tests whether a font can be set via CSS,
which concerns the implementation of `TextInputControl`. In c
On Fri, 2 May 2025 19:24:40 GMT, Michael Strauß wrote:
> I'm interested in a second opinion on whether we should do this kind of
> testing, and what in particular it should accomplish.
We already have `fontSetFromCSS()` test there, so I am not against adding a
test in this file.
You do bring
On Thu, 1 May 2025 22:08:46 GMT, Ziad El Midaoui wrote:
> The issue was happening because `-fx-highlight-text-fill` was set to white ,
> so when the background color is bright (>60% brightness ) the text is not
> visible , the solution is to change the value to be dynamically set depending
> o
On Thu, 1 May 2025 22:08:46 GMT, Ziad El Midaoui wrote:
> The issue was happening because `-fx-highlight-text-fill` was set to white ,
> so when the background color is bright (>60% brightness ) the text is not
> visible , the solution is to change the value to be dynamically set depending
> o
21 matches
Mail list logo
