On Sat, 3 May 2025 07:22:50 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> I can put the test in the `StylesheetTest` class, which might be more >> appropriate for this case. what do you think ? > >> I can put the test in the `StylesheetTest` class, which might be more >> appropriate for this case. what do you think ? > > No, because you're not testing the `Stylesheet` class either. What you are > doing is testing the Modena theme, for which we have no appropriate testing > methodology in JavaFX. I would rather just remove the test entirely, because > this new test is going to be another person's future work. It's also more of > a change tracker than a unit test, as a style is not a meaningful unit of > code. If we want to start testing stylesheets, we should first have a > discussion on goals and methodology. I agree with @mstr2 and @Maran23 that this test should not be in any existing test class. It isn't testing the CSS engine or any particular aspect of stylesheets in general. Rather it is testing an aspect of the `modena.css` stylesheet in particular. I recommend creating a new test class, perhaps under `test.com.sun.javafx.scene.control.skin.modena`. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1801#issuecomment-2850914010
